Bug#802786: libsigc++-2.0-dev: c++ only option in cflags

2015-10-27 Thread Emilio Pozuelo Monfort
Control: severity -1 serious

On 23/10/15 17:43, Michael Biebl wrote:
> Am 23.10.2015 um 17:01 schrieb Michael Biebl:
>> cc1: error: command line option '-std=c++11' is valid for C++/ObjC++ but
>>> not for C [-Werror]
>>>
>>> Removing -std=c++11 from your .pc files makes these packages build
>>> again.
> 
> Afaics, this is a warning by default. So the mere existence of
> -std=c++11 does not make said package ftbfs, only if you combine that
> with -Werror.
> It would also be good to have an actual list of packages which FTBFS
> because of that.
> I recompiled all rdeps of libsigc++2.0-dev/libglibmm2.4-dev before
> applying that change and did not notice any build failures because of that.
> 
> The alternative to dropping the .pc file hack is to have ~90 RC bugs
> [1]. As said, it would be good to have an actual list of packages
> failing to build because of that change. This would make it easier to
> evaluate the situation.
> If there are only one or two, dropping -Werror for those package seems
> like the better alternative then having to touch 90 packages.
> 
> CCing Emilio in his role as release manager. I talked to him about this
> issue before making this change.
> 
> Let's hear his input.

We should keep this bug open and drop -std=c++11 once we have GCC 6 (which
should default to c++11 IIRC) and will happen during this cycle. I'd rather have
this problem here affecting one rdep than have 80 RC bugs.

In the meantime, let's make this bug RC so we don't forget to fix it before the
Stretch release. Bumping the severity.

Cheers,
Emilio



Bug#802786: libsigc++-2.0-dev: c++ only option in cflags

2015-10-24 Thread Bernd Zeimetz
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256



On 10/23/2015 05:01 PM, Michael Biebl wrote:
> Which packages fail to build because of that?

open-vm-tools for example:

libtool: compile:  gcc -DPACKAGE_NAME=\"open-vm-tools\" 
-DPACKAGE_TARNAME=\"open-vm-tools\" -DPACKAGE_VERSION=\"9.10.2\" 
"-DPACKAGE_STRING=\"open-vm-tools 9.10.2\"" 
-DPACKAGE_BUGREPORT=\"open-vm-tools-de...@lists.sourceforge.net\" 
-DPACKAGE_URL=\"\" -DPACKAGE=\"open-vm-tools\" -DVERSION=\"9.10.2\" 
-DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 
-DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 
-DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" 
-DHAVE_X11_SM_SMLIB_H=1 -DHAVE_X11_ICE_ICELIB_H=1 
-DHAVE_X11_EXTENSIONS_XCOMPOSITE_H=1 -DHAVE_ECVT=1 -DHAVE_FCVT=1 
-DDNET_IS_DUMBNET=1 -DHAVE_CRYPT_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_WCHAR_H=1 -DHAVE_SYS_IO_H=1 -DHAVE_SYS_PARAM_H=1 
-DHAVE_SYS_SYSINFO_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_USER_H=1 
-DHAVE_SYS_VFS_H=1 -DHAVE_UNWIND_H=1 -DHAVE__BOOL=1 -DHAVE_STDBOOL_H=1 
-DHAVE_STRUCT_STAT_ST_RDEV=1 -DTIME_WITH_SYS_TIME=1 -I. -pthread -I/usr/i
 n
clude/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include 
-I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 
-I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng12 -I/usr/include/pango-1.0 
-I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/freetype2 
-I/usr/include/libpng12 -DGTK2 -std=c++11 -pthread -I/usr/include/gtkmm-2.4 
-I/usr/lib/x86_64-linux-gnu/gtkmm-2.4/include -I/usr/include/atkmm-1.6 
-I/usr/include/gtk-unix-print-2.0 -I/usr/include/gtk-2.0 
-I/usr/include/gdkmm-2.4 -I/usr/lib/x86_64-linux-gnu/gdkmm-2.4/include 
-I/usr/include/giomm-2.4 -I/usr/lib/x86_64-linux-gnu/giomm-2.4/include 
-I/usr/include/pangomm-1.4 -I/usr/lib/x86_64-linux-gnu/pangomm-1.4/include 
-I/usr/include/glibmm-2.4 -I/usr/lib/x86_64-linux-gnu/glibmm-2.4/include 
-I/usr/include/cairomm-1.0 -I/usr/lib/x86_64-linux-gnu/cairomm-1.0/include 
-I/usr
 /
include/sigc++-2.0 -I/usr/lib/x86_64-linux-gnu/sigc++-2.0/include 
-I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include 
-I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 
-I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng12 -I/usr/include/pango-1.0 
-I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/freetype2 
-I/usr/include/libpng12 -DHAVE_GTKMM -DVMTOOLS_USE_GLIB -I/usr/include/glib-2.0 
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include -fvisibility=hidden 
-DGCC_EXPLICIT_EXPORT -I../../../services/plugins/dndcp/dnd 
-I../../../services/plugins/dndcp/dndGuest 
-I../../../services/plugins/dndcp/stringxx 
-I../../../services/plugins/dndcp/xutils -I../../../include 
-I/build/open-vm-tools-9.10.2-2822639/lib/include 
-I/build/open-vm-tools-9.10.2-2822639/lib/include -D_FORTIFY_SOURCE=2 
-DUSING_AUTOCONF=1 -DOPEN_VM_
 T
OOLS -DUSE_VGAUTH -I/usr/include -DUSE_ICU -DHAVE_ICU_38 -DVMX86_TOOLS 
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500 -D_BSD_SOURCE 
-D_SVID_SOURCE -D_DEFAULT_SOURCE -fPIC -Wno-deprecated-declarations -g -O2 
-fstack-protector-strong -Wformat -Werror=format-security -Wall -Werror 
-Wno-pointer-sign -Wno-unused-value -fno-strict-aliasing -Wno-unknown-pragmas 
-Wno-uninitialized -Wno-deprecated-declarations -Wno-unused-but-set-variable -c 
dnd/dndClipboard.c  -fPIC -DPIC -o .libs/libdndcp_la-dndClipboard.o
cc1: error: command line option '-std=c++11' is valid for C++/ObjC++ but not 
for C [-Werror]
cc1: all warnings being treated as errors
Makefile:625: recipe for target 'libdndcp_la-dndClipboard.lo' failed
make[5]: *** [libdndcp_la-dndClipboard.lo] Error 1
make[5]: Leaving directory 
'/build/open-vm-tools-9.10.2-2822639/services/plugins/dndcp'
Makefile:486: recipe for target 'all' failed
make[4]: *** [all] Error 2
make[4]: Leaving directory 
'/build/open-vm-tools-9.10.2-2822639/services/plugins/dndcp'
Makefile:454: recipe for target 'all-recursive' failed
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory 
'/build/open-vm-tools-9.10.2-2822639/services/plugins'
Makefile:446: recipe for target 'all-recursive' failed
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory '/build/open-vm-tools-9.10.2-2822639/services'
Makefile:506: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/build/open-vm-tools-9.10.2-2822639'
dh_auto_build: make -j1 returned exit code 2
debian/rules:8: recipe for target 'build' failed
make: *** [build] Error 2


- -- 
 Bernd ZeimetzDebian GNU/Linux Developer
 http://bzed.de

Bug#802786: libsigc++-2.0-dev: c++ only option in cflags

2015-10-24 Thread Bernd Zeimetz


On 10/24/2015 10:50 PM, Michael Biebl wrote:
> Am 24.10.2015 um 22:34 schrieb Bernd Zeimetz:
>> 
>> 
>> On 10/23/2015 05:01 PM, Michael Biebl wrote:
>>> Which packages fail to build because of that?
>> 
>> open-vm-tools for example:
> 
> Without -std=c++11, open-vm-tools still fails: 
> https://people.debian.org/~biebl/mm-stack/logs-sid/failed/open-vm-tools_9.10.2-2822639-3.log

Yes,
> 
of course, because its needed to compile the c++ files


> So either way you need a fix and dropping -Werror sounds like a 
> reasonably straightforward one.

Thats not an option.


> Is open-vm-tools the only package which you encountered?

for now, yes.


-- 
 Bernd ZeimetzDebian GNU/Linux Developer
 http://bzed.dehttp://www.debian.org
 GPG Fingerprint: ECA1 E3F2 8E11 2432 D485  DD95 EB36 171A 6FF9 435F



Bug#802786: libsigc++-2.0-dev: c++ only option in cflags

2015-10-24 Thread Michael Biebl
Am 24.10.2015 um 22:34 schrieb Bernd Zeimetz:
> 
> 
> On 10/23/2015 05:01 PM, Michael Biebl wrote:
>> Which packages fail to build because of that?
> 
> open-vm-tools for example:

Without -std=c++11, open-vm-tools still fails:
https://people.debian.org/~biebl/mm-stack/logs-sid/failed/open-vm-tools_9.10.2-2822639-3.log

So either way you need a fix and dropping -Werror sounds like a
reasonably straightforward one.

Is open-vm-tools the only package which you encountered?

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature


Bug#802786: libsigc++-2.0-dev: c++ only option in cflags

2015-10-23 Thread Bernd Zeimetz

Package: libsigc++-2.0-dev
Version: 2.6.1-3
Seveirity: grave

hi,

sigc++-2.0.pc has -std=c++11 in the Cflags option - but -std= is a
c++ compiler only option. So packages which depend on your library
(for example packages using gtkmm) ftbfs trying to compile their C
code with

cc1: error: command line option '-std=c++11' is valid for C++/ObjC++ but 
not for C [-Werror]


Removing -std=c++11 from your .pc files makes these packages build
again.
I can see that there is a problem to require -std=c++11 while
pkg-config only provides Cflags as an option. But putting flags
gcc whines about into Cflags is not an option unfortunately.
Thats what cxxflags are for - which are not supported by pkg-config
unfortunately as far as I can see.

thanks,

Bernd



--
 Bernd ZeimetzDebian GNU/Linux Developer
 http://bzed.dehttp://www.debian.org
 GPG Fingerprint: ECA1 E3F2 8E11 2432 D485  DD95 EB36 171A 6FF9 435F



Bug#802786: libsigc++-2.0-dev: c++ only option in cflags

2015-10-23 Thread Michael Biebl
Am 23.10.2015 um 17:01 schrieb Michael Biebl:
> cc1: error: command line option '-std=c++11' is valid for C++/ObjC++ but
>> not for C [-Werror]
>> 
>> Removing -std=c++11 from your .pc files makes these packages build
>> again.

Afaics, this is a warning by default. So the mere existence of
-std=c++11 does not make said package ftbfs, only if you combine that
with -Werror.
It would also be good to have an actual list of packages which FTBFS
because of that.
I recompiled all rdeps of libsigc++2.0-dev/libglibmm2.4-dev before
applying that change and did not notice any build failures because of that.

The alternative to dropping the .pc file hack is to have ~90 RC bugs
[1]. As said, it would be good to have an actual list of packages
failing to build because of that change. This would make it easier to
evaluate the situation.
If there are only one or two, dropping -Werror for those package seems
like the better alternative then having to touch 90 packages.

CCing Emilio in his role as release manager. I talked to him about this
issue before making this change.

Let's hear his input.

Michael




[1] https://people.debian.org/~biebl/mm-stack/logs-sid/failed/
-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature


Bug#802786: libsigc++-2.0-dev: c++ only option in cflags

2015-10-23 Thread Michael Biebl
Am 23.10.2015 um 16:47 schrieb Bernd Zeimetz:
> Package: libsigc++-2.0-dev
> Version: 2.6.1-3
> Seveirity: grave
> 
> hi,
> 
> sigc++-2.0.pc has -std=c++11 in the Cflags option - but -std= is a
> c++ compiler only option. So packages which depend on your library
> (for example packages using gtkmm) ftbfs trying to compile their C
> code with
> 
> cc1: error: command line option '-std=c++11' is valid for C++/ObjC++ but
> not for C [-Werror]
> 
> Removing -std=c++11 from your .pc files makes these packages build
> again.
> I can see that there is a problem to require -std=c++11 while
> pkg-config only provides Cflags as an option. But putting flags
> gcc whines about into Cflags is not an option unfortunately.
> Thats what cxxflags are for - which are not supported by pkg-config
> unfortunately as far as I can see.

Which packages fail to build because of that?


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature