Bug#802894: python-invoke: FTBFS with Python 3.5 as default: cannot import name 'mswindows'

[Dmitry Shachnev]

Source: python-invoke
Version: 0.9.0-2
Severity: important
Tags: patch
User: debian-pyt...@lists.debian.org
Usertags: python3.5

Dear Maintainer,

python-invoke FTBFS when 3.5 is the default Python 3 version:

  nosetests3
  E
  ======================================================================
  ERROR: Failure: ImportError (cannot import name 'mswindows')
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/usr/lib/python3/dist-packages/nose/failure.py", line 39, in runTest
      raise self.exc_val.with_traceback(self.tb)
    File "/usr/lib/python3/dist-packages/nose/loader.py", line 420, in 
loadTestsFromName
      addr.filename, addr.module)
    File "/usr/lib/python3/dist-packages/nose/importer.py", line 47, in 
importFromPath
      return self.importFromDir(dir_path, fqname)
    File "/usr/lib/python3/dist-packages/nose/importer.py", line 94, in 
importFromDir
      mod = load_module(part_fqname, fh, filename, desc)
    File "/usr/lib/python3.5/imp.py", line 244, in load_module
      return load_package(name, filename)
    File "/usr/lib/python3.5/imp.py", line 216, in load_package
      return _load(spec)
    File "<frozen importlib._bootstrap>", line 693, in _load
    File "<frozen importlib._bootstrap>", line 673, in _load_unlocked
    File "<frozen importlib._bootstrap_external>", line 662, in exec_module
    File "<frozen importlib._bootstrap>", line 222, in _call_with_frames_removed
    File "/«PKGBUILDDIR»/invoke/__init__.py", line 2, in <module>
      from .tasks import task, ctask, Task
    File "/«PKGBUILDDIR»/invoke/tasks.py", line 11, in <module>
      from .context import Context
    File "/«PKGBUILDDIR»/invoke/context.py", line 3, in <module>
      from .runner import run
    File "/«PKGBUILDDIR»/invoke/runner.py", line 5, in <module>
      from .monkey import Popen, PIPE
    File "/«PKGBUILDDIR»/invoke/monkey.py", line 4, in <module>
      from subprocess import Popen as OriginalPopen, mswindows, PIPE
  ImportError: cannot import name 'mswindows'

  ----------------------------------------------------------------------
  Ran 1 test in 0.015s

  FAILED (errors=1)
  make[1]: *** [override_dh_auto_test] Error 1

The attached patch fixes the issue.

--
Dmitry Shachnev
Description: do not rely on undocumented unittest.mswindows variable
 This variable has been renamed to _mswindows in Python 3.5, however
 we do not need it on Debian at all.
Author: Dmitry Shachnev <mity...@debian.org>
Forwarded: not-needed
 This monkey.py file has been dropped in the latest upstream release
 altogether.
Last-Update: 2015-10-24

--- a/invoke/monkey.py
+++ b/invoke/monkey.py
@@ -1,7 +1,7 @@
 # Fuckin' A.
 
 import select, errno, os, sys
-from subprocess import Popen as OriginalPopen, mswindows, PIPE
+from subprocess import Popen as OriginalPopen, PIPE
 
 import six
 
@@ -23,7 +23,7 @@
     #
     # Copy/modified code from upstream
     #
-    if mswindows:
+    if False:
         def _readerthread(self, fh, buffer):
             # TODO: How to determine which sys.std(out|err) to use?
             buffer.append(fh.read())

signature.asc
Description: OpenPGP digital signature