Bug#803986: transgui: regenerate Makefile from Makefile.fpc

[Graham Inggs]

On 14 August 2017 at 20:59, Andreas Noteng  wrote:
> I am regenerating, but in configure. This fail is in the initial clean.
> Would it be ok to move the makefile regeneration to clean instead?

That might work.  The patch in message #23 [1] definitely worked in
Ubuntu [2] though.

P.S. debhelper Build-Depends version in debian/control should match
debian/compat.
Also, debhelper 10 has been available for almost a year already.


[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=803986#23
[2] https://launchpad.net/ubuntu/+source/transgui/5.0.1-4.1ubuntu1

Bug#803986: transgui: regenerate Makefile from Makefile.fpc

[Andreas Noteng]

I am regenerating, but in configure. This fail is in the initial clean.
Would it be ok to move the makefile regeneration to clean instead?

2017-08-14 13:26 GMT+02:00 Graham Inggs :

> Control: reopen -1
>
>
> As per the latest arm64 build log [1], this is still not fixed:
>
> make -j1 distclean
> make[1]: Entering directory '/<>'
> Makefile:196: *** The Makefile doesn't support target aarch64-linux,
> please run fpcmake first.  Stop.
>
>
> [1] https://buildd.debian.org/status/fetch.php?pkg=transgui;
> arch=arm64=5.0.1-5=1502627826=0
>

Bug#803986: transgui: regenerate Makefile from Makefile.fpc

[Graham Inggs]

Control: reopen -1


As per the latest arm64 build log [1], this is still not fixed:

make -j1 distclean
make[1]: Entering directory '/<>'
Makefile:196: *** The Makefile doesn't support target aarch64-linux,
please run fpcmake first.  Stop.


[1] 
https://buildd.debian.org/status/fetch.php?pkg=transgui=arm64=5.0.1-5=1502627826=0

Bug#803986: transgui: regenerate Makefile from Makefile.fpc

[Graham Inggs]

Control: tags -1 + patch

Hi Maintainer

The patch as applied is not sufficient, as can be seen in a recent
arm64 build log [1].
If the old Makefile exists, the build fails during the dh_auto_clean target:

dh_auto_clean: Compatibility levels before 9 are deprecated (level 7 in use)
make -j1 distclean
make[1]: Entering directory '/«PKGBUILDDIR»'
Makefile:196: *** The Makefile doesn't support target aarch64-linux,
please run fpcmake first.  Stop.

The following patch removes Makefile before dh_auto_clean, and the
build succeeds on arm64.

-- a/debian/rules
+++ b/debian/rules
@@ -13,6 +13,10 @@
 export FPCDIR=/usr/lib/fpc/${FPCVER}
 endif

+override_dh_auto_clean:
+rm -f Makefile
+dh_auto_clean
+
 override_dh_auto_configure:
 fpcmake

Regards
Graham


[1] 
https://buildd.debian.org/status/fetch.php?pkg=transgui=arm64=5.0.1-4.1=1487280220=0

Bug#803986: transgui: regenerate Makefile from Makefile.fpc

[Edmund Grimley Evans]

Source: transgui
Version: 5.0.1-2

The Debian build script seems to be using upstream's Makefile,
which was "generated by FPCMake Version 2.0.0 [2011/12/25]".
It would be better to regenerate this file for two reasons:

- It becomes possible to build the package on new architectures,
  such as arm64.

- You verify that it is possible to build the package from source. If
  you don't regularly test it you can't be sure that you can generate
  the Makefile with the tools in Debian.

(The situation seems analogous to a package that does not "run
dh-autoreconf to update for new architectures".)

I think you can fix this by adding the following to debian/rules,
but you should check carefully, and perhaps there's a simpler way:

# Define FPC
ifndef FPC
FPC=/usr/bin/fpc
endif

FPCVER=$(shell ${FPC} -iV)

# Define FPCDIR if it was not set
ifndef FPCDIR
export FPCDIR=/usr/lib/fpc/${FPCVER}
endif

override_dh_auto_configure:
fpcmake