Bug#805893: clblas: add -mxgot option to CFLAGS and CXXFLAGS for mips*64{el}

[Ghislain Vaillant]

Hi YunQiang Su,

Thanks for reporting this and providing a patch with some explanation of 
what it does.


Just to be sure, when you say:

> I also add the same extra options to CXXFLAGS as CFLAGS.
> This patch can fix FTBFS on mips64el.

Do you mean the patch fixes the issue *for sure*, or is it just a guess?

Usage of "can" is not particularly assertive, hence me asking for a 
confirmation.


Cheers,
Ghis

Bug#805893: clblas: add -mxgot option to CFLAGS and CXXFLAGS for mips*64{el}

[Andrei POPESCU]

Control: reassign -1 src:clblas 2.8+ds1-1

On Ma, 24 nov 15, 01:12:22, YunQiang Su wrote:
> Package: src:clblash
> Version:2.8+ds1-1
> 
> diff -Nru clblas-2.8+ds1/debian/rules clblas-2.8+ds1/debian/rules
> --- clblas-2.8+ds1/debian/rules 2015-10-28 23:09:33.0 +
> +++ clblas-2.8+ds1/debian/rules 2015-11-23 17:03:33.0 +
> @@ -7,6 +7,7 @@
>  # Hardening flags.
>  export DEB_BUILD_MAINT_OPTIONS = hardening=+all
>  export DEB_CFLAGS_MAINT_APPEND = -Wall -pedantic
> +export DEB_CXXFLAGS_MAINT_APPEND = -Wall
>  export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed
> 
>  # Environment information.
> @@ -16,6 +17,12 @@
>  # Build without Altivec to prevent FTBFS on ppc64el.
>  ifeq ($(DEB_HOST_ARCH),ppc64el)
>  DEB_CFLAGS_MAINT_APPEND += -mno-altivec
> +DEB_CXXFLAGS_MAINT_APPEND += -mno-altivec
> +endif
> +# Build without Altivec to prevent FTBFS on ppc64el.
> +ifneq (,$(filter mips64%el mips64%el,$(DEB_HOST_ARCH)))
> +DEB_CFLAGS_MAINT_APPEND += -mxgot
> +DEB_CXXFLAGS_MAINT_APPEND += -mxgot
>  endif
> 
>  %:
> 
> 
> I also add the same extra options to CXXFLAGS as CFLAGS.
> This patch can fix FTBFS on mips64el.
> 
> filter mips%64 mips%64el,$(DEB_HOST_ARCH)
> is due to we may has some other mips64 architectures in future,
> for example: mips64r6{el}.
> 
> 
> -- 
> YunQiang Su

-- 
http://wiki.debian.org/FAQsFromDebianUser
Offtopic discussions among Debian users and developers:
http://lists.alioth.debian.org/mailman/listinfo/d-community-offtopic
http://nuvreauspam.ro/gpg-transition.txt


signature.asc
Description: Digital signature

Bug#805893: clblas: add -mxgot option to CFLAGS and CXXFLAGS for mips*64{el}

[YunQiang Su]

Package: src:clblash
Version:2.8+ds1-1

diff -Nru clblas-2.8+ds1/debian/rules clblas-2.8+ds1/debian/rules
--- clblas-2.8+ds1/debian/rules 2015-10-28 23:09:33.0 +
+++ clblas-2.8+ds1/debian/rules 2015-11-23 17:03:33.0 +
@@ -7,6 +7,7 @@
 # Hardening flags.
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
 export DEB_CFLAGS_MAINT_APPEND = -Wall -pedantic
+export DEB_CXXFLAGS_MAINT_APPEND = -Wall
 export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed

 # Environment information.
@@ -16,6 +17,12 @@
 # Build without Altivec to prevent FTBFS on ppc64el.
 ifeq ($(DEB_HOST_ARCH),ppc64el)
 DEB_CFLAGS_MAINT_APPEND += -mno-altivec
+DEB_CXXFLAGS_MAINT_APPEND += -mno-altivec
+endif
+# Build without Altivec to prevent FTBFS on ppc64el.
+ifneq (,$(filter mips64%el mips64%el,$(DEB_HOST_ARCH)))
+DEB_CFLAGS_MAINT_APPEND += -mxgot
+DEB_CXXFLAGS_MAINT_APPEND += -mxgot
 endif

 %:


I also add the same extra options to CXXFLAGS as CFLAGS.
This patch can fix FTBFS on mips64el.

filter mips%64 mips%64el,$(DEB_HOST_ARCH)
is due to we may has some other mips64 architectures in future,
for example: mips64r6{el}.


-- 
YunQiang Su