Bug#807151: ninja-build: ninja-mode.el buffer local comment-start

[Felix Geyer]

Hi,

On Sun, 06 Dec 2015 15:37:55 +1100 Kevin Ryde  wrote:
> Package: ninja-build
> Version: 1.5.1-0.1
> Severity: normal
> Tags: patch
> File: /usr/share/emacs/site-lisp/ninja-mode.el
> 
> ninja-mode.el has
> 
> (setq comment-start "#")
> 
> which sets the comment-start string globally (affecting all buffers
> without their own setting).  A major mode usually should be buffer-local
> 
> (set (make-local-variable 'comment-start) "#")

Could you please report this and the other bugs about ninja-mode.el upstream:
https://github.com/ninja-build/ninja

Once upstream has accepted the changes I can cherry-pick them in the Debian 
package.

Thanks,
Felix

Bug#807151: ninja-build: ninja-mode.el buffer local comment-start

[Kevin Ryde]

Package: ninja-build
Version: 1.5.1-0.1
Severity: normal
Tags: patch
File: /usr/share/emacs/site-lisp/ninja-mode.el

ninja-mode.el has

(setq comment-start "#")

which sets the comment-start string globally (affecting all buffers
without their own setting).  A major mode usually should be buffer-local

(set (make-local-variable 'comment-start) "#")


-- System Information:
Debian Release: stretch/sid
Architecture: i386 (i686)

Kernel: Linux 4.2.0-1-686-pae (SMP w/1 CPU core)
Locale: LANG=en_AU.utf8, LC_CTYPE=en_AU.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages ninja-build depends on:
ii  libc6   2.19-22
ii  libgcc1 1:5.2.1-27
ii  libstdc++6  5.2.1-27

ninja-build recommends no packages.

ninja-build suggests no packages.

-- no debconf information