Bug#809085: RFS: sxiv/1.3.2-1

2015-12-27 Thread Daniel Echeverry
Hi Jakub

2015-12-27 6:41 GMT-05:00 Jakub Wilk :
> * Daniel Echeverry , 2015-12-26, 23:56:
>>
>> http://mentors.debian.net/debian/pool/main/s/sxiv/sxiv_1.3.2-1.dsc
>
>
> Typo in the patch name: behaivor -> behavior

Fixed!

>
> You might want to add the Bugs-Debian header to the patch header.
>

Fixed!

> exec/key-handler uses temporary files insecurely.
>

Could you give me some info about  this? I am confused, please point
me out to some useful url, thanks

> Lintian says:
> X: sxiv: binary-file-built-without-LFS-support usr/bin/sxiv
>
> Now, I doubt sxiv could do anything sensible with >2GB images on a 32-bit
> system anyway. But it turns out that you can be bitten by lack on LFS
> support even when all your files are small:
> https://lists.debian.org/20150712173723.ga29...@gaara.hadrons.org
>
> sxiv calls stat() in multiple places, so I think you should enable LFS.

Fixed!

>
> --
> Jakub Wilk
>

Thank for you review!

Regards

-- 
Daniel Echeverry
http://wiki.debian.org/DanielEcheverry
Linux user: #477840
Debian user
Software libre



Bug#809085: RFS: sxiv/1.3.2-1

2015-12-27 Thread Jakub Wilk

* Daniel Echeverry , 2015-12-26, 23:56:

http://mentors.debian.net/debian/pool/main/s/sxiv/sxiv_1.3.2-1.dsc


Typo in the patch name: behaivor -> behavior

You might want to add the Bugs-Debian header to the patch header.

exec/key-handler uses temporary files insecurely.

Lintian says:
X: sxiv: binary-file-built-without-LFS-support usr/bin/sxiv

Now, I doubt sxiv could do anything sensible with >2GB images on a 
32-bit system anyway. But it turns out that you can be bitten by lack on 
LFS support even when all your files are small:

https://lists.debian.org/20150712173723.ga29...@gaara.hadrons.org

sxiv calls stat() in multiple places, so I think you should enable LFS.

--
Jakub Wilk



Bug#809085: RFS: sxiv/1.3.2-1

2015-12-26 Thread Daniel Echeverry
Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "sxiv"

 * Package name: sxiv
   Version : 1.3.2-1
   Upstream Author : Bert Munnich 
 * URL : https://github.com/muennich/sxiv
 * License : GPL-2.0+
   Section : graphics

It builds those binary packages:

sxiv  - simple X image viewer

To access further information about this package, please visit the
following URL:

  http://mentors.debian.net/package/sxiv

Alternatively, one can download the package with dget using this command:

dget -x http://mentors.debian.net/debian/pool/main/s/sxiv/sxiv_1.3.2-1.dsc

More information about sxiv can be obtained from
https://github.com/muennich/sxiv

Changes since the last upload:

  * New upstream release.
  * debian/patches
+ Refresh install_icons.diff patch.
+ Refresh not_install_examples.diff patch.
+ Add fix_undefined_behaivor.diff patch.
  + Fix undefined behavior/uninitialised variables. (Closes: #795290)
 + Thanks to George Bradshaw for the patch
  * debian/sxiv.install
+ Install desktop file. (Closes: #796720)
  * remove sxiv.menu file.
+ Now is prohibited install both files (desktop and menu file).
  * debian/copyright
+ Extend copyright holders years.

Regards,
Daniel Echeverry

-- 
Daniel Echeverry
http://wiki.debian.org/DanielEcheverry
Linux user: #477840
Debian user
Software libre