Bug#809923: New package proposal: nordlicht
On 2016-01-28 09:20:37, Peter Spiess-Knafl wrote: > Hi Sebastian! > > I migrated the repository to pkg-multimedia and applied the required > changes to d/control. > > Once the upload is done, I will sign off the appropriate git-tag. Uploaded, thanks! Cheers -- Sebastian Ramacher signature.asc Description: PGP signature
Bug#809923: New package proposal: nordlicht
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi Sebastian! I migrated the repository to pkg-multimedia and applied the required changes to d/control. Once the upload is done, I will sign off the appropriate git-tag. Thank you for taking the time in sponsoring me. Greetings Peter -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQIcBAEBCgAGBQJWqc9VAAoJED/ImGelQYVW7zYQAKhav+tnLuO2Fc4qqrefCI0a Y2fthrdFEjGWv/rNNJkI0lE0V95e7bAoqzmax16oF/H12lYDtU2M1e6aFt516yM+ eoUSfWvTnZjdXuf4lTQEXPfPWo3bnHjw0aoAfPuX6RfXUWc7bR/x3P2aX86XYJ88 smMQOrEYKqbZ6ULnKBjU9IrWZvhHgg5B+lPmny1VhaWg3G7BG3UD52z98LNzlcTY Bz7uYi9y/U3XE0QJBCNVpT8NmBFTfElpm/SIYtK/2uThi7mYSMfwSTEweGnELG8+ ICkQ8AFmwb6aS/75YonkG1PeB8BLeC8zOEb220O5qVtHe7mbDDL7GPsxg0hzCDOW lBcd0pbwjnFTG1pcdCwpp6mTP8MXbwpK8jnk4ui3EMMKud21vG1fNXbrbXqYQcGd SfH0atRlrKEiGCVi1hSLFPEvUwOZsf2yPnOVeG72n00dMceWRnLHEAMbXy8vvpB7 SmMIcUhNYkfCezeR+Ef04ICboTyQOEirr0U/ZQISamDOKFnt39JCmOywEH1Daq8x 4FzXv3p1ocdH0rkJ0HlyXQ0NWUn6m3Evtrg/7iJE/Jm7jZh3YuKWhjlPTYO69CRX IdGCz1UU819bXt4gBJGfsdsEOn7jia8lyq8iFf9XddyXaY6Q2BVS5ftnfpWHcxSB cKd6c4NzhlitZssz2wwf =izHD -END PGP SIGNATURE-
Bug#809923: New package proposal: nordlicht
Hi Peter On 2016-01-26 08:31:18, Peter Spiess-Knafl wrote: > I modified the package including the following changes: > > * New upstream release 0.4.4 (Fixes over-/underlinking, library > versioning, export symbol visibility) > * Add multiarch-support > * Add autopkgtest > * Fixed the symbols file Looks good to me. Adding Testsuite: autopkgtest in debian/control is not necessary. dpkg will do that if detects debian/tests. > I pushed the changes to collab-maint [1]. > > I will send in an application to join debian-multimedia right now. If I > get accepted, I guess I also have to change the Maintainer-field in > d/control. Yes, usually we have the team as maintainer and you'd add yourself to Uploaders. I've created a git repository add git+ssh://git.debian.org/git/pkg-multimedia/nordlicht.git. Please push it there and change Vcs-* accordingly. Once that's done I think it's ready for an upload. Thanks for your work on nordlicht! Cheers -- Sebastian Ramacher signature.asc Description: PGP signature
Bug#809923: New package proposal: nordlicht
Hi Sebastian, I modified the package including the following changes: * New upstream release 0.4.4 (Fixes over-/underlinking, library versioning, export symbol visibility) * Add multiarch-support * Add autopkgtest * Fixed the symbols file I pushed the changes to collab-maint [1]. I will send in an application to join debian-multimedia right now. If I get accepted, I guess I also have to change the Maintainer-field in d/control. Thank you for your effort. Greetings Peter [1]: http://anonscm.debian.org/cgit/collab-maint/nordlicht.git/
Bug#809923: New package proposal: nordlicht
Hi Peter On 2016-01-22 21:04:33, Peter Spiess-Knafl wrote: > I will commit the missing changes about multi-arch support and a new > symbols file as soon as the new release is out. > > Could you please than give it another chance? Sure, let me know once those changes were made. Do you still want to maintain it within the Multimedia team? I haven't seen a join reqeust. Cheers -- Sebastian Ramacher signature.asc Description: PGP signature
Bug#809923: New package proposal: nordlicht
Hi Sebastian!
Thank you very much for your review. Those were really some major flaws.
On 01/19/2016 12:54 PM, Sebastian Ramacher wrote:
> A new upstream version is available.
I managed to get most of this fixed upstream. I am just waiting for
another release, so that we don't need to have unnecessary patches.
> Why is linbpng-dev in Build-Depends? It doesn't seem to be used.
Removed it. Its not required you are right.
> Is there a reason libnordlicht0 and libnordlicht-dev are not
> multi-archified?
I provided some patches to upstream and will multi-archify the package
as soon as the new release is out.
https://github.com/cinemast/nordlicht/commit/4440b64eff581da855140867f6e9a8b0a599eaf0
> The library exports plenty of symbols that are not listed in
> nordlicht.h. Please hide those symbols (for example using
> __attribute__(visibility("hidden"))) and ideally get this fixed
> upstream.
>
Fixed upstream:
https://github.com/nordlicht/nordlicht/commit/cc86cd362844700fced80ebcf443bb8f8a82c961
> nordlicht is overlinked:
>
> dpkg-shlibdeps: warning: package could avoid a useless dependency
> if debian/nordlicht/usr/bin/nordlicht was not linked against
> libavcodec-ffmpeg.so.56 (it uses none of the library's symbols)
> dpkg-shlibdeps: warning: package could avoid a useless dependency
> if debian/nordlicht/usr/bin/nordlicht was not linked against
> libavformat-ffmpeg.so.56 (it use s none of the library's symbols)
> dpkg-shlibdeps: warning: package could avoid a useless dependency
> if debian/nordlicht/usr/bin/nordlicht was not linked against
> libavutil-ffmpeg.so.54 (it uses none of the library's symbols)
> dpkg-shlibdeps: warning: package could avoid a useless dependency
> if debian/nordlicht/usr/bin/nordlicht was not linked against
> libswscale-ffmpeg.so.3 (it uses none of the library's symbols)
>
> libnordlicht.so.0 is underlinked. Please link it against libm:
>
> dpkg-shlibdeps: warning: symbol log10 used by
> debian/libnordlicht0/usr/lib/libnordlicht.so.0 found in none of the
> libraries
Fixed upstream:
https://github.com/nordlicht/nordlicht/commit/f69acc20599b8bf3edb8dd2986c1026b27af28a9
I will commit the missing changes about multi-arch support and a new
symbols file as soon as the new release is out.
Could you please than give it another chance?
Thank you and Greetings
Peter
Bug#809923: New package proposal: nordlicht
Hi Peter
On 2016-01-16 22:13:53, Sebastian Ramacher wrote:
> On 2016-01-14 02:52:58, Peter Spiess-Knafl wrote:
> > Dear pkg-multimedia-maintainers!
> >
> > I am currently packaging a software called nordlicht.
> >
> > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=809923
> >
> > Upstream is very collaborative on fixing things or applying patches.
> > Here is the ongoing discussion:
> >
> > https://github.com/nordlicht/nordlicht/issues/38
> >
> > I got hinted that it might be relevant to the pkg-multimedia team, so I
> > am proposing it here.
> >
> > The package is currently developed at collab-maint:
> > http://anonscm.debian.org/cgit/collab-maint/nordlicht.git/
Also, here is a first review:
A new upstream version is available.
Why is linbpng-dev in Build-Depends? It doesn't seem to be used.
Is there a reason libnordlicht0 and libnordlicht-dev are not multi-archified?
The library exports plenty of symbols that are not listed in nordlicht.h. Please
hide those symbols (for example using __attribute__(visibility("hidden"))) and
ideally get this fixed upstream.
nordlicht is overlinked:
dpkg-shlibdeps: warning: package could avoid a useless dependency if
debian/nordlicht/usr/bin/nordlicht was not linked against
libavcodec-ffmpeg.so.56 (it uses
none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if
debian/nordlicht/usr/bin/nordlicht was not linked against
libavformat-ffmpeg.so.56 (it use
s none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if
debian/nordlicht/usr/bin/nordlicht was not linked against
libavutil-ffmpeg.so.54 (it uses
none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if
debian/nordlicht/usr/bin/nordlicht was not linked against
libswscale-ffmpeg.so.3 (it uses
none of the library's symbols)
libnordlicht.so.0 is underlinked. Please link it against libm:
dpkg-shlibdeps: warning: symbol log10 used by
debian/libnordlicht0/usr/lib/libnordlicht.so.0 found in none of the libraries
Cheers
--
Sebastian Ramacher
signature.asc
Description: PGP signature
Bug#809923: New package proposal: nordlicht
Dear pkg-multimedia-maintainers! I am currently packaging a software called nordlicht. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=809923 Upstream is very collaborative on fixing things or applying patches. Here is the ongoing discussion: https://github.com/nordlicht/nordlicht/issues/38 I got hinted that it might be relevant to the pkg-multimedia team, so I am proposing it here. The package is currently developed at collab-maint: http://anonscm.debian.org/cgit/collab-maint/nordlicht.git/ I also uploaded the current version to mentors: http://mentors.debian.net/package/nordlicht It would be great if somebody could review it and maybe consider sponsoring it. I would like it very much to have it team-maintained. Greetings Peter
