Bug#811076: eog-plugins: Python related depends too tight: Causes problems during transitions

[Michael Biebl]

Hi Scott

On Fri, 15 Jan 2016 08:44:07 -0500 Scott Kitterman
 wrote:
> Package: eog-plugins
> Version: 3.16.3-1
> Severity: important
> Tags: patch
> 
> Currently, eog-plugins gets python3 interpreter depends like this (when
> built with python3.4 as default python3):
> 
> python3 (<< 3.5), python3 (>= 3.4~), python3.4
> 
> As a result, eog-plugins became uninstallable once the default was updated
> to python3.5.  While a binNMU corrected this, it's entirely unnecessary. I
> looked and there's no compiled python extensions in the plugins, it's all
> arch all python that does not need rebuilding when the version changes.
> 
> Ths problem is that because dh_python3 was being called for all plugins, some
> of which are compiled, dh_python treated them as python3 extensions for
> dependency calculation.
> 
> Please see the attached patch that addresses this issue.  With it the python3
> interpreter depend is:
> 
> python3:any (>= 3.3.2-2~)
> 
> No more trouble during transitions, the package is always installable.

That patch looks like it could easily get out-of-date once new py files
are added as it can be easily forgotten to update the list.
I'm therefore a bit worried to apply the patch as is.

Regards,
Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature

Bug#811076: eog-plugins: Python related depends too tight: Causes problems during transitions

[Scott Kitterman]

Package: eog-plugins
Version: 3.16.3-1
Severity: important
Tags: patch

Currently, eog-plugins gets python3 interpreter depends like this (when
built with python3.4 as default python3):

python3 (<< 3.5), python3 (>= 3.4~), python3.4

As a result, eog-plugins became uninstallable once the default was updated
to python3.5.  While a binNMU corrected this, it's entirely unnecessary. I
looked and there's no compiled python extensions in the plugins, it's all
arch all python that does not need rebuilding when the version changes.

Ths problem is that because dh_python3 was being called for all plugins, some
of which are compiled, dh_python treated them as python3 extensions for
dependency calculation.

Please see the attached patch that addresses this issue.  With it the python3
interpreter depend is:

python3:any (>= 3.3.2-2~)

No more trouble during transitions, the package is always installable.

Scott K
diff -Nru eog-plugins-3.16.3/debian/changelog eog-plugins-3.16.3/debian/changelog
--- eog-plugins-3.16.3/debian/changelog	2015-11-10 17:48:24.0 -0500
+++ eog-plugins-3.16.3/debian/changelog	2016-01-15 08:18:47.0 -0500
@@ -1,3 +1,11 @@
+eog-plugins (3.16.3-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Relax excessively tight python interpreter depends for eog-plugins
+- Only run dh_python3 for plugins with actual python content
+
+ -- Scott Kitterman   Fri, 15 Jan 2016 08:18:29 -0500
+
 eog-plugins (3.16.3-1) unstable; urgency=medium
 
   * New upstream release.
diff -Nru eog-plugins-3.16.3/debian/rules eog-plugins-3.16.3/debian/rules
--- eog-plugins-3.16.3/debian/rules	2015-05-25 22:54:36.0 -0400
+++ eog-plugins-3.16.3/debian/rules	2016-01-15 08:34:15.0 -0500
@@ -19,5 +19,10 @@
 			debian/control.in > debian/control
 
 binary-install/eog-plugins::
-	dh_python3 -p$(cdbs_curpkg) --no-ext-rename /usr/lib/eog/plugins
+	dh_python3 -p$(cdbs_curpkg) /usr/lib/eog/plugins/pythonconsole
+	dh_python3 -p$(cdbs_curpkg) /usr/lib/eog/plugins/slideshowshuffle
+	dh_python3 -p$(cdbs_curpkg) /usr/lib/eog/plugins/maximize-windows.py
+	dh_python3 -p$(cdbs_curpkg) /usr/lib/eog/plugins/export-to-folder.py
+	dh_python3 -p$(cdbs_curpkg) /usr/lib/eog/plugins/fullscreenbg.py
+	rm -rf $(CURDIR)/debian/$(cdbs_curpkg)/usr/lib/eog/plugins/__pycache__
 	find debian/$(cdbs_curpkg) -name '*.la' -print -delete