Bug#812229: adns FTCBFS: does not support DEB_BUILD_OPTIONS=nocheck

[Ian Jackson]

Manuel A. Fernandez Montecelo writes ("Bug#812229: adns FTCBFS: does not 
support DEB_BUILD_OPTIONS=nocheck"):
> Control: tags -1 + pending
...
> >I still welcome an NMU.  As for a maintainer upload, I don't want to
> >make promises I can't keep.
> 
> So I just uploaded to delayed/2, only with the single change, .debdiff
> attached.

Thank you for taking good care of this package.

Ian.

Bug#812229: adns FTCBFS: does not support DEB_BUILD_OPTIONS=nocheck

[Manuel A. Fernandez Montecelo]

Control: tags -1 + pending


Hi,

2017-10-13 12:34 Ian Jackson:

Manuel A. Fernandez Montecelo writes ("Bug#812229: adns FTCBFS: does not support 
DEB_BUILD_OPTIONS=nocheck"):

Do you think that you will work on it soon, or otherwise, do you still
welcome an NMU with it?

(I'd prefer maintainer uploads, when the maintainer is active)


I still welcome an NMU.  As for a maintainer upload, I don't want to
make promises I can't keep.


So I just uploaded to delayed/2, only with the single change, .debdiff
attached.

If you want me to reschedule or to cancel it, please tell me.

Thanks!

--
Manuel A. Fernandez Montecelo <manuel.montez...@gmail.com>

diff -u adns-1.5.0~rc1/debian/changelog adns-1.5.0~rc1/debian/changelog
--- adns-1.5.0~rc1/debian/changelog
+++ adns-1.5.0~rc1/debian/changelog
@@ -1,12 +1,3 @@
-adns (1.5.0~rc1-1.1) unstable; urgency=medium
-
-  * Non-maintainer upload.
-
-  [ Helmut Grohne ]
-  * Fix FTCBFS: Support DEB_BUILD_OPTIONS=nocheck. Closes: #812229.
-
- -- Manuel A. Fernandez Montecelo <m...@debian.org>  Tue, 31 Oct 2017 00:02:50 
+0100
-
 adns (1.5.0~rc1-1) unstable; urgency=medium
 
   * New upstream version.  Closes:#411263.
diff -u adns-1.5.0~rc1/debian/rules adns-1.5.0~rc1/debian/rules
--- adns-1.5.0~rc1/debian/rules
+++ adns-1.5.0~rc1/debian/rules
@@ -15,9 +15,7 @@
dh build --before configure
dh_auto_configure
dh_auto_build
-ifeq ($(filter nocheck,$(DEB_BUILD_OPTIONS)),)
make -C regress check
-endif
dh build --after test
touch $@
 

Bug#812229: adns FTCBFS: does not support DEB_BUILD_OPTIONS=nocheck

[Ian Jackson]

Manuel A. Fernandez Montecelo writes ("Bug#812229: adns FTCBFS: does not 
support DEB_BUILD_OPTIONS=nocheck"):
> Do you think that you will work on it soon, or otherwise, do you still
> welcome an NMU with it?
> 
> (I'd prefer maintainer uploads, when the maintainer is active)

I still welcome an NMU.  As for a maintainer upload, I don't want to
make promises I can't keep.

Ian.

Bug#812229: adns FTCBFS: does not support DEB_BUILD_OPTIONS=nocheck

[Manuel A. Fernandez Montecelo]

Hi,

2016-01-21 20:29 Ian Jackson:

Helmut Grohne writes ("Bug#812229: adns FTCBFS: does not support 
DEB_BUILD_OPTIONS=nocheck"):

Source: adns
Version: 1.5.0~rc1-1
Tags: patch
User: helm...@debian.org
Usertags: rebootstrap

...

ands fails to cross build from source, because the test suite does not
pass during cross compilation. It executes host architecture binaries
which cannot be run in a cross setting. The issue goes away when adns
supports DEB_BUILD_OPTIONS=nocheck. I've attached a patch for this.


Hi.  Thanks for the report.

I think this patch looks good.  I would have no objections to an NMU
which included it.

At some point I will pick this up in a maintainer upload, but that may
not be soon.


Do you think that you will work on it soon, or otherwise, do you still
welcome an NMU with it?

(I'd prefer maintainer uploads, when the maintainer is active)


Cheers.
--
Manuel A. Fernandez Montecelo <manuel.montez...@gmail.com>

Bug#812229: adns FTCBFS: does not support DEB_BUILD_OPTIONS=nocheck

[Ian Jackson]

Helmut Grohne writes ("Bug#812229: adns FTCBFS: does not support 
DEB_BUILD_OPTIONS=nocheck"):
> Source: adns
> Version: 1.5.0~rc1-1
> Tags: patch
> User: helm...@debian.org
> Usertags: rebootstrap
...
> ands fails to cross build from source, because the test suite does not
> pass during cross compilation. It executes host architecture binaries
> which cannot be run in a cross setting. The issue goes away when adns
> supports DEB_BUILD_OPTIONS=nocheck. I've attached a patch for this.

Hi.  Thanks for the report.

I think this patch looks good.  I would have no objections to an NMU
which included it.

At some point I will pick this up in a maintainer upload, but that may
not be soon.

Ian.

Bug#812229: adns FTCBFS: does not support DEB_BUILD_OPTIONS=nocheck

[Helmut Grohne]

Source: adns
Version: 1.5.0~rc1-1
Tags: patch
User: helm...@debian.org
Usertags: rebootstrap

Hi,

ands fails to cross build from source, because the test suite does not
pass during cross compilation. It executes host architecture binaries
which cannot be run in a cross setting. The issue goes away when adns
supports DEB_BUILD_OPTIONS=nocheck. I've attached a patch for this.

Helmut
diff -u adns-1.5.0~rc1/debian/changelog adns-1.5.0~rc1/debian/changelog
--- adns-1.5.0~rc1/debian/changelog
+++ adns-1.5.0~rc1/debian/changelog
@@ -1,3 +1,10 @@
+adns (1.5.0~rc1-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: Support DEB_BUILD_OPTIONS=nocheck. Closes: #-1.
+
+ -- Helmut Grohne   Thu, 21 Jan 2016 19:39:09 +0100
+
 adns (1.5.0~rc1-1) unstable; urgency=medium
 
   * New upstream version.  Closes:#411263.
diff -u adns-1.5.0~rc1/debian/rules adns-1.5.0~rc1/debian/rules
--- adns-1.5.0~rc1/debian/rules
+++ adns-1.5.0~rc1/debian/rules
@@ -15,7 +15,9 @@
dh build --before configure
dh_auto_configure
dh_auto_build
+ifeq ($(filter nocheck,$(DEB_BUILD_OPTIONS)),)
make -C regress check
+endif
dh build --after test
touch $@