Bug#812486: links2: .desktop file is not completely valid

[Pino Toscano]

tag 812486 - moreinfo + patch
thanks

Hi,

In data domenica 24 gennaio 2016 16:19:54, Axel Beckert ha scritto:
> Pino Toscano wrote:
> > In addition, a couple of helpful keywords are added to that.
> [...]
> >  Categories=Network;WebBrowser;
> [...]
> > +Keywords=lightweight;browser;web;
> 
> This though looks wrong to me. If I remember correctly, the
> description of "Keywords" says that you should not repeat general
> terms as those which are already used in other values.

Right -- it isn't wrong though, just redundant.

Attached a new git commit with just the validation fix -- of course,
feel free to add more keywords that fit.

Side note: considering a .desktop file is shipped, then the menu file
could be dropped (see #741573).

P.S.: what about forwarding it upstream?

Thanks,
-- 
Pino Toscano>From bd039d04234c2c1d5423efbab9ccbd0ea760c7bb Mon Sep 17 00:00:00 2001
From: Pino Toscano 
Date: Sat, 16 Apr 2016 14:38:00 +0200
Subject: [PATCH] Update links2.desktop (#812486)

The 'Keywords' key is a list, so it must end with the list separator
(';').
---
 debian/changelog  | 4 
 debian/links2.desktop | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/debian/changelog b/debian/changelog
index 7e53757..0799787 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -5,6 +5,10 @@ links2 (2.12-2) UNRELEASED; urgency=medium
   * Add new spelling-error-in-binary lintian override for "NAm" (not found
 in source, likely part of a symbol or such).
 
+  [ Pino Toscano ]
+  * Update links2.desktop: the 'Keywords' key is a list, so it must end
+with the list separator (';'). (Closes: #812486)
+
  -- Axel Beckert   Sat, 30 Jan 2016 17:02:40 +0100
 
 links2 (2.12-1) unstable; urgency=medium
diff --git a/debian/links2.desktop b/debian/links2.desktop
index f2541e2..69cd0e9 100644
--- a/debian/links2.desktop
+++ b/debian/links2.desktop
@@ -8,4 +8,4 @@ Terminal=false
 Categories=Network;WebBrowser;
 Comment=Web browser running in both graphics and text mode
 Comment[pt_BR]=Navegador web que funciona tanto no modo texto como no modo gráfico
-Keywords=lightweight
\ No newline at end of file
+Keywords=lightweight;
-- 
2.8.0.rc3

Bug#812486: links2: .desktop file is not completely valid

[Pino Toscano]

Package: links2
Version: 2.12-1
Severity: minor
Tags: patch

Hi,

the provided links2.desktop is not completely valid (see also output
of `desktop-file-validate`).
The attached git-formatted commit fixes all the issues:
- the 'Keywords' key is a list, so it must end with the list separator
  (';')

In addition, a couple of helpful keywords are added to that.

Thanks,
-- 
Pino
>From d141608fe25a323b132128abe0e3bc3951a3a492 Mon Sep 17 00:00:00 2001
From: Pino Toscano 
Date: Sun, 24 Jan 2016 12:26:41 +0100
Subject: [PATCH] update links2.desktop

- the 'Keywords' key is a list, so it must end with the list separator
  (';')
- add "browser" and "web" keywords
---
 debian/changelog  | 9 +
 debian/links2.desktop | 2 +-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/debian/changelog b/debian/changelog
index a7caa71..754d1e5 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,12 @@
+links2 (2.12-1.1) UNRELEASED; urgency=medium
+
+  * Update links2.desktop:
+- the 'Keywords' key is a list, so it must end with the list
+  separator (';')
+- add "browser" and "web" keywords
+
+ -- Pino Toscano   Sun, 24 Jan 2016 12:23:30 +0100
+
 links2 (2.12-1) unstable; urgency=medium
 
   * New upstream release.
diff --git a/debian/links2.desktop b/debian/links2.desktop
index f2541e2..5791548 100644
--- a/debian/links2.desktop
+++ b/debian/links2.desktop
@@ -8,4 +8,4 @@ Terminal=false
 Categories=Network;WebBrowser;
 Comment=Web browser running in both graphics and text mode
 Comment[pt_BR]=Navegador web que funciona tanto no modo texto como no modo gráfico
-Keywords=lightweight
\ No newline at end of file
+Keywords=lightweight;browser;web;
-- 
2.7.0.rc3

Bug#812486: links2: .desktop file is not completely valid

[Axel Beckert]

Control: tag -1 - patch + moreinfo

Hi Pino,

Pino Toscano wrote:
> the provided links2.desktop is not completely valid (see also output
> of `desktop-file-validate`).

Thanks for the hint to that tool. Didn't know it.

> The attached git-formatted commit fixes all the issues:
> - the 'Keywords' key is a list, so it must end with the list separator
>   (';')

Thanks. Wasn't aware of that issue.

> In addition, a couple of helpful keywords are added to that.
[...]
>  Categories=Network;WebBrowser;
[...]
> +Keywords=lightweight;browser;web;

This though looks wrong to me. If I remember correctly, the
description of "Keywords" says that you should not repeat general
terms as those which are already used in other values.

Rereading
https://lintian.debian.org/tags/desktop-entry-lacks-keywords-entry.html
and
https://anonscm.debian.org/cgit/collab-maint/links2.git/tree/debian/links2.desktop
I'd rather add "Lightweight Webbrowser" as GenericName and drop the
Keywords key again completely -- or use "Links 2 Webbrowser" as Name.

Anyhow, I don't think "web" and "browser" belong into the Keywords
list.

Regards, Axel
-- 
 ,''`.  |  Axel Beckert , http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE