Bug#815567: [Pkg-kde-extras] Bug#815567: Amarok should depend on virtual-mysql-server-core to support MariaDB
On Friday, 22 April 2016 17:09:40 CEST Andreas Beckmann wrote: > Control: reopen -1 > On Mon, 22 Feb 2016 18:06:27 +0200 =?UTF-8?B?T3R0byBLZWvDpGzDpGluZW4=?= > wrote: > > Amarok defines as build dependency: > > Build-Depends-Indep: mysql-server-core-5.6 | mysql-server-core > > This should be changed to: > > Build-Depends-Indep: mysql-server-core-5.6 | virtual-mysql-server-core > That has been implemented, but that's the wrong approach. > The buildds only consider the first alternative. This will break once > mysql-5.6 gets replaced by mysql-5.7 (or whatever else). > This will break in stretch in case mysql-5.6 leaves stretch. > And even if secondary alternatives would be considered by the buildds - > which provider of virtual-mysql-server-core should be installed? There > is probably more than one ... > So in this case you would really want a generic real package as first > alternative: > Build-Depends(-Indep): default-mysql-server-core | virtual-mysql-server-core > except that we currently don't have default-mysql-server-core ... Would you mind cloning this bug and reassigning it to the mysql maintainers, so we either get a default-mysql-server-core to build depend on or some other valid solution. Happy hacking, -- "Nothing ever goes away." -- Commoner's Law of Ecology Saludos /\/\ /\ >< `/ signature.asc Description: This is a digitally signed message part.
Bug#815567: Amarok should depend on virtual-mysql-server-core to support MariaDB
2016-04-24 19:30 GMT+03:00 SamuelOPH : > I've got the impression that you mean asking for the mysql team to package > mysql-server-core and mariadb-server-core wouldn't be a solution, is that > right? If so, why? If Andreas recommends it, I can bake a mariadb-server-core package that always depends on the newest version if we want to avoid having to change the version string in Amarok build depends once every few years.
Bug#815567: Amarok should depend on virtual-mysql-server-core to support MariaDB
2016-04-24 13:15 GMT-03:00 Andreas Beckmann : > My concerns are primarily about the Build-Depends(-Indep), because these > are going to break at some point for sure. > I'm sorry, could you explain why we can't depend on mysql-server instead of mysql-server-core-5.6 on the Build-Depenps(-Indep)? I believe i don't have as much experience packaging as you do, i just started recently. I've got the impression that you mean asking for the mysql team to package mysql-server-core and mariadb-server-core wouldn't be a solution, is that right? If so, why? Also, I just saw that the Debian Release Team decided that the default database option should be MariaDB[1], so instead of mysql-server, we put mariadb-server. [1]https://wiki.debian.org/Teams/MySQL/virtual-mysql-server Samuel Henrique O. P. [samueloph]
Bug#815567: Amarok should depend on virtual-mysql-server-core to support MariaDB
On 2016-04-24 18:08, SamuelOPH wrote: > I agree with your considerations, but i don't quite understand what's your > proposed solution,.did you talk to anyone from Debian MySQL Maintainers > about packaging mysql-server-core? I will send them this request if you > didn't. My concerns are primarily about the Build-Depends(-Indep), because these are going to break at some point for sure. > Also, amarok can use mysql-server instead. > The depedency tree > mysql-server -> mysql-server-5.6 -> mysql-server-core-5.6 > Will handle the missing.mysql-server-core package > > I believe this should be the fix if we cannot get mysql-server-core, making > amarok a litle bloated but again if we don't get mysql-server-core. The Depends in the binary packages are fine with using virtual-mysql-server-core as an alternative. Andreas
Bug#815567: Amarok should depend on virtual-mysql-server-core to support MariaDB
Hi Andreas, I agree with your considerations, but i don't quite understand what's your proposed solution,.did you talk to anyone from Debian MySQL Maintainers about packaging mysql-server-core? I will send them this request if you didn't. Also, amarok can use mysql-server instead. The depedency tree mysql-server -> mysql-server-5.6 -> mysql-server-core-5.6 Will handle the missing.mysql-server-core package I believe this should be the fix if we cannot get mysql-server-core, making amarok a litle bloated but again if we don't get mysql-server-core. Thanks. Samuel Henrique O. P. [samueloph]
Bug#815567: Amarok should depend on virtual-mysql-server-core to support MariaDB
Control: reopen -1 On Mon, 22 Feb 2016 18:06:27 +0200 =?UTF-8?B?T3R0byBLZWvDpGzDpGluZW4=?= wrote: > Amarok defines as build dependency: > > Build-Depends-Indep: mysql-server-core-5.6 | mysql-server-core > > This should be changed to: > > Build-Depends-Indep: mysql-server-core-5.6 | virtual-mysql-server-core That has been implemented, but that's the wrong approach. The buildds only consider the first alternative. This will break once mysql-5.6 gets replaced by mysql-5.7 (or whatever else). This will break in stretch in case mysql-5.6 leaves stretch. And even if secondary alternatives would be considered by the buildds - which provider of virtual-mysql-server-core should be installed? There is probably more than one ... So in this case you would really want a generic real package as first alternative: Build-Depends(-Indep): default-mysql-server-core | virtual-mysql-server-core except that we currently don't have default-mysql-server-core ... Andreas
Bug#815567:
Control: tags 815567 patch Control: tags 815567 pending Hi, I uploaded a NMU to 15-day/delay queue. Feel free to cancel this upload if needed. The debian/changelog is: amarok (2.8.0-4.1) unstable; urgency=medium * Non-maintainer upload. * debian/control: - Update to Debian Policy 3.9.7. - Build-Depends-Indep: Change build dependency from mysql-server-core to virtual-mysql-server-core to allow mariadb usage (closes: #815567). I attached a debdiff. Thanks. Samuel Henrique O. P. [samueloph] amarok.debdiff Description: Binary data
Bug#815567: Amarok should depend on virtual-mysql-server-core to support MariaDB
Package: amarok Severity: grave On line http://anonscm.debian.org/cgit/pkg-kde/kde-extras/amarok.git/tree/debian/control#n20 Amarok defines as build dependency: Build-Depends-Indep: mysql-server-core-5.6 | mysql-server-core This should be changed to: Build-Depends-Indep: mysql-server-core-5.6 | virtual-mysql-server-core Or if you prefer MariaDB: Build-Depends-Indep: mariadb-server-core-10.0 | virtual-mysql-server-core In https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=793977 Martin Steigerwald reports he used Akonadi with MariaDB. It is up to the package maintainer to choose what is the primary option, but the alternative should be the virtual-* package that is provided by all variants. In fact you MUST have this virtual-mysql-server-core to also support any future versions of the databases, e.g. mysql-server-core-5.7. More information at: https://wiki.debian.org/Teams/MySQL/virtual-mysql-server