Bug#816261: RFS: django-prometheus/1.0.6-1

[Mattia Rizzolo]

On Mon, Mar 21, 2016 at 10:17:43AM +, Mattia Rizzolo wrote:
> Uploading :)

while tagging the release I noticed that the format of the patched tag
was wrong.  I had already uploaded, so I did a commit fixing it *after*
the tag, please pull (and pull the tags)


-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  http://mapreri.org  : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#816261: RFS: django-prometheus/1.0.6-1

[Christopher Baines]

On 20/03/16 04:26, Mattia Rizzolo wrote:
>> http://mentors.debian.net/debian/pool/main/d/django-prometheus/django-prometheus_1.0.6-1.dsc
>> It is also available on git.debian.org:
>> https://anonscm.debian.org/cgit/python-modules/packages/django-prometheus.git/
> 
> DPMT package → ignoring mentors.d.n, just using the git repository
> 
> * debian/control:
>   + lack of VCS information, this is mandatory in the team.
> * debian/copyright:
>   + please name the license "Apache-2.0"
>   + why normal people don't put license and copyright on
> the header of the files?? :(
> * debian/rules:
>   + you should be able to do that thing with the tests with pybuild
> tooling, like by using (untested)
> PYBUILD_TEST_ARGS="{interpreter} ./test/end2end/manage.py test 
> --verbosity=2"
> note that you may also need to cp the tests or cd to {dir}.
> Please have a look at pybuild(1) and the wiki page
> https://wiki.debian.org/Python/Pybuild for more information
>   + what's that notice about automatically generated file?

Thanks for the review, I have now made some changes which should fix the
above issues.

> Then, on github the newest tag is 1.0.5, but you are packaging 1.0.6,
> which makes me think you are not using github by pypi (checking... not
> even, the tarballs are different).  Where did you get that tarball?

I got it from GitHub. I reminded the upstream maintainer to publish a
tag, and they have now done so.




signature.asc
Description: OpenPGP digital signature

Bug#816261: RFS: django-prometheus/1.0.6-1

[Mattia Rizzolo]

control: tag -1 moreinfo
control: owner -1 !

On Mon, Feb 29, 2016 at 08:32:06AM +, Christopher Baines wrote:
> I am looking for a sponsor for "django-prometheus"

ay!

> http://mentors.debian.net/debian/pool/main/d/django-prometheus/django-prometheus_1.0.6-1.dsc
> It is also available on git.debian.org:
> https://anonscm.debian.org/cgit/python-modules/packages/django-prometheus.git/

DPMT package → ignoring mentors.d.n, just using the git repository

* debian/control:
  + lack of VCS information, this is mandatory in the team.
* debian/copyright:
  + please name the license "Apache-2.0"
  + why normal people don't put license and copyright on
the header of the files?? :(
* debian/rules:
  + you should be able to do that thing with the tests with pybuild
tooling, like by using (untested)
PYBUILD_TEST_ARGS="{interpreter} ./test/end2end/manage.py test 
--verbosity=2"
note that you may also need to cp the tests or cd to {dir}.
Please have a look at pybuild(1) and the wiki page
https://wiki.debian.org/Python/Pybuild for more information
  + what's that notice about automatically generated file?

Then, on github the newest tag is 1.0.5, but you are packaging 1.0.6,
which makes me think you are not using github by pypi (checking... not
even, the tarballs are different).  Where did you get that tarball?

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  http://mapreri.org  : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#816261: RFS: django-prometheus/1.0.6-1

[Christopher Baines]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for "django-prometheus"

 * Package name: django-prometheus
   Version : 1.0.6-1
   Upstream Author : Uriel Corfa 
 * URL : https://github.com/korfuri/django-prometheus
 * License : Apache
   Section : python

It builds those binary packages:

  python-django-prometheus - Django middlewares to enable monitoring
with Prometheus (Python 2)
  python3-django-prometheus - Django middlewares to enable monitoring
with Prometheus (Python 3)

To access further information about this package, please visit the
following URL:

  http://mentors.debian.net/package/django-prometheus

Alternatively, one can download the package with dget using this command:

  dget -x
http://mentors.debian.net/debian/pool/main/d/django-prometheus/django-prometheus_1.0.6-1.dsc

It is also available on git.debian.org:


https://anonscm.debian.org/cgit/python-modules/packages/django-prometheus.git/

Thanks,

Chris



signature.asc
Description: OpenPGP digital signature