Bug#819360: src:pam: Add bison into Build-Depends list

[Roger Shimizu]

Control: severity -1 wishlist

On Tue, Mar 29, 2016 at 2:31 AM, Steve Langasek  wrote:
> On Mon, Mar 28, 2016 at 07:35:22PM +0900, Roger Shimizu wrote:
>> $ sudo apt build-dep pam
>> $ sudo apt install git-remote-bzr
>> $ git clone bzr::http://anonscm.debian.org/bzr/pkg-pam/debian/sid pam
>> -- may wait a few minutes --
>> $ cd pam
>> -- to start from a previous release point --
>> $ git checkout -b v1.1.8-3 c0f400
>> $ gbp buildpackage -uc -us --git-ignore-branch
>
>> Enclosed the build log from my armel box.
>
> Well, in comparison, here is the latest official build log on armel, which
> you'll see shows no use of bison.
>
>   
> https://buildd.debian.org/status/fetch.php?pkg=pam=armel=1.1.8-3.2=1452133353
>
> My guess is that because you're using git-remote-bzr + git-buildpackage,
> your build system is not picking up the orig.tar that's stored in the
> pristine-tar branch, and as a result you have a tree with files unpacked in
> the wrong order, leading make to conclude that the yacc output needs to be
> regenerated (because it's older than the input file).
>
> Grabbing the orig.tar from the archive and placing it in the right place in
> your filesystem should be sufficient to avoid this problem, I think?

I checked my build environment, and there's "pam_1.1.8.orig.tar.gz" in
parent directory, downloaded by command below:
$ wget http://httpredir.debian.org/debian/pool/main/p/pam/pam_1.1.8.orig.tar.gz

Sorry for not mentioning this in previous steps.

Anyway, the official repo is bzr and my gbp usage is just
"alternative", I agree to lower the priority.
Maybe some day you meet the issue can there's a reference here.

-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 17B3ACB1

Bug#819360: src:pam: Add bison into Build-Depends list

[Steve Langasek]

On Mon, Mar 28, 2016 at 07:35:22PM +0900, Roger Shimizu wrote:
> Control: tags -1 -unreproducible

> On Mon, Mar 28, 2016 at 1:55 PM, Steve Langasek  wrote:
> > On Sun, Mar 27, 2016 at 11:28:14PM +0900, Roger Shimizu wrote:

> > This package has never had a problem building with the current build-depends
> > set.  Please show a build log that explains why you think this
> > build-dependency is needed.

> Maybe the one of libraries pam's depending on removed the dependency?
> Just by my best guess, maybe not true.

> Anyway, here's how I build pam package:

> $ sudo apt build-dep pam
> $ sudo apt install git-remote-bzr
> $ git clone bzr::http://anonscm.debian.org/bzr/pkg-pam/debian/sid pam
> -- may wait a few minutes --
> $ cd pam
> -- to start from a previous release point --
> $ git checkout -b v1.1.8-3 c0f400
> $ gbp buildpackage -uc -us --git-ignore-branch

> Enclosed the build log from my armel box.

Well, in comparison, here is the latest official build log on armel, which
you'll see shows no use of bison.

  
https://buildd.debian.org/status/fetch.php?pkg=pam=armel=1.1.8-3.2=1452133353

My guess is that because you're using git-remote-bzr + git-buildpackage,
your build system is not picking up the orig.tar that's stored in the
pristine-tar branch, and as a result you have a tree with files unpacked in
the wrong order, leading make to conclude that the yacc output needs to be
regenerated (because it's older than the input file).

Grabbing the orig.tar from the archive and placing it in the right place in
your filesystem should be sufficient to avoid this problem, I think?

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developerhttp://www.debian.org/
slanga...@ubuntu.com vor...@debian.org


signature.asc
Description: Digital signature

Bug#819360: src:pam: Add bison into Build-Depends list

[Roger Shimizu]

Control: tags -1 -unreproducible

On Mon, Mar 28, 2016 at 1:55 PM, Steve Langasek  wrote:
> On Sun, Mar 27, 2016 at 11:28:14PM +0900, Roger Shimizu wrote:
>
> This package has never had a problem building with the current build-depends
> set.  Please show a build log that explains why you think this
> build-dependency is needed.

Maybe the one of libraries pam's depending on removed the dependency?
Just by my best guess, maybe not true.

Anyway, here's how I build pam package:

$ sudo apt build-dep pam
$ sudo apt install git-remote-bzr
$ git clone bzr::http://anonscm.debian.org/bzr/pkg-pam/debian/sid pam
-- may wait a few minutes --
$ cd pam
-- to start from a previous release point --
$ git checkout -b v1.1.8-3 c0f400
$ gbp buildpackage -uc -us --git-ignore-branch

Enclosed the build log from my armel box.

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 17B3ACB1


pam_branch_v1.1.8-3.log.xz
Description: application/xz

Bug#819360: src:pam: Add bison into Build-Depends list

[Steve Langasek]

Control: tags -1 moreinfo unreproducible


On Sun, Mar 27, 2016 at 11:28:14PM +0900, Roger Shimizu wrote:
> Package: src:pam
> Severity: normal
> Tags: patch
> X-Debbugs-Cc: rogershim...@gmail.com

> I find src pkg "pam" need yacc, which usually provides by bison, when
> build package.
> So I create the patch enclosed.

This package has never had a problem building with the current build-depends
set.  Please show a build log that explains why you think this
build-dependency is needed.

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developerhttp://www.debian.org/
slanga...@ubuntu.com vor...@debian.org


signature.asc
Description: Digital signature

Bug#819360: src:pam: Add bison into Build-Depends list

[Roger Shimizu]

Sorry, forgot the patch and here it is.
From e2000dbcec6e9a4cf6b29f9111095dfbc258bc24 Mon Sep 17 00:00:00 2001
From: Roger Shimizu 
Date: Sun, 27 Mar 2016 21:34:08 +0900
Subject: [PATCH 2/2] Add bison into Build-Depends list

---
 debian/changelog | 1 +
 debian/control   | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/debian/changelog b/debian/changelog
index 0c6d80b..709f9d4 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -14,6 +14,7 @@ pam (1.1.8-4) UNRELEASED; urgency=medium
 
   [ Roger Shimizu ]
   * Add udeb support for libpam0g
+  * Add bison into Build-Depends list
 
  -- Steve Langasek   Wed, 09 Apr 2014 14:04:10 -0700
 
diff --git a/debian/control b/debian/control
index b63805a..c2da229 100644
--- a/debian/control
+++ b/debian/control
@@ -4,7 +4,7 @@ Priority: optional
 Uploaders: Sam Hartman , Roger Leigh 
 Maintainer: Steve Langasek 
 Standards-Version: 3.9.1
-Build-Depends: libcrack2-dev (>= 2.8), bzip2, debhelper (>= 8.9.4), quilt (>= 0.48-1), flex, libdb-dev, libselinux1-dev [linux-any], po-debconf, dh-autoreconf, autopoint, libaudit-dev [linux-any], pkg-config
+Build-Depends: libcrack2-dev (>= 2.8), bzip2, debhelper (>= 8.9.4), quilt (>= 0.48-1), flex, bison, libdb-dev, libselinux1-dev [linux-any], po-debconf, dh-autoreconf, autopoint, libaudit-dev [linux-any], pkg-config
 Build-Depends-Indep: xsltproc, libxml2-utils, docbook-xml, docbook-xsl, w3m
 Build-Conflicts-Indep: fop
 Build-Conflicts: libdb4.2-dev, libxcrypt-dev
-- 
2.8.0.rc3

Bug#819360: src:pam: Add bison into Build-Depends list

[Roger Shimizu]

Package: src:pam
Severity: normal
Tags: patch
X-Debbugs-Cc: rogershim...@gmail.com

Dear Maintainer,

I find src pkg "pam" need yacc, which usually provides by bison, when
build package.
So I create the patch enclosed.

I hope you can merge my patch soon. Thank you!

BTW. This patch is following by another patch, reported as #819359

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 17B3ACB1