Bug#819615: RFS: spin/6.4.5-1 [ITP] -- formal software verification tool

[Tom Lee]

Cheers for the review Mattia! I'll look into all of this. A few comments:

On Sun, May 15, 2016 at 9:19 AM, Mattia Rizzolo  wrote:

> ...
> * d/patches/01_makefile_fixes.patch:
>   + Probably use += instead of ?= in the first CFLAGS?
>   + I'd rather use install(1) instead of cp(1)
>   + Really forward at least the DESTDIR/INSTALL change
>

Yes, thanks for reminding me -- do intend to follow up with upstream. I'm
curious if this makefile was perhaps written for some crusty old version of
make that doesn't do well with the "optional assignment" syntax used for
DESTDIR/INSTALL. I had similar questions about the use of cp vs. install.
I'll see if upstream has any strong attachment to any of this.


> * d/patches/02_manpage_fixes.patch:
>   + what's blocking you from forwarding this patch?
>

Nothing at all, it just hasn't been done yet.


> * d/rules:
>   + get rid of all those useless comments
>   + DPKG_EXPORT_BUILDFLAGS and the inclusion of buildflags.mk is
> useless, please read debhelper(7)
>   + trailing whitespace at line 22
>   + what's wrong with using --sourcedirectory on the dh(1) call instead
> of overriding everything like that?
>

Oh much better idea, didn't know I could do that.


>   + I'd avoid that "INSTALL=install -D" by patching correctly the
> makefile to default INSTALL on install(1) instead of cp(1) (as I
> said above)
>

Sure.

Thanks again!

Bug#819615: RFS: spin/6.4.5-1 [ITP] -- formal software verification tool

[Mattia Rizzolo]

control: tag -1 moreinfo
control: owner -1 !

On Wed, Mar 30, 2016 at 11:47:40PM -0700, Tom Lee wrote:
> I am looking for a sponsor for the "spin" package:

o/

>  dget -x http://mentors.debian.net/debian/pool/main/s/spin/spin_6.4.5-1.dsc

Actually, I'm going to use the git repository, as there is a nice
Vcs-Git field.

Based on what I found on that repo:

* d/control:
  + use https in Vcs-Git
  + Standards-Version is 3.9.8 nowadays, please check it out
  + as Paul said, please drop the -dbg package
* d/docs:
  + I'd like to have it renamed to d/spin.docs for consistency with the
other files
* d/outfile:
  + ???
* d/patches/01_makefile_fixes.patch:
  + Probably use += instead of ?= in the first CFLAGS?
  + I'd rather use install(1) instead of cp(1)
  + Really forward at least the DESTDIR/INSTALL change
* d/patches/02_manpage_fixes.patch:
  + what's blocking you from forwarding this patch?
* d/rules:
  + get rid of all those useless comments
  + DPKG_EXPORT_BUILDFLAGS and the inclusion of buildflags.mk is
useless, please read debhelper(7)
  + trailing whitespace at line 22
  + what's wrong with using --sourcedirectory on the dh(1) call instead
of overriding everything like that?
  + I'd avoid that "INSTALL=install -D" by patching correctly the
makefile to default INSTALL on install(1) instead of cp(1) (as I
said above)
* d/spin-docs.docs:
   + there is no package named like this, so what's the point of this
 file?
   + also, README.source is not supposed to be shipped in any binary
 package


All this said, I did not try building it, nor checking for
copyright/licensing stuff.

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#819615: RFS: spin/6.4.5-1 [ITP] -- formal software verification tool

[Paul Wise]

On Mon, Apr 25, 2016 at 11:20 AM, Tom Lee wrote:

> I added a spin-dbg binary package to the mix earlier today:

-dbg packages were obsoleted by automatic debug packages, just build
with a new enough debhelper and you will automatically get -dbgsym
packages for each binary package. I'd suggest dropping the -dbg
package.

https://wiki.debian.org/AutomaticDebugPackages

-- 
bye,
pabs

https://wiki.debian.org/PaulWise

Bug#819615: RFS: spin/6.4.5-1 [ITP] -- formal software verification tool

[Tom Lee]

Still looking for a sponsor for the spin verification tool. I added a
spin-dbg binary package to the mix earlier today:

http://mentors.debian.net/package/spin

Builds fine in pbuilder, is lint clean, etc. Appreciate reviews too!

-- 
*Tom Lee */ http://tomlee.co / @tglee 

Bug#819615: RFS: spin/6.4.5-1 [ITP] -- formal software verification tool

[Tom Lee]

Great, got it -- thanks Paul. Uploading to mentors again now.

On Wed, Mar 30, 2016 at 11:59 PM, Paul Wise  wrote:

> On Thu, Mar 31, 2016 at 2:47 PM, Tom Lee wrote:
>
> > N.B. no watchfile is present due to the naming strategy of the upstream
> tarball:
> > uscan interprets the version number as "645" when the release is
> actually "6.4.5".
> > if there's a way to teach uscan how to figure this out, I'm all ears!
>
> I think you want the uversionmangle option.
>
> --
> bye,
> pabs
>
> https://wiki.debian.org/PaulWise
>



-- 
*Tom Lee */ http://tomlee.co / @tglee 

Bug#819615: RFS: spin/6.4.5-1 [ITP] -- formal software verification tool

[Paul Wise]

On Thu, Mar 31, 2016 at 2:47 PM, Tom Lee wrote:

> N.B. no watchfile is present due to the naming strategy of the upstream 
> tarball:
> uscan interprets the version number as "645" when the release is actually 
> "6.4.5".
> if there's a way to teach uscan how to figure this out, I'm all ears!

I think you want the uversionmangle option.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise

Bug#819615: RFS: spin/6.4.5-1 [ITP] -- formal software verification tool

[Tom Lee]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for the "spin" package:

* Package name: spin
  Version : 6.4.5
  Upstream Author : Gerard J. Holzmann 
* URL : http://spinroot.com
* License : BSD-3-clause
  Section : devel

It builds those binary packages:

   spin - formal software verification tool

To access further information about this package, please visit the following 
URL:

https://mentors.debian.net/package/spin

N.B. no watchfile is present due to the naming strategy of the upstream tarball:
uscan interprets the version number as "645" when the release is actually 
"6.4.5".
if there's a way to teach uscan how to figure this out, I'm all ears!

One can also download the package with dget using this command:

 dget -x http://mentors.debian.net/debian/pool/main/s/spin/spin_6.4.5-1.dsc

More information about spin can be obtained from http://spinroot.com

Cheers,
Tom