Package: gitlab
Severity: normal
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Hello,
pages
/admin/runners
and
/admin/runners/$number
throws error 500
- ---
Started GET "/admin/runners" for 77.48.255.59 at 2016-04-03 00:23:37 +0200
Processing by Admin::RunnersController#index as HTML
Completed 500 Internal Server Error in 392ms (ActiveRecord: 11.5ms)
ActionView::Template::Error (Missing partial kaminari/_paginator with
{:locale=>[:en], :formats=>[:html], :variants=>[], :handlers=>[:erb, :builder,
:raw, :ruby, :coffee, :haml, :rabl]}. Searched in:
* "/usr/share/gitlab/app/views"
* "/usr/share/ruby-doorkeeper/app/views"
* "/usr/share/ruby-devise/app/views"
):
64:
65: - @runners.each do |runner|
66: = render "admin/runners/runner", runner: runner
67: = paginate @runners
app/views/admin/runners/index.html.haml:67:in
`_app_views_admin_runners_index_html_haml___401184490130856_81624960'
- ---
Fix is relatively simple, just add theme to paginator.
I checked upstream master and it's not there yet, probably some difference in
debian packaging, which affects this.
I was investigating it when i was installing gitlab 8.3.0 but forget to report
it.
Atteached patch to fix this pages
Libor
- -- System Information:
Debian Release: stretch/sid
APT prefers experimental
APT policy: (700, 'experimental'), (700, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.5.0-rc7-amd64 (SMP w/4 CPU cores)
Locale: LANG=cs_CZ.UTF-8, LC_CTYPE=cs_CZ.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
-BEGIN PGP SIGNATURE-
Version: GnuPG v1
iQIcBAEBCAAGBQJXAVpfAAoJEPDvjG7Cn0eOVosP/1WkWKtHLbJPAD3Bi2d/t7/S
ZYNCt+P8hJwXE6L4cQn7XSyA/GqU3SG6Ah37ZAx3MHp0/1L8JHdfLVYHEiJB+mJA
MWBkjFzswke8fZ5eLkKSncjN8QiuPD7oILyBmYQBGq/UdtdG2FqEhpHuhil50aKx
rfYOkMNuJWBZwRoQT0PjGKB1n0gtf+00sIsvL7bciYpnTl2/wg6/KityaK/oMp/E
BC5cJoawDVwVLB2T1ZZcRMdqT9YIBWgssURSKyss8qea8jRbK8XCo893QHmJAAcC
FuKvChSRLBRXzN/3uqtTSliVoEsbdmrEIdcJ3n0lAz/5pprTOPRSKRpFAOakzqoQ
GD2c57KGappI2YkTZB+/NUtuPa1M+fuM35t0uDeSTYEaiO0j2NFo8bHlgMFTb2zY
AA2hhQJ9KRcX03r4obe0oX4OQRNFzDyQyy/7fA5PBPGO4sRq017xu3FLVIgvFl81
MS4zuD0QWiZ5qw3SoodSZDtIn3/CHNQ3G70qVI7lOL+7F8A6qQAnkmMQfISY8iIN
jL/dZ6lqJRI6iQ0zKZhgmmIunIOKc2MWtLiRa9/0q2p5/z06LX+FX6x2X9+u6bjc
iN05FoU40Ykh9LZjyY6mvVtgbMXDXL2/LWqNupSGVsTNNSV4WUoNwEbp/9jNzR/a
WPhvbD0jqgFDCKHslsMs
=eLvK
-END PGP SIGNATURE-
diff -ur a/app/views/admin/runners/index.html.haml b/app/views/admin/runners/index.html.haml
--- a/app/views/admin/runners/index.html.haml 2016-02-02 19:00:07.0 +0100
+++ b/app/views/admin/runners/index.html.haml 2016-04-03 19:46:41.0 +0200
@@ -64,4 +64,4 @@
- @runners.each do |runner|
= render "admin/runners/runner", runner: runner
-= paginate @runners
+= paginate @runners, theme: "gitlab"
diff -ur a/app/views/admin/runners/show.html.haml b/app/views/admin/runners/show.html.haml
--- a/app/views/admin/runners/show.html.haml 2016-02-02 19:00:07.0 +0100
+++ b/app/views/admin/runners/show.html.haml 2016-04-03 19:47:59.0 +0200
@@ -85,7 +85,7 @@
= form_for [:admin, project.namespace.becomes(Namespace), project, project.runner_projects.new] do |f|
= f.hidden_field :runner_id, value: @runner.id
= f.submit 'Enable', class: 'btn btn-xs'
-= paginate @projects
+= paginate @projects, theme: "gitlab"
.col-md-6
%h4 Recent builds served by this runner
