Bug#820711: [debhelper-devel] Bug#820711: Bug#820711: Bug#820711: dh_compress: fails if the debian directory is a symlink
Bernhard Miklautz: > Hi, > > On Mon, Apr 11, 2016 at 06:19:11PM +, Niels Thykier wrote: >>> On Mon, Apr 11, 2016 at 04:12:30PM +, Niels Thykier wrote: >> I have devised a fix in [1418796], which I believe will fix this issue. >> I expect the next debhelper release to happen this weekend, so you may >> want to cherry-pick it. >> >> >> [1418796]: >> https://anonscm.debian.org/git/debhelper/debhelper.git/commit/?id=1418796f85ce27401673442e19977957d94079fe >> > Works like a charm again. I've re-tested all the described cases. Thank > you very much for your efforts and the quick fix ;). > > Best regards, > Bernhard > > [...] You are welcome :) Thanks for again for the detective work and the prompt testing! ~Niels signature.asc Description: OpenPGP digital signature
Bug#820711: [debhelper-devel] Bug#820711: Bug#820711: dh_compress: fails if the debian directory is a symlink
Hi, On Mon, Apr 11, 2016 at 06:19:11PM +, Niels Thykier wrote: > > On Mon, Apr 11, 2016 at 04:12:30PM +, Niels Thykier wrote: > I have devised a fix in [1418796], which I believe will fix this issue. > I expect the next debhelper release to happen this weekend, so you may > want to cherry-pick it. > > > [1418796]: > https://anonscm.debian.org/git/debhelper/debhelper.git/commit/?id=1418796f85ce27401673442e19977957d94079fe > Works like a charm again. I've re-tested all the described cases. Thank you very much for your efforts and the quick fix ;). Best regards, Bernhard
Bug#820711: [debhelper-devel] Bug#820711: Bug#820711: dh_compress: fails if the debian directory is a symlink
Bernhard Miklautz: > Hi, > > On Mon, Apr 11, 2016 at 04:12:30PM +, Niels Thykier wrote: >> [...] > For the package I'm building the folder structure looks like this: > > [...] > > All of the above combinations worked before 9.20160306. > When I narrowing it down the problem seems to be related to commit > https://anonscm.debian.org/git/debhelper/debhelper.git/commit/dh_compress?id=ef24f6405d14d1359d4b4e4c2028a28b47035d8b > > Thank you. > [...] Thanks for the investigative work. :) Given the version, ef24f64 was the most obvious suspect. :) I have devised a fix in [1418796], which I believe will fix this issue. I expect the next debhelper release to happen this weekend, so you may want to cherry-pick it. Thanks, ~Niels [1418796]: https://anonscm.debian.org/git/debhelper/debhelper.git/commit/?id=1418796f85ce27401673442e19977957d94079fe signature.asc Description: OpenPGP digital signature
Bug#820711: [debhelper-devel] Bug#820711: dh_compress: fails if the debian directory is a symlink
Hi, On Mon, Apr 11, 2016 at 04:12:30PM +, Niels Thykier wrote: > "debian" folder as in the "debian" folder itself? > debian/control -> ../../another/dir/control I didn't test this case. > debian -> ../../another/dir/ For the package I'm building the folder structure looks like this: -nightly - packaging - deb - nightly - control - rules - ... - debian -> packaging/deb/nightly The debian folder is a symlink to another folder within the same directory. I also tested the case when the link destination is outside the directory structure like: - packaging - deb - nightly - control - rules - ... -nightly - debian -> ../packaging/deb/nightly This basically ends up in the same error but with a different path prefix (../../../): chmod: cannot access '../../../packaging/deb/freerdp-nightly/freerdp-nightly/usr/share/doc/freerdp-nightly/changelog': No such file or directory However if the link is only "one level" like the following it works: -nightly - nightly - control - rules - ... - debian -> nightly All of the above combinations worked before 9.20160306. When I narrowing it down the problem seems to be related to commit https://anonscm.debian.org/git/debhelper/debhelper.git/commit/dh_compress?id=ef24f6405d14d1359d4b4e4c2028a28b47035d8b Thank you.
Bug#820711: [debhelper-devel] Bug#820711: dh_compress: fails if the debian directory is a symlink
Control: tags -1 moreinfo Bernhard Miklautz: > Package: debhelper > Version: 9.20160403 > Severity: important > > Dear Maintainer, > Hi, Thanks for reporting this issue. > if the debian folder is a symlink to a directory, a call to > dh_compress, directly or during a build, causes an error. > "debian" folder as in the "debian" folder itself? debian -> ../../another/dir/ debian/control -> ../../another/dir/control > For example if the package "nightly" has a debian folder > that is symlinked to packaging/deb/nightly/ the following error will be > raised during a debuild > > chmod: cannot access > '../../packaging/deb/nightly/nightly/usr/share/doc/nightly/changelog': No > such file or directory > dh_compress: chmod a-x > ../../packaging/deb/nightly/nightly/usr/share/doc/nightly/changelog returned > exit code 1 > > It seems that the paths aren't calculated properly. This happens since > dephelper version 9.20160306. > > [...] Thanks, ~Niels signature.asc Description: OpenPGP digital signature
Bug#820711: dh_compress: fails if the debian directory is a symlink
Package: debhelper Version: 9.20160403 Severity: important Dear Maintainer, if the debian folder is a symlink to a directory, a call to dh_compress, directly or during a build, causes an error. For example if the package "nightly" has a debian folder that is symlinked to packaging/deb/nightly/ the following error will be raised during a debuild chmod: cannot access '../../packaging/deb/nightly/nightly/usr/share/doc/nightly/changelog': No such file or directory dh_compress: chmod a-x ../../packaging/deb/nightly/nightly/usr/share/doc/nightly/changelog returned exit code 1 It seems that the paths aren't calculated properly. This happens since dephelper version 9.20160306. -- System Information: Debian Release: stretch/sid APT prefers testing APT policy: (500, 'testing') Architecture: amd64 (x86_64) Kernel: Linux 4.5.0 (SMP w/12 CPU cores) Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages debhelper depends on: ii autotools-dev20150820.1 ii binutils 2.26-8 ii dh-autoreconf12 ii dh-strip-nondeterminism 0.016-1 ii dpkg 1.18.4 ii dpkg-dev 1.18.4 ii file 1:5.25-2 ii libdpkg-perl 1.18.4 ii man-db 2.7.5-1 ii perl 5.22.1-9 ii po-debconf 1.0.19 debhelper recommends no packages. Versions of packages debhelper suggests: ii dh-make 2.201605 -- no debconf information
