Bug#821302: gap-core: convert.pl experiences error with SOURCE_DATE_EPOCH

[Jerome BENOIT]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Hello Again:

On Sun, 17 Apr 2016 18:00:50 +0100 Jerome BENOIT  wrote:
> Hello Bill:
> 
> On 17/04/16 14:37, Bill Allombert wrote:
>> On Sun, Apr 17, 2016 at 02:14:28PM +0100, Jerome Benoit wrote:
>>> Package: gap-core
>>> Version: 4r8p3-2
>>> Severity: normal
>>>
>>> Dear Maintainer,
>>>
>>> when SOURCE_DATE_EPOCH is set but GAP_CONVERT_DATE is not, convert.pl
>>> experiences errors: while building gap-grape 4r7+ds-1, I get the 
>>> message:
>>>
>>> Creating HTML documentation
>>> Name "main::SOURCE_DATE_EPOCH" used only once: possible typo at 
>>> /usr/share/gap/etc/convert.pl line 416.
>>> convert.pl: Please set GAP_CONVERT_DATE to the upstream 
>>> document date
>>> Use of uninitialized value $SOURCE_DATE_EPOCH in array 
>>> dereference at /usr/share/gap/etc/convert.pl line 416.
>>> date: invalid date '+%B %Y'
>>> convert.pl: Please set GAP_CONVERT_DATE to the upstream 
>>> document date
>>> Use of uninitialized value $SOURCE_DATE_EPOCH in array 
>>> dereference at /usr/share/gap/etc/convert.pl line 416.
>>> date: invalid date '+%B %Y'
>>>
>>> and the date does not appear in the documentation.
> 
>> Well, I applied the code you sent me... I assumed that worked for you.
> 
> The scrap code worked.
> 
>> It is not easy for me to test since gap itself do not use convert.pl.
> 
> Ok. I will focus on it, test against my stuff, and submit a patch via this 
> very channel.
> 
>> It seems there is an interpolation issue.
>> I assume @$SOURCE_DATE_EPOCH should be replaced by @\$SOURCE_DATE_EPOCH
>> or @$ENV{SOURCE_DATE_EPOCH}.
> 
>> Sorry about that...
> 
> 
> We are progressing, this is the point.
> 

Please find in attachment, a patch against the Perl script install by the Debian
package 4r8p3-2 that fixed the issue.


> Best wishes,
> Jerome

Jerome
> 
> 
> 

- -- 
Jerome BENOIT, Ph.D. | jgmbenoit-at+rezozer*dot_net
http://www.rezozer.net/
-BEGIN PGP SIGNATURE-
Version: GnuPG v2

iQEcBAEBCAAGBQJXE9RfAAoJEIC/w4IMSybjB3UH/0guSc6d1vJA9wL63FYvlLeE
/0P0DtbY7BDw1Uvy38w1ibcOIWbmeek4czxzCrbW/A1E9rkssd0x9EYpThVsjYIw
0anzHm+AQcZbo9pzRcKeBm+ZsEG6K6U8IQ5XYKxXmwpgoc1pH8AewOPlrHhf03OL
YYAbID/5ajeQX1AMicGlnlHvRaUeMTHARcTLR81nyjo4ddjwXNvMRQz5mraEI4EU
6shn1uYU4sZcElkfaZED/3C/wROExjjJT19iy6DZMRKmPx3Up3tq49V8ksv0BaJF
KMS4KiTO3bL4VH+7Ns7KqmzAEg2dwQ6upR51kzR564VceZXqaggUHPyT8D+Q118=
=Q/WY
-END PGP SIGNATURE-
--- convert.pl-dpkg-4r8p3-2	2016-04-17 00:52:18.0 +0100
+++ convert.pl	2016-04-17 19:00:36.546691435 +0100
@@ -413,7 +413,7 @@
 {
   return "$ENV{GAP_CONVERT_DATE}\n" if (defined($ENV{'GAP_CONVERT_DATE'}));
   print STDERR "convert.pl: Please set GAP_CONVERT_DATE to the upstream document date\n";
-  return `env LANG=C TZ=UTC date -d"@$SOURCE_DATE_EPOCH" +"%B %Y"` if (defined($ENV{'SOURCE_DATE_EPOCH'}));
+  return `env LANG=C TZ=UTC date -d "@"$ENV{'SOURCE_DATE_EPOCH'} +"%B %Y"` if (defined($ENV{'SOURCE_DATE_EPOCH'}));
   return `env LANG=C TZ=UTC date +"%B %Y"`
 }
 

Bug#821302: gap-core: convert.pl experiences error with SOURCE_DATE_EPOCH

[Jerome BENOIT]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Hello Bill:

On 17/04/16 14:37, Bill Allombert wrote:
> On Sun, Apr 17, 2016 at 02:14:28PM +0100, Jerome Benoit wrote:
>> Package: gap-core
>> Version: 4r8p3-2
>> Severity: normal
>>
>> Dear Maintainer,
>>
>>  when SOURCE_DATE_EPOCH is set but GAP_CONVERT_DATE is not, convert.pl
>>  experiences errors: while building gap-grape 4r7+ds-1, I get the 
>> message:
>>
>>  Creating HTML documentation
>>  Name "main::SOURCE_DATE_EPOCH" used only once: possible typo at 
>> /usr/share/gap/etc/convert.pl line 416.
>>  convert.pl: Please set GAP_CONVERT_DATE to the upstream 
>> document date
>>  Use of uninitialized value $SOURCE_DATE_EPOCH in array 
>> dereference at /usr/share/gap/etc/convert.pl line 416.
>>  date: invalid date '+%B %Y'
>>  convert.pl: Please set GAP_CONVERT_DATE to the upstream 
>> document date
>>  Use of uninitialized value $SOURCE_DATE_EPOCH in array 
>> dereference at /usr/share/gap/etc/convert.pl line 416.
>>  date: invalid date '+%B %Y'
>>
>>  and the date does not appear in the documentation.
> 
> Well, I applied the code you sent me... I assumed that worked for you.

The scrap code worked.

> It is not easy for me to test since gap itself do not use convert.pl.

Ok. I will focus on it, test against my stuff, and submit a patch via this very 
channel.

> It seems there is an interpolation issue.
> I assume @$SOURCE_DATE_EPOCH should be replaced by @\$SOURCE_DATE_EPOCH
> or @$ENV{SOURCE_DATE_EPOCH}.
> 
> Sorry about that...
> 

We are progressing, this is the point.

Best wishes,
Jerome



-BEGIN PGP SIGNATURE-
Version: GnuPG v2

iQEcBAEBCAAGBQJXE8FBAAoJEIC/w4IMSybjCZ0IANZ7m2aQN+tsg1GhThbzRWln
lb/nz9rnYjZGQUHjA2Yhh7BvDUmjSz/hYzB9QkT2CN8TijG+GlBw/mYA8vdesBS+
SMtq7cKMV8pLmyOXxBnLjJdfK8itviEFKWQx6D5e58VMzT5VHo3u6pCtyqm7vDCz
+eR6Rk7fBGgKHPoN5kvjxZJrpjxJR7OP9huSHoXjqMg+WQ9qzEgTDvuZwGqe0IrM
XDqJdxAWCiuqyJrGdNsNtRYlAbenzE5GXpkC+2F2wyNXVmPfxsQHWg7ofkSf4JLs
UPnHbF+LoOag0+Rh2DPMEXKLufXDDrmo84LWbF9PNAri27ryixMtU1IcHymZoqs=
=oEzv
-END PGP SIGNATURE-

Bug#821302: gap-core: convert.pl experiences error with SOURCE_DATE_EPOCH

[Bill Allombert]

On Sun, Apr 17, 2016 at 02:14:28PM +0100, Jerome Benoit wrote:
> Package: gap-core
> Version: 4r8p3-2
> Severity: normal
> 
> Dear Maintainer,
> 
>   when SOURCE_DATE_EPOCH is set but GAP_CONVERT_DATE is not, convert.pl
>   experiences errors: while building gap-grape 4r7+ds-1, I get the 
> message:
> 
>   Creating HTML documentation
>   Name "main::SOURCE_DATE_EPOCH" used only once: possible typo at 
> /usr/share/gap/etc/convert.pl line 416.
>   convert.pl: Please set GAP_CONVERT_DATE to the upstream 
> document date
>   Use of uninitialized value $SOURCE_DATE_EPOCH in array 
> dereference at /usr/share/gap/etc/convert.pl line 416.
>   date: invalid date '+%B %Y'
>   convert.pl: Please set GAP_CONVERT_DATE to the upstream 
> document date
>   Use of uninitialized value $SOURCE_DATE_EPOCH in array 
> dereference at /usr/share/gap/etc/convert.pl line 416.
>   date: invalid date '+%B %Y'
> 
>   and the date does not appear in the documentation.

Well, I applied the code you sent me... I assumed that worked for you.
It is not easy for me to test since gap itself do not use convert.pl.
It seems there is an interpolation issue.
I assume @$SOURCE_DATE_EPOCH should be replaced by @\$SOURCE_DATE_EPOCH
or @$ENV{SOURCE_DATE_EPOCH}.

Sorry about that...
-- 
Bill. 

Imagine a large red swirl here. 

Bug#821302: gap-core: convert.pl experiences error with SOURCE_DATE_EPOCH

[Jerome Benoit]

Package: gap-core
Version: 4r8p3-2
Severity: normal

Dear Maintainer,

when SOURCE_DATE_EPOCH is set but GAP_CONVERT_DATE is not, convert.pl
experiences errors: while building gap-grape 4r7+ds-1, I get the 
message:

Creating HTML documentation
Name "main::SOURCE_DATE_EPOCH" used only once: possible typo at 
/usr/share/gap/etc/convert.pl line 416.
convert.pl: Please set GAP_CONVERT_DATE to the upstream 
document date
Use of uninitialized value $SOURCE_DATE_EPOCH in array 
dereference at /usr/share/gap/etc/convert.pl line 416.
date: invalid date '+%B %Y'
convert.pl: Please set GAP_CONVERT_DATE to the upstream 
document date
Use of uninitialized value $SOURCE_DATE_EPOCH in array 
dereference at /usr/share/gap/etc/convert.pl line 416.
date: invalid date '+%B %Y'

and the date does not appear in the documentation.

Thanks, Jerome



-- System Information:
Debian Release: Jessie*
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'stable-updates')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.7-ckt20-0001-mbp62 (SMP w/4 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages gap-core depends on:
ii  gap-libs  4r8p3-2
ii  libc6 2.19-18+deb8u4
ii  libgmp10  2:6.1.0+dfsg-2
ii  libreadline6  6.3-8+b3

Versions of packages gap-core recommends:
ii  gap-online-help  4r8p3-2

Versions of packages gap-core suggests:
ii  gap-dev   4r8p3-2
ii  gap-doc   4r8p3-2
pn  gap-prim-groups   
pn  gap-small-groups  
ii  gap-trans-groups  4r7p3-1

-- no debconf information