Bug#821397: intent to sponsor an upload to NEW
control: tag -1 +pending Hello, On Thu 31 Jan 2019 at 01:03PM +01, Birger Schacht wrote: >> Could you `dch "Try upload again."; dch -r; git commit; git push`, >> please? Then I can try again with a -3 upload. > done! Success! Thank you for your patience. You should be able to see the result here: https://ftp-master.debian.org/deferred.html -- Sean Whitton signature.asc Description: PGP signature
Bug#821397: intent to sponsor an upload to NEW
Hi, On 1/31/19 4:22 AM, Sean Whitton wrote: > control: tag -1 -pending > > Hello Birger, > > On Wed 30 Jan 2019 at 04:44PM -07, Sean Whitton wrote: > >> Pushed to DELAYED/14! > > *sigh* > > I have been fighting with Debian's upload queue for the past few hours > because I discovered that the -2 upload was not processed. > > I was able to get it processed through to DEFERRED through some manual > hacking of the .changes file, but then when I cancelled the -1 upload, > the -2 upload was left in a state that would cause it to be REJECTed 14 > days from now (the .orig.tar.gz was removed). > > Could you `dch "Try upload again."; dch -r; git commit; git push`, > please? Then I can try again with a -3 upload. done! cheers, Birger > > I would do this myself but I don't have push access to the swaywm-team. >
Bug#821397: intent to sponsor an upload to NEW
control: tag -1 -pending Hello Birger, On Wed 30 Jan 2019 at 04:44PM -07, Sean Whitton wrote: > Pushed to DELAYED/14! *sigh* I have been fighting with Debian's upload queue for the past few hours because I discovered that the -2 upload was not processed. I was able to get it processed through to DEFERRED through some manual hacking of the .changes file, but then when I cancelled the -1 upload, the -2 upload was left in a state that would cause it to be REJECTed 14 days from now (the .orig.tar.gz was removed). Could you `dch "Try upload again."; dch -r; git commit; git push`, please? Then I can try again with a -3 upload. I would do this myself but I don't have push access to the swaywm-team. -- Sean Whitton signature.asc Description: PGP signature
Bug#821397: intent to sponsor an upload to NEW
control: tag -1 +pending Hello Birger, On Wed 30 Jan 2019 at 11:31PM +01, Birger Schacht wrote: > Argl, I'm sorry for having overlooked this Well, me too :) >> Could you make this change as a -2 upload, please? Since I have already >> pushed the -1, it is cleaner to do it that way. > Yes, fixed and pushed in 0a31ddda to salsa Pushed to DELAYED/14! -- Sean Whitton signature.asc Description: PGP signature
Bug#821397: intent to sponsor an upload to NEW
Hi, On 1/30/19 10:46 PM, Sean Whitton wrote: > control: tag -1 -pending > > Hello, > > On Wed 30 Jan 2019 at 02:42PM -07, Sean Whitton wrote: > >> Thank you. I've pushed it to DELAYED/14, after which it will land in >> the NEW queue. > > Er. After doing this, I immediately discovered this error in > d/copyright: > > License: LGPL-2.1-or-later > > should be > > License: LGPL-2.1+ Argl, I'm sorry for having overlooked this > Could you make this change as a -2 upload, please? Since I have already > pushed the -1, it is cleaner to do it that way. Yes, fixed and pushed in 0a31ddda to salsa Thanks and cheers, Birger > > Sorry, all, for the noise. >
Bug#821397: intent to sponsor an upload to NEW
control: tag -1 -pending Hello, On Wed 30 Jan 2019 at 02:42PM -07, Sean Whitton wrote: > Thank you. I've pushed it to DELAYED/14, after which it will land in > the NEW queue. Er. After doing this, I immediately discovered this error in d/copyright: License: LGPL-2.1-or-later should be License: LGPL-2.1+ Could you make this change as a -2 upload, please? Since I have already pushed the -1, it is cleaner to do it that way. Sorry, all, for the noise. -- Sean Whitton signature.asc Description: PGP signature
Bug#821397: intent to sponsor an upload to NEW
control: tag -1 +pending Hello Birger, On Wed 30 Jan 2019 at 09:13PM +01, Birger Schacht wrote: > done in 0d9ddb3b ;) Thank you. I've pushed it to DELAYED/14, after which it will land in the NEW queue. -- Sean Whitton signature.asc Description: PGP signature
Bug#821397: intent to sponsor an upload to NEW
Hello Birger, On Wed 30 Jan 2019 at 08:47PM +01, Birger Schacht wrote: > both fixed in ae7be33f. Thanks for your patience! You need dch -r again ... sorry for the bureaucracy. -- Sean Whitton signature.asc Description: PGP signature
Bug#821397: intent to sponsor an upload to NEW
Hi Sean, On 1/30/19 9:10 PM, Sean Whitton wrote: > Hello Birger, > > On Wed 30 Jan 2019 at 08:47PM +01, Birger Schacht wrote: > >> both fixed in ae7be33f. Thanks for your patience! > > You need dch -r again ... sorry for the bureaucracy. > done in 0d9ddb3b ;) cheers, Birger
Bug#821397: intent to sponsor an upload to NEW
Hello Sean, On 1/30/19 8:24 PM, Sean Whitton wrote: > Hello Birger, > > On Wed 30 Jan 2019 at 07:24AM -07, Sean Whitton wrote: > >> Thanks. I neglected to do a d/copyright check yesterday and have found >> some problems with d/copyright that need to be fixed before I can >> upload: >> >> - the Source: field is wrong >> >> - the protocols/ dir needs accounting for (look in the files there) > > You've pushed new commits, but unfortunately they are not adequate. > > The License: LGPL-2.1-or-later is not standard (use LGPL-2.1+) and > should refer to the full license text in /usr/share/common-licenses. > Please use codesearch.debian.net to find the standard way to do it. ah, sorry, i thought the LGPL-2.1+ was deprecated (i usually use the identifiers listed on spdx.org). But that also explains why i didn't find any occurrences on codesearch ;) > The copyright dates for the protocols/ files that are due to Drew > DeVault are not accounted for in d/copyright. They include files dated > 2018, but d/copyright does not reflect that. I suggest > > Copyright: © 2016-2018 Drew DeVault both fixed in ae7be33f. Thanks for your patience! cheers, Birger
Bug#821397: intent to sponsor an upload to NEW
Hello Birger, On Wed 30 Jan 2019 at 07:24AM -07, Sean Whitton wrote: > Thanks. I neglected to do a d/copyright check yesterday and have found > some problems with d/copyright that need to be fixed before I can > upload: > > - the Source: field is wrong > > - the protocols/ dir needs accounting for (look in the files there) You've pushed new commits, but unfortunately they are not adequate. The License: LGPL-2.1-or-later is not standard (use LGPL-2.1+) and should refer to the full license text in /usr/share/common-licenses. Please use codesearch.debian.net to find the standard way to do it. The copyright dates for the protocols/ files that are due to Drew DeVault are not accounted for in d/copyright. They include files dated 2018, but d/copyright does not reflect that. I suggest Copyright: © 2016-2018 Drew DeVault -- Sean Whitton signature.asc Description: PGP signature
Bug#821397: intent to sponsor an upload to NEW
Hello Birger, On Wed 30 Jan 2019 at 12:07PM +0100, Birger Schacht wrote: >> Firstly, I want to ensure that Nicolas is adequately credited for having >> done the majority of the packaging work (so far as I can tell); at the >> time of writing, where master is at 9303b617, I don't think this is >> true. >> >> Secondly, I want to ensure that the Maintainer and Uploaders fields >> adequately reflect Debian's social conventions about who gets final say >> over the contents of the package. Right now only Birger is listed. As >> has already been pointed out this could be interpreted as a kind of >> package hijack, which we don't want. > Sorry for the confusion, i'll try to be more considerate of existing > work next time! No problem. > Future uploads by me should then be NMUs, i guess? No, they would be normal maintainer uploads (confusing terminology, sorry). >> The last e-mail we have from Nicolas, saying that they are waiting for >> sponsorship, indicates that they still want to maintain this package in >> Debian. On the other hand, Birger has worked on the package recently, >> and I want to unblock him. So I think this is a suitable compromise. >> >> Birger, if this sounds good to you, please apply my diff, and then run >> `dch -r` again to refresh the timestamp in d/changelog. > done and pushed to 08230095 Thanks. I neglected to do a d/copyright check yesterday and have found some problems with d/copyright that need to be fixed before I can upload: - the Source: field is wrong - the protocols/ dir needs accounting for (look in the files there) -- Sean Whitton signature.asc Description: PGP signature
Bug#821397: intent to sponsor an upload to NEW
Hi, On 1/30/19 2:33 AM, Sean Whitton wrote: > Dear Birger, Nicolas, > > On Fri 11 Jan 2019 at 08:19AM +01, Birger Schacht wrote: > >> I've sent nicoo another mail about this and i'll let you know as soon as >> i hear back. > > Thank you to both of you for your recent work on the sway package. I > want to unblock inclusion of swaywm in Debian by sponsoring the upload. Thanks! > There are a few social issues to resolve. > > Firstly, I want to ensure that Nicolas is adequately credited for having > done the majority of the packaging work (so far as I can tell); at the > time of writing, where master is at 9303b617, I don't think this is > true. > > Secondly, I want to ensure that the Maintainer and Uploaders fields > adequately reflect Debian's social conventions about who gets final say > over the contents of the package. Right now only Birger is listed. As > has already been pointed out this could be interpreted as a kind of > package hijack, which we don't want. Sorry for the confusion, i'll try to be more considerate of existing work next time! > I have a few technical questions about the packaging, but they are not > sufficiently severe to block uploading to experimental, so I'm not > addressing them in this e-mail. > > This is what I propose we do: > > (1) use the [ square brackets ] convention to make it clear that the > initial packaging work was done mainly by Nicolas; > > (2) set the Maintainer field to Nicolas; and > > (3) set the Uploaders field to Birger, > > i.e. apply this diff: > > diff --git a/debian/changelog b/debian/changelog > index ac2d939f..e5e6ccd5 100644 > --- a/debian/changelog > +++ b/debian/changelog > @@ -1,5 +1,6 @@ > sway (1.0~beta.2-1) experimental; urgency=medium > > + [ Nicolas Braud-Santoni & Birger Schacht ] >* Initial packaging (Closes: 897246, 821397) > > -- Birger Schacht Sun, 02 Dec 2018 20:14:53 +0100 > diff --git a/debian/control b/debian/control > index 384a91ee..df3e0d0c 100644 > --- a/debian/control > +++ b/debian/control > @@ -1,7 +1,8 @@ > Source: sway > Section: x11 > Priority: optional > -Maintainer: Birger Schacht > +Maintainer: Nicolas Braud-Santoni > +Uploaders: Birger Schacht > Build-Depends: > debhelper-compat (= 12), > libwlroots-dev (>= 0.2), > > According to Debian's social conventions, this would mean that both > Birger and Nicolas are allowed to make uploads of the package, but > Nicolas has final say over the contents of the package, and would be > allowed to remove Birger from the Uploaders field. Future uploads by me should then be NMUs, i guess? > The last e-mail we have from Nicolas, saying that they are waiting for > sponsorship, indicates that they still want to maintain this package in > Debian. On the other hand, Birger has worked on the package recently, > and I want to unblock him. So I think this is a suitable compromise. > > Birger, if this sounds good to you, please apply my diff, and then run > `dch -r` again to refresh the timestamp in d/changelog. done and pushed to 08230095 cheers, Birger > > I will then upload the package to DELAYED/X where X=15-N, and N is the > number of days that have passed since the date of this e-mail. > > Nicolas, if you are not okay with having Birger in the Uploaders field, > you can NACK my sponsorship and do an upload yourself, now that you are > in the uploading keyring. >
Bug#821397: intent to sponsor an upload to NEW
Dear Birger, Nicolas, On Fri 11 Jan 2019 at 08:19AM +01, Birger Schacht wrote: > I've sent nicoo another mail about this and i'll let you know as soon as > i hear back. Thank you to both of you for your recent work on the sway package. I want to unblock inclusion of swaywm in Debian by sponsoring the upload. There are a few social issues to resolve. Firstly, I want to ensure that Nicolas is adequately credited for having done the majority of the packaging work (so far as I can tell); at the time of writing, where master is at 9303b617, I don't think this is true. Secondly, I want to ensure that the Maintainer and Uploaders fields adequately reflect Debian's social conventions about who gets final say over the contents of the package. Right now only Birger is listed. As has already been pointed out this could be interpreted as a kind of package hijack, which we don't want. I have a few technical questions about the packaging, but they are not sufficiently severe to block uploading to experimental, so I'm not addressing them in this e-mail. This is what I propose we do: (1) use the [ square brackets ] convention to make it clear that the initial packaging work was done mainly by Nicolas; (2) set the Maintainer field to Nicolas; and (3) set the Uploaders field to Birger, i.e. apply this diff: diff --git a/debian/changelog b/debian/changelog index ac2d939f..e5e6ccd5 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,5 +1,6 @@ sway (1.0~beta.2-1) experimental; urgency=medium + [ Nicolas Braud-Santoni & Birger Schacht ] * Initial packaging (Closes: 897246, 821397) -- Birger Schacht Sun, 02 Dec 2018 20:14:53 +0100 diff --git a/debian/control b/debian/control index 384a91ee..df3e0d0c 100644 --- a/debian/control +++ b/debian/control @@ -1,7 +1,8 @@ Source: sway Section: x11 Priority: optional -Maintainer: Birger Schacht +Maintainer: Nicolas Braud-Santoni +Uploaders: Birger Schacht Build-Depends: debhelper-compat (= 12), libwlroots-dev (>= 0.2), According to Debian's social conventions, this would mean that both Birger and Nicolas are allowed to make uploads of the package, but Nicolas has final say over the contents of the package, and would be allowed to remove Birger from the Uploaders field. The last e-mail we have from Nicolas, saying that they are waiting for sponsorship, indicates that they still want to maintain this package in Debian. On the other hand, Birger has worked on the package recently, and I want to unblock him. So I think this is a suitable compromise. Birger, if this sounds good to you, please apply my diff, and then run `dch -r` again to refresh the timestamp in d/changelog. I will then upload the package to DELAYED/X where X=15-N, and N is the number of days that have passed since the date of this e-mail. Nicolas, if you are not okay with having Birger in the Uploaders field, you can NACK my sponsorship and do an upload yourself, now that you are in the uploading keyring. -- Sean Whitton signature.asc Description: PGP signature
