Bug#821815: Pending fixes for bugs in the rkt package
On Tuesday, 19 April 2016 11:44:06 PM AEST Andreas Beckmann wrote: > On 2016-04-19 23:31, Dmitry Smirnov wrote: > > Why would it be wrong to remove cron job? Because of potential > > modifications, right? > > configuration files must be retained after removal, they are only > removed during purge > > conffiles (i.e. configuration files *shipped* by the package in /etc and > managed by dpkg) must not be touched by maintainer scripts (removal > would be noticed by dpkg and will be remembered - the file won't come > back on upgrade/reinstallation (unless the package is purged inbetween); > modification will cause dpkg to prompt about a "modified conffile" upon > upgrades) > > (see the respective policy sections for longer definitions of > 'configuration file' and 'conffile') I remember now... Thank you for feedback and explanation, Andreas. I've never had to install a cron job before... -- All the best, Dmitry Smirnov. signature.asc Description: This is a digitally signed message part.
Bug#821815: Pending fixes for bugs in the rkt package
tag 821815 + pending thanks Some bugs in the rkt package are closed in revision 4e127a8f3a00f6a990b750c2b4a47dc73abcff7a in branch 'master' by Dmitry Smirnov The full diff can be seen at https://anonscm.debian.org/cgit/pkg-go/packages/rkt.git/commit/?id=4e127a8 Commit message: cron: check if executable is available (Closes: #821815). Fixes previous commit. Thanks, Andreas Beckmann.
Bug#821815: Pending fixes for bugs in the rkt package
On 2016-04-19 23:31, Dmitry Smirnov wrote: > Why would it be wrong to remove cron job? Because of potential modifications, > right? configuration files must be retained after removal, they are only removed during purge conffiles (i.e. configuration files *shipped* by the package in /etc and managed by dpkg) must not be touched by maintainer scripts (removal would be noticed by dpkg and will be remembered - the file won't come back on upgrade/reinstallation (unless the package is purged inbetween); modification will cause dpkg to prompt about a "modified conffile" upon upgrades) (see the respective policy sections for longer definitions of 'configuration file' and 'conffile') Andreas
Bug#821815: Pending fixes for bugs in the rkt package
On Tuesday, 19 April 2016 11:04:16 PM AEST Andreas Beckmann wrote: > Instead check in the cronjob whether the binary exists and skip it > silently if it doesn't: > > test -x /usr/bin/rkt || exit 0 OK, thanks, I'll do that. It is safe and good idea in general. Why would it be wrong to remove cron job? Because of potential modifications, right? -- All the best, Dmitry Smirnov GPG key : 4096R/53968D1B --- The Santa myth is one of the most effective means ever devised for intimidating children, eroding their self-esteem, twisting their behavior, warping their values, and slowing their development of critical thinking skills. -- Tom Flynn, "The Trouble with Christmas" signature.asc Description: This is a digitally signed message part.
Bug#821815: Fwd: Re: Bug#821815: Pending fixes for bugs in the rkt package
The "Pending fixes ..." email had a Reply-to set to a mailing list that rejects non-subscriber posting. Andreas Forwarded Message Subject: Re: Bug#821815: Pending fixes for bugs in the rkt package Date: Tue, 19 Apr 2016 21:04:20 + From: pkg-go-maintainers-ow...@lists.alioth.debian.org To: a...@debian.org You are not allowed to post to this mailing list, and your message has been automatically rejected. If you think that your messages are being rejected in error, contact the mailing list owner at pkg-go-maintainers-ow...@lists.alioth.debian.org. --- Begin Message --- On 2016-04-19 22:51, pkg-go-maintain...@lists.alioth.debian.org wrote: > The full diff can be seen at > https://anonscm.debian.org/cgit/pkg-go/packages/rkt.git/commit/?id=00bc1fe That's the wrong approach. The cronjob is shipped as a conffile, do not touch it in the maintainer scripts, dpkg takes care of it. (install, remove (don't purge), install again - the cronjob would be missing with the postrm in git) Instead check in the cronjob whether the binary exists and skip it silently if it doesn't: test -x /usr/bin/rkt || exit 0 Andreas --- End Message ---
Bug#821815: Pending fixes for bugs in the rkt package
tag 821815 + pending thanks Some bugs in the rkt package are closed in revision 00bc1fefdfd0035b83437a2ca979761f9b0a96c7 in branch 'master' by Dmitry Smirnov The full diff can be seen at https://anonscm.debian.org/cgit/pkg-go/packages/rkt.git/commit/?id=00bc1fe Commit message: Do not leave cron job behind after package removal (Closes: #821815). Thanks, Andreas Beckmann.
