Bug#822613: RFS: dynamic-graph/3.0.0-1

[Rohan Budhiraja]

Hi Gianfranco


found information on
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=736360  which seems to
suggest the problem was still contentious two years ago. Should I keep
overriding this warning?

I suggest to leave things as is

Ok



1) apt install check-all-the-things

codespell --quiet-level=3
^^ something that you might want to fix or report/ask upstream


Done. Except for the source from Mathjax consortium, the rest is corrected.




2) grep copyright  . -Ri

many missing people


Added as the copyright.




License: I know the license text can be just a link to common-licenses, but I 
still prefer
some brief explanation

https://codesearch.debian.net/results/License%3A%20LGPL-3/page_0

"the License, or (at your option) any later version."

3) missing a +, it seems an LGPL-3+ license


I like something like this


License: LGPL-3+
This package is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 3 of the License, or (at your option) any later version.
.
This package is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
Lesser General Public License for more details.
.
You should have received a copy of the GNU General Public License
along with this program. If not, see.
.
On Debian systems, the complete text of the GNU Lesser General
Public License can be found in "/usr/share/common-licenses/LGPL-3".



Done.


5) trigger:
activate-noawait ldconfig


why?


lintian doesn't like ldconfig in maintenance scripts. So it gives out 
this error

https://lintian.debian.org/tags/maintscript-calls-ldconfig.html



6)

override_dh_makeshlibs:
dh_makeshlibs --exclude=lib/plugin --noscripts

override_dh_shlibdeps:
dh_shlibdeps --exclude=lib/plugin

why?
The plugin exclude was because the plugin libraries had no soversion. 
but that is now corrected.

The noscripts part was to avoid the lintian warning listed above


8)

please check dpkg-buildpackage -A
and dpkg-buildpackage -B
if they run cleanly
(in clean pbuilder/sbuild unstable environments)

They run cleanly in pdebuild


4) symbols mismatches:
http://debomatic-amd64.debian.net/distribution#unstable/dynamic-graph/3.0.0-1/buildlog

http://debomatic-i386.debian.net/distribution#unstable/dynamic-graph/3.0.0-1/buildlog

and I expect some more breakages on arm* and other Debian architectures.


dpkg-gensymbols now looks happy on my system (i386),  but I don't know 
what will happen on others. Is there any way for newbies like me to 
access these buildfarms?




it should be all for now

I am getting a new lintian error (+2 pedantic ones) about MathJax. This 
seems to be on the todo for lintian 
(https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=799861). Should I 
keep ignoring this as well?


Best regards,
Rohan

Bug#822613: RFS: dynamic-graph/3.0.0-1

[Gianfranco Costamagna]

control: tags -1 moreinfo
control: owner -1 !

Hi,
lets see

>found information on 
>https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=736360 which seems to 
>suggest the problem was still contentious two years ago. Should I keep 
>overriding this warning?

I suggest to leave things as is

1) apt install check-all-the-things

codespell --quiet-level=3


^^ something that you might want to fix or report/ask upstream


2) grep copyright  . -Ri

many missing people

License: I know the license text can be just a link to common-licenses, but I 
still prefer
some brief explanation

https://codesearch.debian.net/results/License%3A%20LGPL-3/page_0

"the License, or (at your option) any later version."

3) missing a +, it seems an LGPL-3+ license


I like something like this


License: LGPL-3+
This package is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 3 of the License, or (at your option) any later version.
.
This package is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
Lesser General Public License for more details.
.
You should have received a copy of the GNU General Public License
along with this program. If not, see .
.
On Debian systems, the complete text of the GNU Lesser General
Public License can be found in "/usr/share/common-licenses/LGPL-3".



4) symbols mismatches:
http://debomatic-amd64.debian.net/distribution#unstable/dynamic-graph/3.0.0-1/buildlog

http://debomatic-i386.debian.net/distribution#unstable/dynamic-graph/3.0.0-1/buildlog

and I expect some more breakages on arm* and other Debian architectures.

5) trigger:
activate-noawait ldconfig


why?


6)
>override_dh_makeshlibs:
>dh_makeshlibs --exclude=lib/plugin --noscripts
>
>override_dh_shlibdeps:
>dh_shlibdeps --exclude=lib/plugin


why?

7)

>override_dh_auto_configure:
>dh_auto_configure -- -DGENERATE_DOC=ON

this won't work, because arch=all is a builder, while arch:any are other 
machines.

So this probably breaks source only upload

8)

please check dpkg-buildpackage -A
and dpkg-buildpackage -B
if they run cleanly
(in clean pbuilder/sbuild unstable environments)

https://sources.debian.net/src/websocketpp/0.7.0-5/debian/rules/

this might give you some hints about the source only stuff

it should be all for now


Gianfranco

Bug#822613: RFS: dynamic-graph/3.0.0-1

[Rohan Budhiraja]

Hi Gianfranco

Thanks for the mail ( and sorry for not replying sooner).

--I have fixed the pedantic issues

-- I have not yet found a clear solution to the embedded jquery issue. I 
found information on 
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=736360 which seems to 
suggest the problem was still contentious two years ago. Should I keep 
overriding this warning?


Regards,
Rohan

On 05/10/2016 09:56 PM, Gianfranco Costamagna wrote:

control: owner -1 !

Hi, please fix the Pedantic lintian issues
https://mentors.debian.net/package/dynamic-graph
(e.g. no dep5 copyright, old compat level, typos, missing harderning flags)

and then I'll have a look at the package.




Il Lunedì 25 Aprile 2016 18:42, Rohan Budhiraja  ha 
scritto:
Package: sponsorship-requests
Severity: wishlist [important for RC bugs, wishlist for new packages]

Dear mentors,

I am looking for a sponsor for my package "dynamic-graph"

   * Package name: dynamic-graph
 Version : 3.0.0-1
 Upstream Author : Thomas Moulard
  François Bleibel
  François Keith
Nicolas Mansard
   Olivier Stasse

   * URL : https://github.com/proyan/dynamic-graph
   * License : LGPL-3
 Section : libs

It builds those binary packages:

  libdynamic-graph-dev - Dynamic graph C++ library development package
   libdynamic-graph-doc - documentation for the dynamic graph C++ library
   libdynamic-graph3.0.0 - Dynamic graph C++ library

To access further information about this package, please visit the 
following URL:

   http://stack-of-tasks.github.io/


Alternatively, one can download the package with dget using this command:

  dget -x 
http://mentors.debian.net/debian/pool/main/d/dynamic-graph/dynamic-graph_3.0.0-1.dsc

Regards,
 Rohan Budhiraja

Bug#822613: RFS: dynamic-graph/3.0.0-1

[Gianfranco Costamagna]

control: owner -1 !

Hi, please fix the Pedantic lintian issues
https://mentors.debian.net/package/dynamic-graph
(e.g. no dep5 copyright, old compat level, typos, missing harderning flags)

and then I'll have a look at the package.




Il Lunedì 25 Aprile 2016 18:42, Rohan Budhiraja  ha 
scritto:
Package: sponsorship-requests
   Severity: wishlist [important for RC bugs, wishlist for new packages]

   Dear mentors,

   I am looking for a sponsor for my package "dynamic-graph"

  * Package name: dynamic-graph
Version : 3.0.0-1
Upstream Author : Thomas Moulard
 François Bleibel
 François Keith
   Nicolas Mansard
  Olivier Stasse

  * URL : https://github.com/proyan/dynamic-graph
  * License : LGPL-3
Section : libs

   It builds those binary packages:

 libdynamic-graph-dev - Dynamic graph C++ library development package
  libdynamic-graph-doc - documentation for the dynamic graph C++ library
  libdynamic-graph3.0.0 - Dynamic graph C++ library

   To access further information about this package, please visit the following 
URL:

  http://stack-of-tasks.github.io/


   Alternatively, one can download the package with dget using this command:

 dget -x 
http://mentors.debian.net/debian/pool/main/d/dynamic-graph/dynamic-graph_3.0.0-1.dsc

   Regards,
Rohan Budhiraja

Bug#822613: RFS: dynamic-graph/3.0.0-1

[Andrey Rahmatullin]

On Tue, May 10, 2016 at 03:19:41PM +, Gianfranco Costamagna wrote:
> >Your package has several lintian-detected problems of various severiuty,
> >but the one about embedded jQuery is a blocker one. You will need to fix
> >it before having a chance for the package to be uploaded. Please look into
> >other issues as well.
> 
> 
> Not embedding it might result in a broken documentation
> https://lists.debian.org/debian-devel/2014/10/msg00795.html
> 
> So, I'm not sure if that tag is worth a fix...
Yeah, in that case I would investigate the case further.

> (BTW you commented on traitets, fed, dynamic-graph, but you didn't set 
> yourself
> as owner, do you plan to also sponsor the packages?)
No, I was doing some triaging.

-- 
WBR, wRAR


signature.asc
Description: PGP signature

Bug#822613: RFS: dynamic-graph/3.0.0-1

[Gianfranco Costamagna]

Hi Andrey!

>Your package has several lintian-detected problems of various severiuty,
>but the one about embedded jQuery is a blocker one. You will need to fix
>it before having a chance for the package to be uploaded. Please look into
>other issues as well.


Not embedding it might result in a broken documentation
https://lists.debian.org/debian-devel/2014/10/msg00795.html

So, I'm not sure if that tag is worth a fix...

(BTW you commented on traitets, fed, dynamic-graph, but you didn't set yourself
as owner, do you plan to also sponsor the packages?)

thanks a lot,

Gianfranco

Bug#822613: RFS: dynamic-graph/3.0.0-1

[Andrey Rahmatullin]

Control: tags -1 + moreinfo

Your package has several lintian-detected problems of various severiuty,
but the one about embedded jQuery is a blocker one. You will need to fix
it before having a chance for the package to be uploaded. Please look into
other issues as well.

-- 
WBR, wRAR


signature.asc
Description: PGP signature

Bug#822613: RFS: dynamic-graph/3.0.0-1

[Rohan Budhiraja]

Package: sponsorship-requests
  Severity: wishlist [important for RC bugs, wishlist for new packages]

  Dear mentors,

  I am looking for a sponsor for my package "dynamic-graph"

 * Package name: dynamic-graph
   Version : 3.0.0-1
   Upstream Author : Thomas Moulard
 François Bleibel
 François Keith
 Nicolas Mansard
 Olivier Stasse

 * URL : https://github.com/proyan/dynamic-graph
 * License : LGPL-3
   Section : libs

  It builds those binary packages:

libdynamic-graph-dev - Dynamic graph C++ library development package
 libdynamic-graph-doc - documentation for the dynamic graph C++ library
 libdynamic-graph3.0.0 - Dynamic graph C++ library

  To access further information about this package, please visit the following 
URL:

  http://stack-of-tasks.github.io/


  Alternatively, one can download the package with dget using this command:

dget -x 
http://mentors.debian.net/debian/pool/main/d/dynamic-graph/dynamic-graph_3.0.0-1.dsc

  Regards,
   Rohan Budhiraja