Bug#822792: marked as pending

[Elrond]

Hi,

I think, the main "include apps.d/*.conf" is missing?

Cheers

Elrond


On Thu, Nov 10, 2016 at 07:27:53 +, Michael Lustfield wrote:
> tag 822792 pending
> thanks
> 
> Hello,
> 
> Bug #822792 reported by you has been fixed in the Git repository. You can
> see the changelog below, and you can check the diff of the fix at:
> 
> http://git.debian.org/?p=collab-maint/nginx.git;a=commitdiff;h=c87b640

Bug#822792: marked as pending

[Elrond]

Hi,


On Fri, Nov 04, 2016 at 06:20:35 +, Michael Lustfield wrote:
> tag 822792 pending
> thanks
[...]

so this is basicaly a rename from the old name to "apps.d"?

That looks good!

1. After looking at conf/sites-available/default I noticed a
   commented block handling .php files in there.

   Would a config file in apps.d be allowed to do exactly
   that?  Like apps.d/pkg_php-fpm.conf handling *.php
   files?

2. Do we have recommended naming for files added by the
   local admin to apps.d?


Cheers

Elrond

Bug#822792: marked as pending

[Michael Lustfield]

awe... I bumped send a bit early. :(

>> Ordering could be relevant if packages want to handle more
>> specific URLs than others?
>> For example letsencrypt wants to handle
>> /.well-known/acme-challenge while maybe something else
>> wants to handle /.well-known?
>
> In this case, the existing static block is sufficient.

location / { try_files $uri $uri/ =404; } would cover the files that
get created in that directory.

Additionally, for letsencrypt, I would highly recommend acmetool. It's
saved me a lot of headache due to its simplicity and insistence that
it'll work no matter what.

Bug#822792: marked as pending

[Michael Lustfield]

On Wed, Oct 19, 2016 at 11:48 AM, Elrond
 wrote:
> Hi,
>
>
> On Wed, Oct 19, 2016 at 07:19:58 +, Michael Lustfield wrote:
> [...]
>> http://git.debian.org/?p=collab-maint/nginx.git;a=commitdiff;h=5d09382
> [...]
>
> That looks very cool!
>
> I have one question: The current naming convention
> pkg_*.conf doesn't look like it allows ordering. Is

My intention is to make it *VERY* clear that packages only get to play
within their own namespace.

This means that the "pkg_drupal7.conf" should have *EVERYTHING* in
that file wrapped inside of "location ^~ /drupal7 { ... }".

Doing anything else immediately brings us back to my original
apprehension against introducing this change in the first place. The
sites/default file is *NOT* a framework and should absolutely not be
treated like it.

> Ordering could be relevant if packages want to handle more
> specific URLs than others?
> For example letsencrypt wants to handle
> /.well-known/acme-challenge while maybe something else
> wants to handle /.well-known?

In this case, the existing static block is sufficient.

Bug#822792: marked as pending

[Elrond]

Hi,


On Wed, Oct 19, 2016 at 07:19:58 +, Michael Lustfield wrote:
[...]
> http://git.debian.org/?p=collab-maint/nginx.git;a=commitdiff;h=5d09382
[...]

That looks very cool!

I have one question: The current naming convention
pkg_*.conf doesn't look like it allows ordering. Is
ordering not relevant or needed with nginx?

Ordering could be relevant if packages want to handle more
specific URLs than others?
For example letsencrypt wants to handle
/.well-known/acme-challenge while maybe something else
wants to handle /.well-known?


Cheers

Elrond