Bug#823093: [Pkg-zsh-devel] Bug#823093: zsh-common: Zsh config files are stored in /etc/zsh instead of /etc/zsh.d, which is more expected by users

2016-04-30 Thread Axel Beckert 
Control: tag -1 - upstream + wontfix
Control: severity -1 wishlist
Control: close -1

Hi Christopher,

thanks for the effort, but…

Christopher Slojkowski wrote:
> Tags: upstream patch
[…]
> Zsh files are stored in /etc/zsh, they should be stored in
> /etc/zsh.d instead. This is more consitant with other directories.

this is wrong.

In contrary, naming it /etc/zsh.d/ would cause confusion because
people would except something different from that directory than it
is:

* .d directories contain always multiple files which are together
  treated as if they would have been a single file.
* But /etc/zsh/ contains files of different purposes, e.g. zlogin,
  zprofile, zshrc, zshenv.
* And there is already a .d file inside /etc/zsh/:
  /etc/zsh/completion.d/

Hence I'm tagging this as "wontfix", setting the severity to wishlist
(since this is not a bug) and closing it.

Besides: /etc/zsh/ has nothing to do with upstream. It is a setting
specific to the Debian package, see
https://sources.debian.net/src/zsh/5.0.7-5/debian/rules/#L25 -- hence
removing the upstream tag, too.

Regards, Axel
-- 
 ,''`.  |  Axel Beckert , http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

Bug#823093: zsh-common: Zsh config files are stored in /etc/zsh instead of /etc/zsh.d, which is more expected by users

2016-04-30 Thread Frank Terbeck 
Hi,

Christopher Slojkowski wrote:
> Zsh files are stored in /etc/zsh, they should be stored in /etc/zsh.d instead.
> This is more consitant with other directories. I included a patch which makes
> the new folder, moves, and creates a symlink. There is proabably a better
> solution, but I just created a quick hack.

I disagree. Usually, the use of .d directories signifies that all files
from such a directory are being loaded by an application. That is not at
all the case with /etc/zsh.

Also, this is longstanding behaviour with the debian package and, as
far as I am concerned, this is not going to change.


Regards, Frank

Bug#823093: zsh-common: Zsh config files are stored in /etc/zsh instead of /etc/zsh.d, which is more expected by users

2016-04-30 Thread Christopher Slojkowski 
Package: zsh-common
Version: 5.0.7-5
Severity: minor
Tags: upstream patch

Dear Maintainer,

Zsh files are stored in /etc/zsh, they should be stored in /etc/zsh.d instead. 
This is more consitant with other directories. I included a patch which makes 
the new folder, moves, and creates a symlink. There is proabably a better 
solution, but I just created a quick hack.

-- Package-specific info:

Packages which provide vendor completions:

Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ NameVersion  Architecture 
Description
+++-===---
ii  reprepro4.16.0-1 armhf
Debian package repository producer
ri  systemd 215-17+deb8u4armhf
system and service manager

dpkg-query: no path found matching pattern /usr/share/zsh/vendor-functions


-- System Information:
Distributor ID: Debian
Description:Debian GNU/Linux Rolling
Release:Jessie
Codename:   Jessie
Architecture: armv7l

Kernel: Linux 4.4.7-v7+ (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages zsh-common depends on:
ii  dpkg  1.17.26

Versions of packages zsh-common recommends:
ii  zsh  5.0.7-5

Versions of packages zsh-common suggests:
pn  zsh-doc  

-- no debconf information
diff -Naur zsh-common-orig/control/conffiles zsh-common/control/conffiles
--- zsh-common-orig/control/conffiles	2014-11-25 16:47:14.0 -0600
+++ zsh-common/control/conffiles	2016-04-30 10:13:07.525182894 -0500
@@ -1,6 +1,6 @@
-/etc/zsh/newuser.zshrc.recommended
-/etc/zsh/zlogin
-/etc/zsh/zlogout
-/etc/zsh/zprofile
-/etc/zsh/zshenv
-/etc/zsh/zshrc
+/etc/zsh.d/newuser.zshrc.recommended
+/etc/zsh.d/zlogin
+/etc/zsh.d/zlogout
+/etc/zsh.d/zprofile
+/etc/zsh.d/zshenv
+/etc/zsh.d/zshrc
diff -Naur zsh-common-orig/control/postinst zsh-common/control/postinst
--- zsh-common-orig/control/postinst	2014-11-25 16:47:14.0 -0600
+++ zsh-common/control/postinst	2016-04-30 10:23:11.932056969 -0500
@@ -13,6 +13,7 @@
 # Automatically added by dh_installdeb
 dpkg-maintscript-helper symlink_to_dir /usr/share/doc/zsh zsh-common 5.0.7-3 -- "$@"
 # End automatically added section
-
+mv /etc/zsh/* /etc/zsh.d/ 2>/dev/null
+ln -s /etc/zsh.d /etc/zsh
 
 exit 0
diff -Naur zsh-common-orig/data/etc/zsh/newuser.zshrc.recommended zsh-common/data/etc/zsh/newuser.zshrc.recommended
--- zsh-common-orig/data/etc/zsh/newuser.zshrc.recommended	2014-10-07 18:29:08.0 -0500
+++ zsh-common/data/etc/zsh/newuser.zshrc.recommended	1969-12-31 18:00:00.0 -0600
@@ -1,37 +0,0 @@
-# Set up the prompt
-
-autoload -Uz promptinit
-promptinit
-prompt adam1
-
-setopt histignorealldups sharehistory
-
-# Use emacs keybindings even if our EDITOR is set to vi
-bindkey -e
-
-# Keep 1000 lines of history within the shell and save it to ~/.zsh_history:
-HISTSIZE=1000
-SAVEHIST=1000
-HISTFILE=~/.zsh_history
-
-# Use modern completion system
-autoload -Uz compinit
-compinit
-
-zstyle ':completion:*' auto-description 'specify: %d'
-zstyle ':completion:*' completer _expand _complete _correct _approximate
-zstyle ':completion:*' format 'Completing %d'
-zstyle ':completion:*' group-name ''
-zstyle ':completion:*' menu select=2
-eval "$(dircolors -b)"
-zstyle ':completion:*:default' list-colors ${(s.:.)LS_COLORS}
-zstyle ':completion:*' list-colors ''
-zstyle ':completion:*' list-prompt %SAt %p: Hit TAB for more, or the character to insert%s
-zstyle ':completion:*' matcher-list '' 'm:{a-z}={A-Z}' 'm:{a-zA-Z}={A-Za-z}' 'r:|[._-]=* r:|=* l:|=*'
-zstyle ':completion:*' menu select=long
-zstyle ':completion:*' select-prompt %SScrolling active: current selection at %p%s
-zstyle ':completion:*' use-compctl false
-zstyle ':completion:*' verbose true
-
-zstyle ':completion:*:*:kill:*:processes' list-colors '=(#b) #([0-9]#)*=0=01;31'
-zstyle ':completion:*:kill:*' command 'ps -u $USER -o pid,%cpu,tty,cputime,cmd'
diff -Naur zsh-common-orig/data/etc/zsh/zlogin zsh-common/data/etc/zsh/zlogin
--- zsh-common-orig/data/etc/zsh/zlogin	2014-10-07 18:29:08.0 -0500
+++ zsh-common/data/etc/zsh/zlogin	1969-12-31 18:00:00.0 -0600
@@ -1,9 +0,0 @@
-# /etc/zsh/zlogin: system-wide .zlogin file for zsh(1).
-#
-# This file is sourced only for login shells. It
-# should contain commands that should be executed only
-# in login shells. It should be used to set the terminal
-# type and run a series of external commands (fortune,
-# msgs, from, etc.)
-#
-# Global Order: zshenv, zprofile, zshrc, zlogin
diff -Naur zsh-common-orig/data/etc/zsh/zlogout zsh-common/data/etc/zsh/zlogout
---