Bug#826379: Maintaining of CodeBlocks

[Tobias Frost]

> Hello Vincent,
>
> On Sat, 4 Jun 2016 22:29:22 -0700
> Vincent Cheng  wrote:
>
>
>> >> License: RDS-Data-Security
>> >>  License to copy and use this software is granted provided that
>> >>  it is identified as the "RSA Data Security, Inc. MD5 Message
>> >>  Digest Algorithm" in all material mentioning or referencing this
>> >>  software or this function.
>> >>  .
>> >>  License is also granted to make and use derivative works
>> >>  provided that such works are identified as "derived from the RSA
>> >>  Data Security, Inc. MD5 Message Digest Algorithm" in all
>> >>  material mentioning or referencing the derived work.
>> >
>> > 1. I believe this clause forces Debian to mention RSA Data Security
>> > on every html page and in every place where CodeBlock is mentioned.
>> > Isn't it?
>> >
>> > 2. Your main code is GPL v3 (note, 3d version, not 3+, because there
>> > are several files which don't allow "any later version"). But GPL is
>> > not compatible with such advertising clauses, see famous BSD-4 vs
>> > GPL example:
>> > http://www.gnu.org/licenses/license-list.html#OriginalBSD
>> >
>> > I cc debian-legal, these guys will correct me, if I'm wrong.
>>
>> Ah, you're right that the RSA license contains wording that is quite
>> similar to 4-clause BSD's advertising clause. I've filed #826379 to
>> keep track of this issue, and will report a bug upstream as well.
>>
>> I do want to point out that 4-clause BSD is actually DFSG-compatible
>> and suitable for Debian main [1], so there's still no reason to
>> believe that the RSA md5 license violates the DFSG as you originally
>> claim, even though it contains an advertising clause. Codeblocks is
>> non-distributable merely due to GPL's incompatibility with the RSA md5
>> license (not because it's non-free).


> 2. This license is much more restrictive then BSD one. It's not only
> require you to mention original author in your advertise. It says you
> must attribute CodeBlocks as "derived from the RSA Data Security, Inc.
> MD5 Message Digest Algorithm" in "_all_ material _mentioning_ or
> referencing the derived work". As for me this is inappropriate for Free
> Software. (e.g. I don't think it will pass The dissident test)
>
> But yes, it's somewhere on the edge between free and non-free, so other
> person could judge a little bit different and consider it as
> DFSG-compliant (but still GPL-incompatible).

As far as I understood it BSD-4-clause is only free because the Regents of the
UC dropped the advertising clause in
ftp://ftp.cs.berkeley.edu/pub/4bsd/README.Impt.License.Change. So IMHO the
current case is clearly non-free...

-- 
tobi

Bug#826379: Maintaining of CodeBlocks

[Alexander Gerasiov]

Hello Vincent,

On Sat, 4 Jun 2016 22:29:22 -0700
Vincent Cheng  wrote:


> >> License: RDS-Data-Security
> >>  License to copy and use this software is granted provided that
> >>  it is identified as the "RSA Data Security, Inc. MD5 Message
> >>  Digest Algorithm" in all material mentioning or referencing this
> >>  software or this function.
> >>  .
> >>  License is also granted to make and use derivative works
> >>  provided that such works are identified as "derived from the RSA
> >>  Data Security, Inc. MD5 Message Digest Algorithm" in all
> >>  material mentioning or referencing the derived work.
> >
> > 1. I believe this clause forces Debian to mention RSA Data Security
> > on every html page and in every place where CodeBlock is mentioned.
> > Isn't it?
> >
> > 2. Your main code is GPL v3 (note, 3d version, not 3+, because there
> > are several files which don't allow "any later version"). But GPL is
> > not compatible with such advertising clauses, see famous BSD-4 vs
> > GPL example:
> > http://www.gnu.org/licenses/license-list.html#OriginalBSD
> >
> > I cc debian-legal, these guys will correct me, if I'm wrong.
> 
> Ah, you're right that the RSA license contains wording that is quite
> similar to 4-clause BSD's advertising clause. I've filed #826379 to
> keep track of this issue, and will report a bug upstream as well.
> 
> I do want to point out that 4-clause BSD is actually DFSG-compatible
> and suitable for Debian main [1], so there's still no reason to
> believe that the RSA md5 license violates the DFSG as you originally
> claim, even though it contains an advertising clause. Codeblocks is
> non-distributable merely due to GPL's incompatibility with the RSA md5
> license (not because it's non-free).

1. Well it's clear that it's not GPL compatible, so you could not
redistribute it in binary form, so it's _technically_ violate DFSG.

2. This license is much more restrictive then BSD one. It's not only
require you to mention original author in your advertise. It says you
must attribute CodeBlocks as "derived from the RSA Data Security, Inc.
MD5 Message Digest Algorithm" in "_all_ material _mentioning_ or
referencing the derived work". As for me this is inappropriate for Free
Software. (e.g. I don't think it will pass The dissident test)

But yes, it's somewhere on the edge between free and non-free, so other
person could judge a little bit different and consider it as
DFSG-compliant (but still GPL-incompatible).

Anyway, there are some free md5 implementation, so it's not difficult
to fix this problem. Take a look at the patch attached. (I have not
really tested it, but it looks Ok.)


-- 
Best regards,
 Alexander Gerasiov

 Contacts:
 e-mail: g...@cs.msu.su  Homepage: http://gerasiov.net  Skype: gerasiov
 PGP fingerprint: 04B5 9D90 DF7C C2AB CD49  BAEA CA87 E9E8 2AAC 33F1
Author: Alexander Gerasiov 
	Alexander Peslyak 
Description: Replace MD5 implemention.
 Use one by Alexander Peslyak, better known as Solar Designer 
 insted of original by RSA Data Security, Inc. with GPL-incompatible license.
Bug-Debian: http://bugs.debian.org/826379
diff --git a/src/plugins/contrib/source_exporter/wxPdfDocument/Makefile.am b/src/plugins/contrib/source_exporter/wxPdfDocument/Makefile.am
index 6ca0ad4..de8bf9d 100644
--- a/src/plugins/contrib/source_exporter/wxPdfDocument/Makefile.am
+++ b/src/plugins/contrib/source_exporter/wxPdfDocument/Makefile.am
@@ -47,7 +47,8 @@ libwxPdfDocument_la_SOURCES = src/pdfannotation.cpp \
 src/pdfrijndael.cpp \
 src/pdftemplate.cpp \
 src/pdfutility.cpp \
-src/pdfxml.cpp
+src/pdfxml.cpp \
+src/md5.c
 
 noinst_HEADERS = include/wx/pdfannotation.h \
 include/wx/pdfarraydouble.h \
diff --git a/src/plugins/contrib/source_exporter/wxPdfDocument/src/md5.c b/src/plugins/contrib/source_exporter/wxPdfDocument/src/md5.c
new file mode 100644
index 000..52d96ac
--- /dev/null
+++ b/src/plugins/contrib/source_exporter/wxPdfDocument/src/md5.c
@@ -0,0 +1,296 @@
+/*
+ * This is an OpenSSL-compatible implementation of the RSA Data Security, Inc.
+ * MD5 Message-Digest Algorithm (RFC 1321).
+ *
+ * Homepage:
+ * http://openwall.info/wiki/people/solar/software/public-domain-source-code/md5
+ *
+ * Author:
+ * Alexander Peslyak, better known as Solar Designer 
+ *
+ * This software was written by Alexander Peslyak in 2001.  No copyright is
+ * claimed, and the software is hereby placed in the public domain.
+ * In case this attempt to disclaim copyright and place the software in the
+ * public domain is deemed null and void, then the software is
+ * Copyright (c) 2001 Alexander Peslyak and it is hereby released to the
+ * general public under the following terms:
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted.
+ *
+ * There's ABSOLUTELY NO WARRANTY, express or implied.
+ *
+ * (This is a heavily cut-down "BSD license".)
+ *
+ * This differs from Colin Plumb's older