Bug#827669: minetest-mod-mobf: packaging buggy/incomplete

2016-06-19 Thread James Cowgill
On Sun, 2016-06-19 at 15:09 +0200, Ronny Standtke wrote:
> The attached patch fixes the issue. The confusing part is that the
> patch shouldn't be necessary as the manpage of dh_install reads:
> --
> You rarely need to use this option, since dh_install automatically
> looks for files in debian/tmp in debhelper compatibility level 7 and
> above.
> --

Your patch is correct. dh_install does look in debian/tmp, but only if
it can't find the file in the package root directory. Clearly the '*'
in debian/install does match something in the package root, so by
debian/tmp will not be looked into at all.

James

signature.asc
Description: This is a digitally signed message part


Bug#827669: minetest-mod-mobf: packaging buggy/incomplete

2016-06-19 Thread Ronny Standtke
Package: minetest-mod-mobf
Version: 2.5.0-1
Severity: important
Tags: patch

The minetest-mod-mobf binary package contains lots of xcf and blend
files and even the directory
/usr/share/games/minetest/mods/mobf/debian/. This makes the package
unnecessary large and
even buggy because in minetest a mobf called "debian" is shown that of
course doesn't work
but produces the error message:
--
Failed to load and run script from
/usr/share/games/minetest/mods/mobf/debian/init.lua:
...
--


The attached patch fixes the issue. The confusing part is that the patch
shouldn't be
necessary as the manpage of dh_install reads:
--
You rarely need to use this option, since dh_install automatically looks
for files in
debian/tmp in debhelper compatibility level 7 and above.
--


Unfortunately, I still get the following error messages when starting
minetest with this mod enabled:
--
2016-06-19 14:51:25: ERROR[Main]: mod "animal_big_red" has unsatisfied
dependencies:  "animalmaterials" "mob_environments" "mobf"
2016-06-19 14:51:25: ERROR[Main]: mod "animal_chicken" has unsatisfied
dependencies:  "animalmaterials" "mob_environments" "mobf"
2016-06-19 14:51:25: ERROR[Main]: mod "animal_clownfish" has unsatisfied
dependencies:  "animalmaterials" "mob_environments" "mobf"
2016-06-19 14:51:25: ERROR[Main]: mod "animal_cow" has unsatisfied
dependencies:  "animalmaterials" "mob_environments" "mobf"
2016-06-19 14:51:25: ERROR[Main]: mod "animal_creeper" has unsatisfied
dependencies:  "mob_environments" "mobf"
2016-06-19 14:51:25: ERROR[Main]: mod "animal_deer" has unsatisfied
dependencies:  "animalmaterials" "mob_environments" "mobf"
2016-06-19 14:51:25: ERROR[Main]: mod "animal_dm" has unsatisfied
dependencies:  "mob_environments" "mobf"
2016-06-19 14:51:25: ERROR[Main]: mod "animal_fish_blue_white" has
unsatisfied dependencies:  "animalmaterials" "mob_environments" "mobf"
2016-06-19 14:51:25: ERROR[Main]: mod "animal_gull" has unsatisfied
dependencies:  "animalmaterials" "mob_environments" "mobf"
2016-06-19 14:51:25: ERROR[Main]: mod "animal_rat" has unsatisfied
dependencies:  "animalmaterials" "mob_environments" "mobf"
2016-06-19 14:51:25: ERROR[Main]: mod "animal_sheep" has unsatisfied
dependencies:  "animalmaterials" "mob_environments" "mobf"
2016-06-19 14:51:25: ERROR[Main]: mod "animal_vombie" has unsatisfied
dependencies:  "mob_environments" "mobf"
2016-06-19 14:51:25: ERROR[Main]: mod "animal_wolf" has unsatisfied
dependencies:  "animalmaterials" "mob_environments" "mobf"
2016-06-19 14:51:25: ERROR[Main]: mod "mob_archer" has unsatisfied
dependencies:  "animal_resources" "mob_environments" "mobf"
2016-06-19 14:51:25: ERROR[Main]: mod "mob_bear" has unsatisfied
dependencies:  "animalmaterials" "mob_environments" "mobf"
2016-06-19 14:51:25: ERROR[Main]: mod "mob_ghost" has unsatisfied
dependencies:  "mob_environments" "mobf"
2016-06-19 14:51:25: ERROR[Main]: mod "mob_guard" has unsatisfied
dependencies:  "animal_resources" "mob_environments" "mobf"
2016-06-19 14:51:25: ERROR[Main]: mod "mob_miner" has unsatisfied
dependencies:  "animal_resources" "mob_environments" "mobf" "mobf_settings"
2016-06-19 14:51:25: ERROR[Main]: mod "mob_npc" has unsatisfied
dependencies:  "mob_environments" "mobf"
2016-06-19 14:51:25: ERROR[Main]: mod "mob_oerkki" has unsatisfied
dependencies:  "animalmaterials" "mob_environments" "mobf"
2016-06-19 14:51:25: ERROR[Main]: mod "mob_ostrich" has unsatisfied
dependencies:  "animalmaterials" "mob_environments" "mobf"
2016-06-19 14:51:25: ERROR[Main]: mod "mob_shark" has unsatisfied
dependencies:  "animalmaterials" "mob_environments" "mobf"
2016-06-19 14:51:25: ERROR[Main]: mod "mob_slime" has unsatisfied
dependencies:  "animalmaterials" "mob_environments" "mobf"
2016-06-19 14:51:25: ERROR[Main]: mod "mob_warthog" has unsatisfied
dependencies:  "mob_environments" "mobf"
--

Are there some files in this package missing or is there debian package
in the works that provides this missing dependencies?

Cheers

Ronny

--- minetest-mod-mobf-2.5.0_orig/debian/rules	2016-06-12 13:02:20.0 +0200
+++ minetest-mod-mobf-2.5.0/debian/rules	2016-06-19 13:49:55.036955759 +0200
@@ -16,4 +16,4 @@
 	cp -r `ls |grep -v debian` debian/tmp
 	find debian/tmp -name '*.xcf' | xargs rm
 	find debian/tmp -name '*.blend' | xargs rm	
-	dh_install --fail-missing -X.gitignore
+	dh_install --fail-missing -X.gitignore --sourcedir=debian/tmp