Bug#832024: lftp crashes when I use automatic completion under FISH

[Vincent Bernat]

Control: forwarded -1 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=832024

<#secure method=pgpmime mode=sign>
 ❦ 21 juillet 2016 15:43 CEST, Lu Wang  :

> I use lftp with FISH protocol. I try to complete the file name by TAB.
> The program lftp crashes directly and a string 'Segmentation fault'
> shown on
> the prompt.
> If the completion cannot be used, it is too inconvenient.
>
> If I run lftp with normal FTP protocol, the program will not crash
> when I press
> TAB button.

I get the same problem:

#0  __strcpy_sse2_unaligned () at 
../sysdeps/x86_64/multiarch/strcpy-sse2-unaligned.S:296
#1  0x55648f66 in strcpy (__src=, __dest=0x7fffdee0 
"\f") at /usr/include/x86_64-linux-gnu/bits/string3.h:110
#2  Fish::SendMethod (this=this@entry=0x558ec260) at Fish.cc:397
#3  0x5564a870 in Fish::Do (this=0x558ec260) at Fish.cc:237
#4  0x555f1478 in SMTask::Roll (task=0x558ec260) at SMTask.cc:171
#5  0x5565575e in SMTask::Roll (this=) at SMTask.h:123
#6  GenericParseListInfo::Do (this=0x559121a0) at NetAccess.cc:591
#7  0x555f15a5 in SMTask::ScheduleThis (this=0x559121a0) at 
SMTask.cc:209
#8  0x555f17b1 in SMTask::Schedule () at SMTask.cc:248
#9  0x555ac22a in lftp_completion (text=, start=3, 
end=) at complete.cc:779
#10 0x77632107 in gen_completion_matches (text=0x558f3680 "/sr", 
start=, end=, our_func=0x77630500 
, found_quote=, 
quote_char=) at ./complete.c:1162
#11 0x776322e0 in rl_complete_internal (what_to_do=9) at 
./complete.c:1955
#12 0x77629597 in _rl_dispatch_subseq (key=9, map=, 
got_subseq=0) at ./readline.c:832
#13 0x77629981 in _rl_dispatch (key=, map=) at ./readline.c:775
#14 0x77629a22 in readline_internal_char () at ./readline.c:602
#15 0x7762a145 in readline_internal_charloop () at ./readline.c:629
#16 readline_internal () at ./readline.c:643
#17 readline (prompt=) at ./readline.c:369
#18 0x555ad286 in lftp_readline (prompt=) at lftp_rl.c:48
#19 0x555a9514 in ReadlineFeeder::NextCmd (this=0x558ea330, 
exec=0x558de8c0, prompt=0x558ec9a0 "lftp eizo.luffy.cx:~> ") at 
lftp.cc:157
#20 0x555b268f in CmdExec::Do (this=0x558de8c0) at CmdExec.cc:625
#21 0x555f15a5 in SMTask::ScheduleThis (this=0x558de8c0) at 
SMTask.cc:209
#22 0x555f17b1 in SMTask::Schedule () at SMTask.cc:248
#23 0x555af86d in Job::WaitDone (this=0x558de8c0) at Job.cc:549
#24 0x555a69cb in main (argc=, argv=0x7fffe648) at 
lftp.cc:589

In Fish::SendMethod, file is NULL. This has been fixed upstream:
 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=832024
-- 
Test input for validity and plausibility.
- The Elements of Programming Style (Kernighan & Plauger)

Bug#832024: lftp crashes when I use automatic completion under FISH

[Lu Wang]

Package: lftp
Version: 4.7.2-1
Severity: normal

Dear Maintainer,

I use lftp with FISH protocol. I try to complete the file name by TAB.
The program lftp crashes directly and a string 'Segmentation fault' shown on
the prompt.
If the completion cannot be used, it is too inconvenient.

If I run lftp with normal FTP protocol, the program will not crash when I press
TAB button.



-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.6.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=zh_CN.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages lftp depends on:
ii  libc6 2.23-1
ii  libgcc1   1:6.1.1-9
ii  libgnutls30   3.4.14-1
ii  libidn11  1.32-3.1
ii  libreadline6  6.3-8+b4
ii  libstdc++66.1.1-9
ii  libtinfo5 6.0+20160625-1
ii  netbase   5.3
ii  zlib1g1:1.2.8.dfsg-2+b1

Versions of packages lftp recommends:
ii  openssh-client [ssh-client]  1:7.2p2-5

lftp suggests no packages.

-- no debconf information