Bug#836525: debootstrap: doesn't support arch-qualified dependencies

[Cyril Brulebois]

Steve McIntyre  (2017-01-29):
> On Fri, Jan 20, 2017 at 07:45:13PM +0100, Sven Joachim wrote:
> >On 2016-12-19 13:59 +0100, Julien Cristau wrote:
> >>> 
> >> I think that needs to be reverted in dpkg, we really want to be
> >> able to create sid chroots with stable debootstrap.
> >
> >Good idea.  Can this bug be fixed in stretch, so that it remains
> >possible to create sid chroots with stable debootstrap in the next
> >two years?
> >
> >More and more packages gain a dependency on perl:any, see #852017
> >for the latest incarnation.
> 
> I'm looking through debootstrap bugs right now. I'm thinking this
> patch looks minimal and sane enough to take it for a pre-stretch
> upload.
> 
> Any objections?

Fine with me if you're still around to fix any possible issues after
it's been merged. ;-)


KiBi.


signature.asc
Description: Digital signature

Bug#836525: debootstrap: doesn't support arch-qualified dependencies

[Steve McIntyre]

Hey folks,

On Fri, Jan 20, 2017 at 07:45:13PM +0100, Sven Joachim wrote:
>On 2016-12-19 13:59 +0100, Julien Cristau wrote:
>>> 
>> I think that needs to be reverted in dpkg, we really want to be able to
>> create sid chroots with stable debootstrap.
>
>Good idea.  Can this bug be fixed in stretch, so that it remains
>possible to create sid chroots with stable debootstrap in the next two
>years?
>
>More and more packages gain a dependency on perl:any, see #852017 for
>the latest incarnation.

I'm looking through debootstrap bugs right now. I'm thinking this
patch looks minimal and sane enough to take it for a pre-stretch
upload.

Any objections?

-- 
Steve McIntyre, Cambridge, UK.st...@einval.com
Who needs computer imagery when you've got Brian Blessed?

Bug#836525: debootstrap: doesn't support arch-qualified dependencies

[Sven Joachim]

On 2016-12-19 13:59 +0100, Julien Cristau wrote:

> Control: severity -1 normal
>
> On 12/19/2016 10:58 AM, Sven Joachim wrote:
>> Control: severity -1 serious
>> 
>> On 2016-11-12 20:32 +0100, Sven Joachim wrote:
>> 
>>> On 2016-09-04 19:28 +0200, Sven Joachim wrote:
>>>
 Control: tags -1 + patch

 The attached patch should fix the problem with arch-qualifiers in
 debootstrap, tested with
 "debootstrap --variant=minbase --include=autoconf-dickey" which fails
 right now in unstable but succeeds with the patch (autoconf-dickey
 depends on perl:any).
>>>
>>> It should be noted that dpkg-dev in unstable now also depends on
>>> perl:any.  This does not cause problems yet, but only because
>>> libdpkg-perl depends on perl and debootstrap silently ignores any
>>> dependencies it cannot resolve, which is a bug in itself.
>>>
>>> This bug is a ticking time bomb, would be nice to apply my patch before
>>> it explodes.
>> 
>> The latest dpkg upload (1.18.17) changed the dependency of libdpkg-perl
>> to perl:any as well, and now "debootstrap --variant=buildd" fails
>> because it no longer downloads perl.
>> 
> I think that needs to be reverted in dpkg, we really want to be able to
> create sid chroots with stable debootstrap.

Good idea.  Can this bug be fixed in stretch, so that it remains
possible to create sid chroots with stable debootstrap in the next two
years?

More and more packages gain a dependency on perl:any, see #852017 for
the latest incarnation.

Cheers,
   Sven

Bug#836525: debootstrap: doesn't support arch-qualified dependencies

[Sven Joachim]

Control: clone -1 -2
Control: reassign -2 bootstrap-base

On 2016-12-19 12:53 +0100, Ansgar Burchardt wrote:

> Hi,
>
> there is a second implementation of pkgdetails in C (part of the base-
> installer source package).

Gnnn, yes.  There's a comment in the debootstrap source about this, but
it was so far above the lines which I worked on that it did not appear
on my screen. :-(

> I assume that would also need to be patched to ignore architecture
> qualifications?

Yes.  I think I have a patch, will send it as soon as I have the bug
number of the clone.

Cheers,
   Sven

Bug#836525: debootstrap: doesn't support arch-qualified dependencies

[Guillem Jover]

Hi!

On Mon, 2016-12-19 at 13:59:51 +0100, Julien Cristau wrote:
> Control: severity -1 normal
> 
> On 12/19/2016 10:58 AM, Sven Joachim wrote:
> > Control: severity -1 serious
> > 
> > On 2016-11-12 20:32 +0100, Sven Joachim wrote:
> >> On 2016-09-04 19:28 +0200, Sven Joachim wrote:
> >>> The attached patch should fix the problem with arch-qualifiers in
> >>> debootstrap, tested with
> >>> "debootstrap --variant=minbase --include=autoconf-dickey" which fails
> >>> right now in unstable but succeeds with the patch (autoconf-dickey
> >>> depends on perl:any).
> >>
> >> It should be noted that dpkg-dev in unstable now also depends on
> >> perl:any.  This does not cause problems yet, but only because
> >> libdpkg-perl depends on perl and debootstrap silently ignores any
> >> dependencies it cannot resolve, which is a bug in itself.
> >>
> >> This bug is a ticking time bomb, would be nice to apply my patch before
> >> it explodes.
> > 
> > The latest dpkg upload (1.18.17) changed the dependency of libdpkg-perl
> > to perl:any as well, and now "debootstrap --variant=buildd" fails
> > because it no longer downloads perl.

Oww, sorry, had forgotten about your previous thread where you
mentioned this. :/

> I think that needs to be reverted in dpkg, we really want to be able to
> create sid chroots with stable debootstrap.

Hmm, certainly right, I'll queue the revert for 1.18.18.

Also Ansgar mentioned on IRC that the other pkgdetails implementation
in base-installer also needed to be handled, perhaps by stripping the
arch-qualification centrally from debootstrap itself. And josch also
mentioned that perhaps it might be a good idea to consider switching
to use multistrap in Debian, as that's always going to be more feature
complete.

Thanks,
Guillem

Bug#836525: debootstrap: doesn't support arch-qualified dependencies

[Julien Cristau]

Control: severity -1 normal

On 12/19/2016 10:58 AM, Sven Joachim wrote:
> Control: severity -1 serious
> 
> On 2016-11-12 20:32 +0100, Sven Joachim wrote:
> 
>> On 2016-09-04 19:28 +0200, Sven Joachim wrote:
>>
>>> Control: tags -1 + patch
>>>
>>> The attached patch should fix the problem with arch-qualifiers in
>>> debootstrap, tested with
>>> "debootstrap --variant=minbase --include=autoconf-dickey" which fails
>>> right now in unstable but succeeds with the patch (autoconf-dickey
>>> depends on perl:any).
>>
>> It should be noted that dpkg-dev in unstable now also depends on
>> perl:any.  This does not cause problems yet, but only because
>> libdpkg-perl depends on perl and debootstrap silently ignores any
>> dependencies it cannot resolve, which is a bug in itself.
>>
>> This bug is a ticking time bomb, would be nice to apply my patch before
>> it explodes.
> 
> The latest dpkg upload (1.18.17) changed the dependency of libdpkg-perl
> to perl:any as well, and now "debootstrap --variant=buildd" fails
> because it no longer downloads perl.
> 
I think that needs to be reverted in dpkg, we really want to be able to
create sid chroots with stable debootstrap.

Cheers,
Julien

Bug#836525: debootstrap: doesn't support arch-qualified dependencies

[Ansgar Burchardt]

Hi,

there is a second implementation of pkgdetails in C (part of the base-
installer source package).  I assume that would also need to be patched
to ignore architecture qualifications?

Ansgar

Bug#836525: debootstrap: doesn't support arch-qualified dependencies

[Sven Joachim]

Control: severity -1 serious

On 2016-11-12 20:32 +0100, Sven Joachim wrote:

> On 2016-09-04 19:28 +0200, Sven Joachim wrote:
>
>> Control: tags -1 + patch
>>
>> The attached patch should fix the problem with arch-qualifiers in
>> debootstrap, tested with
>> "debootstrap --variant=minbase --include=autoconf-dickey" which fails
>> right now in unstable but succeeds with the patch (autoconf-dickey
>> depends on perl:any).
>
> It should be noted that dpkg-dev in unstable now also depends on
> perl:any.  This does not cause problems yet, but only because
> libdpkg-perl depends on perl and debootstrap silently ignores any
> dependencies it cannot resolve, which is a bug in itself.
>
> This bug is a ticking time bomb, would be nice to apply my patch before
> it explodes.

The latest dpkg upload (1.18.17) changed the dependency of libdpkg-perl
to perl:any as well, and now "debootstrap --variant=buildd" fails
because it no longer downloads perl.

This means that sbuild-createchroot and "pbuilder create" will also fail
to create sid chroots, since they run "debootstrap --variant=buildd".

Cheers,
   Sven

>> From 32a66dd450192ac959b1ec2e6a7030288e9e6f6e Mon Sep 17 00:00:00 2001
>> From: Sven Joachim 
>> Date: Sun, 4 Sep 2016 18:24:17 +0200
>> Subject: [PATCH] pkgdetails_perl: Strip the arch-qualifier (Closes: #836525)
>>
>> ---
>>  functions | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/functions b/functions
>> index 031721f..1254c41 100644
>> --- a/functions
>> +++ b/functions
>> @@ -1229,6 +1229,7 @@ while () {
>>  for $d (split /\s*,\s*/, $1) {
>>  $d =~ s/\s*[|].*$//;
>>  $d =~ s/\s*[(].*[)]\s*//;
>> +$d =~ s/:.*//;
>>  push @d, $d;
>>  }
>>  }

Bug#836525: debootstrap: doesn't support arch-qualified dependencies

[Sven Joachim]

On 2016-09-04 19:28 +0200, Sven Joachim wrote:

> Control: tags -1 + patch
>
> The attached patch should fix the problem with arch-qualifiers in
> debootstrap, tested with
> "debootstrap --variant=minbase --include=autoconf-dickey" which fails
> right now in unstable but succeeds with the patch (autoconf-dickey
> depends on perl:any).

It should be noted that dpkg-dev in unstable now also depends on
perl:any.  This does not cause problems yet, but only because
libdpkg-perl depends on perl and debootstrap silently ignores any
dependencies it cannot resolve, which is a bug in itself.

This bug is a ticking time bomb, would be nice to apply my patch before
it explodes.

Cheers,
   Sven

> From 32a66dd450192ac959b1ec2e6a7030288e9e6f6e Mon Sep 17 00:00:00 2001
> From: Sven Joachim 
> Date: Sun, 4 Sep 2016 18:24:17 +0200
> Subject: [PATCH] pkgdetails_perl: Strip the arch-qualifier (Closes: #836525)
>
> ---
>  functions | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/functions b/functions
> index 031721f..1254c41 100644
> --- a/functions
> +++ b/functions
> @@ -1229,6 +1229,7 @@ while () {
>   for $d (split /\s*,\s*/, $1) {
>   $d =~ s/\s*[|].*$//;
>   $d =~ s/\s*[(].*[)]\s*//;
> + $d =~ s/:.*//;
>   push @d, $d;
>   }
>   }

Bug#836525: debootstrap: doesn't support arch-qualified dependencies

[Sven Joachim]

Control: tags -1 + patch

The attached patch should fix the problem with arch-qualifiers in
debootstrap, tested with
"debootstrap --variant=minbase --include=autoconf-dickey" which fails
right now in unstable but succeeds with the patch (autoconf-dickey
depends on perl:any).

Cheers,
   Sven

>From 32a66dd450192ac959b1ec2e6a7030288e9e6f6e Mon Sep 17 00:00:00 2001
From: Sven Joachim 
Date: Sun, 4 Sep 2016 18:24:17 +0200
Subject: [PATCH] pkgdetails_perl: Strip the arch-qualifier (Closes: #836525)

---
 functions | 1 +
 1 file changed, 1 insertion(+)

diff --git a/functions b/functions
index 031721f..1254c41 100644
--- a/functions
+++ b/functions
@@ -1229,6 +1229,7 @@ while () {
 		for $d (split /\s*,\s*/, $1) {
 			$d =~ s/\s*[|].*$//;
 			$d =~ s/\s*[(].*[)]\s*//;
+			$d =~ s/:.*//;
 			push @d, $d;
 		}
 	}
-- 
2.9.3