Bug#837541: gambas3: FTBFS with bindnow and PIE enabled

2016-09-13 Thread Gianfranco Costamagna
Hi,

>Thanks, it fixed the build.



nice to see upstream already fixed it two months ago :)

https://sourceforge.net/p/gambas/code/7828/

thanks,

G.



Bug#837541: gambas3: FTBFS with bindnow and PIE enabled

2016-09-12 Thread Bálint Réczey
Hi Gianfranco,

2016-09-12 13:49 GMT+02:00 Gianfranco Costamagna
:
> control: tags -1 patch
>
> Hi Balint
>
>>During a rebuild of all packages in sid, your package failed to build on
>>amd64 with patched GCC and dpkg.
>
>
> looking at the error, I would say gambas is using an unexisting function
>
>
>>c_window.c:563:19: warning: implicit declaration of function 
>>'SDL_GetWindowId' [-Wimplicit-function-declaration]
>>GB.ReturnInteger(SDL_GetWindowId(WINDOW));
>>
>
>>/<>/debian/tmp/usr/bin/gbi3: symbol lookup error: 
>>/<>/debian/tmp/usr/lib/gambas3/gb.sdl2.so: undefined symbol: 
>>SDL_GetWindowId
>
> it might be because of a lower/uppercase issue, at least according to google 
> and libsdl2.
>
> Can you please try the following attached diff?
>
> -   GB.ReturnInteger(SDL_GetWindowId(WINDOW));
> +   GB.ReturnInteger(SDL_GetWindowID(WINDOW));


Thanks, it fixed the build.

Cheers,
Balint



Bug#837541: gambas3: FTBFS with bindnow and PIE enabled

2016-09-12 Thread Gianfranco Costamagna
control: tags -1 patch

Hi Balint

>During a rebuild of all packages in sid, your package failed to build on
>amd64 with patched GCC and dpkg.


looking at the error, I would say gambas is using an unexisting function


>c_window.c:563:19: warning: implicit declaration of function 'SDL_GetWindowId' 
>[-Wimplicit-function-declaration]
>GB.ReturnInteger(SDL_GetWindowId(WINDOW));
>

>/<>/debian/tmp/usr/bin/gbi3: symbol lookup error: 
>/<>/debian/tmp/usr/lib/gambas3/gb.sdl2.so: undefined symbol: 
>SDL_GetWindowId

it might be because of a lower/uppercase issue, at least according to google 
and libsdl2.

Can you please try the following attached diff?

-   GB.ReturnInteger(SDL_GetWindowId(WINDOW));
+   GB.ReturnInteger(SDL_GetWindowID(WINDOW));


thanks

G.


diff
Description: Binary data


Bug#837541: gambas3: FTBFS with bindnow and PIE enabled

2016-09-12 Thread Balint Reczey
Source: gambas3
Version: 3.8.4-6
Severity: important
User: bal...@balintreczey.hu
Usertags: pie-bindnow-20160906
Justification: FTBFS on amd64 with extra hardening

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64 with patched GCC and dpkg.

The rebuild tested if packages are ready for a transition
enabling PIE and bindnow for amd64.

For more information about the changes to sid's dpkg and GCC please
visit:
 https://wiki.debian.org/Hardening/PIEByDefaultTransition

Relevant part (hopefully):
...
Installing gb.dbus.trayicon...
/<>/debian/tmp/usr/bin/gbi3: symbol lookup error:
/<>/debian/tmp/usr/lib/gam
bas3/gb.sdl2.so: undefined symbol: SDL_GetWindowId
make[4]: Nothing to be done for 'install-data-am'.
make[4]: Leaving directory '/<>/comp'
make[3]: Leaving directory '/<>/comp'
Making install in app
make[3]: Entering directory '/<>/app'
make[4]: Entering directory '/<>/app'
[Installing with DESTDIR=/<>/debian/tmp]
Installing the development environment...
Compiling gambas3...
OK
Installing gambas3...
Compiling gbs3...
OK
Installing gbs3...
Installing the scripter...
Registering Gambas script mimetype
mkdir: cannot create directory '/sbuild-nonexistent': Permission denied
touch: cannot touch
'/sbuild-nonexistent/.local/share/icons/hicolor/.xdg-icon-resource-dummy':
No such
 file or directory
mkdir: cannot create directory '/sbuild-nonexistent': Permission denied
Registering Gambas server page mimetype
mkdir: cannot create directory '/sbuild-nonexistent': Permission denied
touch: cannot touch
'/sbuild-nonexistent/.local/share/icons/hicolor/.xdg-icon-resource-dummy':
No such file or directory
mkdir: cannot create directory '/sbuild-nonexistent': Permission denied
Installing the Gambas appdata file
Installing the Gambas template projects
/usr/bin/install -c -d
/<>/debian/tmp/usr/share/gambas3/template;
cp -R ./template/* /<>/debian/tmp/usr/share/gambas3/template;
make[4]: Nothing to be done for 'install-data-am'.
make[4]: Leaving directory '/<>/app'
make[3]: Leaving directory '/<>/app'
Making install in .
make[3]: Entering directory '/<>'
make[4]: Entering directory '/<>'
make[4]: Nothing to be done for 'install-data-am'.
make[4]: Leaving directory '/<>'
make[3]: Leaving directory '/<>'
make[2]: Leaving directory '/<>'
chmod 644 /<>/debian/tmp/usr/share/appdata/gambas3.appdata.xml
find /<>/debian/tmp/usr -name "*.la" -delete
find /<>/debian/tmp/usr -type d -empty -delete
find /<>/debian/tmp/usr -name *.png -perm /ugo+x -exec
chmod 644 \{} \;
make[1]: Leaving directory '/<>'
   debian/rules override_dh_install
make[1]: Entering directory '/<>'
dh_install -XCOPYING -XLicense --list-missing
dh_install: Cannot find (any matches for)
"usr/share/gambas3/info/gb.sdl2.info" (tried in "." and "debian/tmp")

...

The full build log is available from:
 
https://people.debian.org/~rbalint/build-logs/pie-bindnow-20160906/gambas3_3.8.4-6_amd64.build.gz

Thanks,
Balint