Bug#838055: 0ad: Embedded libsquish library now available in debian
On Mon, 24 Aug 2020 15:22:06 +0200 Fabio Pedretti wrote: Hi, I closed this issue years ago because actually 0ad doesn't use the squish library which is in the 0ad source. It's a problem strictly related to the nvidia-texture-tools package. Actually 0ad source could also be repackaged to remove squish and nvtt directory, which are not used. Since there is already bug #838056 for nvidia-texture-tools there is nothing to be done here and this one could actually be closed. But I'll leave that up to you. Related: https://github.com/castano/nvidia-texture-tools/pull/244 0ad alpha 24 now uses the embedded nvtt library because it needs nvtt 2.1 and Debian only has 2.0.8 in stable. So 0ad also uses the embedded squish library in https://salsa.debian.org/games-team/0ad/-/tree/master/libraries/source/nvtt/src/src/nvtt/squish Bye -- Dr. Ludovic Rousseau
Bug#838055: 0ad: Embedded libsquish library now available in debian
Hi, I closed this issue years ago because actually 0ad doesn't use the squish library which is in the 0ad source. It's a problem strictly related to the nvidia-texture-tools package. Actually 0ad source could also be repackaged to remove squish and nvtt directory, which are not used. Since there is already bug #838056 for nvidia-texture-tools there is nothing to be done here and this one could actually be closed. But I'll leave that up to you. Related: https://github.com/castano/nvidia-texture-tools/pull/244
Bug#838055: 0ad: Embedded libsquish library now available in debian
Le 18/11/2017 à 17:38, Markus Koschany a écrit : Am 18.11.2017 um 17:32 schrieb Ludovic Rousseau: Hello Markus, You re-opened this 0ad bug. According to what Vincent Cheng wrote: 0ad do NOT use the embedded libsquish library. How to you expect this bug to be fixed? Hello Vincent, I reopened the bug because it was closed without further comment by someone who is not a member of this team. To me it looked liked a random spam e-mail. I thought that Vincent Cheng wanted to keep this bug report open until #838056 is fixed but if you want to close it or triage it in some other way, please go ahead. OK. I will keep it open until #838056 "nvidia-texture-tools: Embedded libsquish library now available in debian" is fixed. Note for myself: nvidia-texture-tools package used by 0ad is "libnvtt-dev" in Build-Depends:. Thanks -- Dr. Ludovic Rousseau
Bug#838055: 0ad: Embedded libsquish library now available in debian
Hello Markus, You re-opened this 0ad bug. According to what Vincent Cheng wrote: 0ad do NOT use the embedded libsquish library. How to you expect this bug to be fixed? Thanks On Sat, 17 Sep 2016 01:51:15 -0700 Vincent Cheng wrote: Control: block -1 by 838056 Hi Wookey, On Fri, Sep 16, 2016 at 5:46 PM, Wookey wrote: >- nvidia-texture-tools 1.7 (src/nvtt/squish) >- 0ad 1.7 (libraries/source/nvtt/src/src/nvtt/squish/) 0ad actually embeds a copy of nvidia-texture-tools, which in turn embeds a copy of libsquish. Since we build 0ad with Debian's nvidia-texture-tools packages and not with the embedded copy, there's nothing that needs to be done in 0ad; once nvidia-texture-tools switches over to using libsquish as packaged in Debian, 0ad will also be using the system version as well. Thanks for the bug report anyhow! Regards, Vincent -- Dr. Ludovic Rousseau
Bug#838055: 0ad: Embedded libsquish library now available in debian
Am 18.11.2017 um 17:32 schrieb Ludovic Rousseau: > Hello Markus, > > You re-opened this 0ad bug. > According to what Vincent Cheng wrote: 0ad do NOT use the embedded > libsquish library. > > How to you expect this bug to be fixed? > Hello Vincent, I reopened the bug because it was closed without further comment by someone who is not a member of this team. To me it looked liked a random spam e-mail. I thought that Vincent Cheng wanted to keep this bug report open until #838056 is fixed but if you want to close it or triage it in some other way, please go ahead. Regards, Markus signature.asc Description: OpenPGP digital signature
Bug#838055: 0ad: Embedded libsquish library now available in debian
Control: block -1 by 838056 Hi Wookey, On Fri, Sep 16, 2016 at 5:46 PM, Wookey wrote: >- nvidia-texture-tools 1.7 (src/nvtt/squish) >- 0ad 1.7 (libraries/source/nvtt/src/src/nvtt/squish/) 0ad actually embeds a copy of nvidia-texture-tools, which in turn embeds a copy of libsquish. Since we build 0ad with Debian's nvidia-texture-tools packages and not with the embedded copy, there's nothing that needs to be done in 0ad; once nvidia-texture-tools switches over to using libsquish as packaged in Debian, 0ad will also be using the system version as well. Thanks for the bug report anyhow! Regards, Vincent
Bug#838055: 0ad: Embedded libsquish library now available in debian
Source: 0ad Severity: normal Dear Maintainer, 0ad contains an embedded copy of libsquish: in tools/depends/native/libsquish-native I have recently packaged libsquish, and it is now avilable in the archive: https://tracker.debian.org/pkg/libsquish In doing this I examined all the embedded copies, checking them for changes, and have merged all the extra features into the Debian package. Thus it should be straighforward to start using the system library instead of the embedded copy, without any API changes. The changes have also been sent upstream and will hopefully appear in libsquish 1.14 at some point. The 0ad version is a simple copy of squish v1.7 Debian policy https://www.debian.org/doc/debian-policy/ch-source.html#s-embeddedfiles say that embedded copies should not be used if the library is available in Debian, and https://wiki.debian.org/EmbeddedCodeCopies gives a bit more background. I am not familiar with the 0ad build system, so have not attempted to provide a patch as that should be much easier for you, but of course I'll help if you need some. The full set of packages affected is: - nvidia-texture-tools 1.7 (src/nvtt/squish) - 0ad 1.7 (libraries/source/nvtt/src/src/nvtt/squish/) - spring 1.10 (rts/lib/squish) - openimageio 1.10+ (1.10+metric) (src/dds.imageio/squish) - xbmc1.10+ (1.10+metric/BC45) (lib/libsquish) - kodi1.10+ (1.10+metric/BC45) (tools/depends/native/libsquish-native) - mame1.13+ (BC45) (3rdparty/bgfx/3rdparty/libsquish) Hope this is useful. Wookey
