Bug#838663: tox: python3 pip is called "pip3" in Debian and tox should call that instead of "pip"

2016-09-23 Thread Barry Warsaw
On Sep 23, 2016, at 02:37 PM, Ximin Luo wrote:

>In Debian we have "pip3" but tox hardcodes an invocation to "pip".
>
>The attached patch fixes this; it should definitely be forwarded to upstream
>as well.

Hi and thanks for the report/patch.  Can you provide a reproducible failure
that this bug fixes?



Bug#838663: tox: python3 pip is called "pip3" in Debian and tox should call that instead of "pip"

2016-09-23 Thread Ximin Luo
Looks like this is basically already fixed in upstream; they introduced a 
config option instead of hard-coding it.

X

-- 
GPG: ed25519/56034877E1F87C35
GPG: rsa4096/1318EFAC5FBBDBCE
https://github.com/infinity0/pubkeys.git



Bug#838663: tox: python3 pip is called "pip3" in Debian and tox should call that instead of "pip"

2016-09-23 Thread Ximin Luo
Package: tox
Version: 2.3.1-4
Severity: important
Tags: patch upstream

Dear Maintainer,

In Debian we have "pip3" but tox hardcodes an invocation to "pip".

The attached patch fixes this; it should definitely be forwarded to upstream as 
well.

The eventual goal is to make tox tests run without needing the network.

X

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'stable'), (300, 'unstable'), (200, 
'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.6.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages tox depends on:
ii  libjs-sphinxdoc1.4.6-1
ii  python33.5.1-4
ii  python3-pkg-resources  27.1.2-1
ii  python3-pluggy 0.3.1-1
ii  python3-py 1.4.31-2
ii  python3-setuptools 27.1.2-1
ii  python3-virtualenv 15.0.3+ds-1
pn  python3:any
ii  virtualenv 15.0.3+ds-1

tox recommends no packages.

tox suggests no packages.

-- no debconf information

-- debsums errors found:
debsums: changed file /usr/lib/python3/dist-packages/tox/session.py (from tox 
package)
--- tox/session.py	2015-12-14 11:03:29.0 +0100
+++ tox/session.py	2016-09-23 14:24:10.341689700 +0200
@@ -534,8 +534,8 @@
 # write out version dependency information
 action = self.newaction(venv, "envreport")
 with action:
-pip = venv.getcommandpath("pip")
-output = venv._pcall([str(pip), "freeze"],
+pip = [venv.envconfig.basepython, "-m", "pip"]
+output = venv._pcall(pip + ["freeze"],
  cwd=self.config.toxinidir,
  action=action)
 # the output contains a mime-header, skip it