Bug#838941: RFS: duperemove/0.11~beta3-3 ITP

2016-12-23 Thread peter . zahradnik 

On 2016-12-17 22:27, Gianfranco Costamagna wrote:

Hello,

Files: interval_tree.c interval_tree_generic.h



Copyright: 2012 Michel Lespinasse 
License: GPL-2

which then below lists GPL-2 license with address: Free Software
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
02110-1301, USA.
However I can see that in interval_tree_generic.h itself is address:
Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
02111-1307  USA

What should I do?



ask upstream to fix the address :)

btw, I'm more interested in this change:
-License: GPL-2

+License: GPL-2+

at least for interval_tree_generic.h
(and add the License text too)



fixed, license text for GPL-2+ was already there
https://mentors.debian.net/debian/pool/main/d/duperemove/duperemove_0.11~beta4-1.dsc


For xxhash.c: In file is BSD 2-Clause and I have verified it in it's
upstream https://github.com/Cyan4973/xxHash/blob/dev/LICENSE so in
opyright file I have:

Files: xxhash.h xxhash.c
Copyright: 2012-2014 Yann Collet
License: BSD-2-Clause




I can't see any issue with license for this file. Please advise


Looks good to me... Not sure what I missed!

G.


Thanks

Bug#838941: RFS: duperemove/0.11~beta3-3 ITP

2016-12-23 Thread Adam Borowski 
On Mon, Sep 26, 2016 at 10:12:04PM +0100, peter.zahrad...@znik.sk wrote:
>  * Package name: duperemove

Uhm guys, what's the status on this?  Unless you upload by pretty much
today, there's little chance it will get into stretch -- the effective
freeze date is in unstable (ie, past NEW) by Dec 26, and those lazy
ftpmaster guys will sit with their families instead of working on our
packages...  Shameful lack of respect for our tardiness! :p

I use duperemove a lot, it'd be sad if it didn't make it into stretch.


Meow!
-- 
Autotools hint: to do a zx-spectrum build on a pdp11 host, type:
  ./configure --host=zx-spectrum --build=pdp11

Bug#838941: RFS: duperemove/0.11~beta3-3 ITP

2016-12-17 Thread Gianfranco Costamagna 
Hello,
>Files: interval_tree.c interval_tree_generic.h

>Copyright: 2012 Michel Lespinasse 
>License: GPL-2
>
>which then below lists GPL-2 license with address: Free Software 
>Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 
>02110-1301, USA.
>However I can see that in interval_tree_generic.h itself is address: 
>Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  
>02111-1307  USA
>
>What should I do?


ask upstream to fix the address :)

btw, I'm more interested in this change:
-License: GPL-2

+License: GPL-2+

at least for interval_tree_generic.h
(and add the License text too)

>For xxhash.c: In file is BSD 2-Clause and I have verified it in it's 
>upstream https://github.com/Cyan4973/xxHash/blob/dev/LICENSE so in 
>opyright file I have:
>
>Files: xxhash.h xxhash.c
>Copyright: 2012-2014 Yann Collet
>License: BSD-2-Clause
>

>I can't see any issue with license for this file. Please advise

Looks good to me... Not sure what I missed!

G.

Bug#838941: RFS: duperemove/0.11~beta3-3 ITP

2016-12-12 Thread peter . zahradnik 

On 2016-10-31 17:09, Gianfranco Costamagna wrote:

Hi,

thanks for the review, I've fixed licenses now, can you review again?



lets see
interval_tree_generic.h: GPL (v2 or later) (with incorrect FSF 
address)




still wrong (missing the later clause)

xxhash.c
^^ wrong license

G.


This copyright thing is more challenging than I thought it would be :D


For interval_tree_generic.h I have in copyright file:

Files: interval_tree.c interval_tree_generic.h
Copyright: 2012 Michel Lespinasse 
License: GPL-2

which then below lists GPL-2 license with address: Free Software 
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 
02110-1301, USA.
However I can see that in interval_tree_generic.h itself is address: 
Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  
02111-1307  USA


What should I do?


For xxhash.c: In file is BSD 2-Clause and I have verified it in it's 
upstream https://github.com/Cyan4973/xxHash/blob/dev/LICENSE so in 
copyright file I have:


Files: xxhash.h xxhash.c
Copyright: 2012-2014 Yann Collet
License: BSD-2-Clause

I can't see any issue with license for this file. Please advise

thanks
Peter

Bug#838941: RFS: duperemove/0.11~beta3-3 ITP

2016-10-31 Thread Gianfranco Costamagna 
Hi,
>thanks for the review, I've fixed licenses now, can you review again?


lets see
> interval_tree_generic.h: GPL (v2 or later) (with incorrect FSF address)



still wrong (missing the later clause)

xxhash.c
^^ wrong license

G.

Bug#838941: RFS: duperemove/0.11~beta3-3 ITP

2016-10-29 Thread Peter Zahradnik 
On 10/18/2016 08:02 AM, Gianfranco Costamagna wrote:
> control: owner -1 !
> control: tags -1 moreinfo
>
> Hi,
>
>> Some comments:
>> - this is ITP bug so in d/changelog you should have one entry. with
>> one version, with Initial release and (Closes: #).
>> - in your patch there seems to be some UTF problem in the From:
>> - can you push pristine tar branches to the git ? I can't build it.
>> In d/control, the passage is not needed, options, arguments have place
>> in a man page.
>> "When given the -d option, duperemove will submit those extents for
>> deduplication using the btrfs-extent-same ioctl."
>
> Since a DD already reviewed it, and the points have been addressed,
> I'm adding a little review on top of that one, and probably I'll sponsor soon.
>
> 1) missing licenses
>
> rbtree_augmented.h: GPL (v2 or later) (with incorrect FSF address)
>
>
> docs/stylesheets/github-light.css: MIT/X11 (BSD like)
>
> interval_tree_generic.h: GPL (v2 or later) (with incorrect FSF address)
>
>
> 2) wrong copyright years
> Copyright (C) 2016 SUSE.
>
> ./filerec.c: * which is Copyright 2003 by Theodore Ts'o and released under 
> the GPL.
>
> ./docs/stylesheets/github-light.css:Copyright (c) 2016 GitHub, Inc.
>
> and probably more
> (license-reconsile)
>
> other stuff LGTM
> thanks,
>
> Gianfranco
Hi Gianfranco,

thanks for the review, I've fixed licenses now, can you review again?

Peter

Bug#838941: RFS: duperemove/0.11~beta3-3 ITP

2016-10-18 Thread Gianfranco Costamagna 
control: owner -1 !
control: tags -1 moreinfo

Hi,

>Some comments:
>- this is ITP bug so in d/changelog you should have one entry. with
>one version, with Initial release and (Closes: #).
>- in your patch there seems to be some UTF problem in the From:
>- can you push pristine tar branches to the git ? I can't build it.
>In d/control, the passage is not needed, options, arguments have place
>in a man page.
>"When given the -d option, duperemove will submit those extents for
>deduplication using the btrfs-extent-same ioctl."


Since a DD already reviewed it, and the points have been addressed,
I'm adding a little review on top of that one, and probably I'll sponsor soon.

1) missing licenses

rbtree_augmented.h: GPL (v2 or later) (with incorrect FSF address)


docs/stylesheets/github-light.css: MIT/X11 (BSD like)

interval_tree_generic.h: GPL (v2 or later) (with incorrect FSF address)


2) wrong copyright years
Copyright (C) 2016 SUSE.

./filerec.c: * which is Copyright 2003 by Theodore Ts'o and released under the 
GPL.

./docs/stylesheets/github-light.css:Copyright (c) 2016 GitHub, Inc.

and probably more
(license-reconsile)

other stuff LGTM
thanks,

Gianfranco

Bug#838941: RFS: duperemove/0.11~beta3-3 ITP

2016-09-28 Thread Dariusz Dwornikowski 
On 26 September 2016 at 23:12,   wrote:
> Package: sponsorship-requests
> Severity: wishlist
>
>   Dear mentors,
>
>   I am looking for a sponsor for my package "duperemove"
>
>  * Package name: duperemove
>Version : 0.11~beta3-3

Hi,

First of all, thank you for your contribution. I am DD but can't
sponsor you because my key expired.

Some comments:
- this is ITP bug so in d/changelog you should have one entry. with
one version, with Initial release and (Closes: #).
- in your patch there seems to be some UTF problem in the From:
- can you push pristine tar branches to the git ? I can't build it.
In d/control, the passage is not needed, options, arguments have place
in a man page.
"When given the -d option, duperemove will submit those extents for
deduplication using the btrfs-extent-same ioctl."

Bug#838941: RFS: duperemove/0.11~beta3-3 ITP

2016-09-26 Thread peter . zahradnik 

Package: sponsorship-requests
Severity: wishlist

  Dear mentors,

  I am looking for a sponsor for my package "duperemove"

 * Package name: duperemove
   Version : 0.11~beta3-3
   Upstream Author : Mark Fasheh 
 * URL : https://github.com/markfasheh/duperemove
 * License : GPL-2, GPL-2+, BSD-2-Clause
   Section : admin

  It builds those binary packages:

duperemove - Tools for deduping file systems

  To access further information about this package, please visit the 
following URL:


  https://mentors.debian.net/package/duperemove


  Alternatively, one can download the package with dget using this 
command:


dget -x 
https://mentors.debian.net/debian/pool/main/d/duperemove/duperemove_0.11~beta3-3.dsc


  Regards,
  Peter Zahradnik