Bug#841222: Acknowledgement (RFS: patat)
control: tag -1 +confirmed control: noowner -1 Hello Félix, I'm tagging this as confirmed (commit 184eb7ba0dfb453cd5aa759a1a88fdbee6ed5367) because you've addressed everything I brought up, but I've also written some comments below in response to your most recent message. On Mon, Oct 31, 2016 at 05:33:16PM +0100, Félix Sipma wrote: > > On Tue, Oct 25, 2016 at 10:34:11PM +0200, Félix Sipma wrote: > >> On 2016-10-23 11:51-0700, Sean Whitton wrote: > >>> You should use "Forwarded: not-needed" (see DEP-3). > >> > >> This does not seem to work with gbp-pq (see #785274), I propose to add > >> this as > >> soon as gbp-pq supports DEP-3. > > > > Indeed. Dmitry Bogatov pointed out to me that you can put the > > Forwarded: header at the end of the patch description (just before the > > ---) and then gbp won't remove it. > > It seems like gbp _does_ remove the Forwarded: header put just before the > ---... Not on my machine -- weird. iris ~/rfs/patat % gbp pq import gbp:info: Trying to apply patches at '184eb7ba0dfb453cd5aa759a1a88fdbee6ed5367' gbp:info: 1 patches listed in 'debian/patches/series' imported on 'patch-queue/master' iris ~/rfs/patat % gbp pq export gbp:info: On 'patch-queue/master', switching to 'master' gbp:info: Generating patches from git (master..patch-queue/master) On branch master Your branch is up-to-date with 'origin/master'. nothing to commit, working tree clean gbp:info: Dropped branch 'patch-queue/master'. iris ~/rfs/patat % git diff [no output, and indeed your Forwarded: header is present] > > I wanted to confirm that you'd forwarded your --version patch, but I > > couldn't without this header :) > > This particular patch is not needed anymore (fixed upstream). I pushed a new > version to my repo, and will put this new version on mentors as soon as pandoc > gets installable again. Looks good. > > I: patat: spelling-error-in-binary usr/bin/patat Nam Name > > I: patat: spelling-error-in-binary usr/bin/patat isn't isn't > > I: patat: spelling-error-in-binary usr/bin/patat forward forward > > I: patat: spelling-error-in-binary usr/bin/patat upto up to > > I: patat: spelling-error-in-binary usr/bin/patat discontigous > > discontiguous > > I: patat: spelling-error-in-binary usr/bin/patat uncomplete incomplete > > I: patat: spelling-error-in-binary usr/bin/patat The The > > [...] > > I guess it is better to not override this warning, so that we don't forget > that > the dependencies needs to be fixed. Fair enough. My reasoning was that you can't fix it within this package, so the warning shouldn't be emitted here. > > 2. Did you generate it with help2man, in the end? If so, there should > > be a rule in d/rules to allow someone to regenerate the manpage for a > > new upstream version (see the ocrmypdf package's rules file). If > > upstream introduces a new upstream version it should be easy to update > > the manpage. > > No. I did it by hand, help2man generated something ugly :-). Cool! > > 3. It might be nice to add a reference to the file in > > /usr/share/doc/patat/examples to the manpage. If I wanted to learn > > how to use patat, the manpage alone wouldn't be much use. > > Upstream is working on a manpage (see > https://github.com/jaspervdj/patat/issues/19 ). I'll add this manpage later, > for now I would like to have patat in debian. This manpage stuff is not > essential (and it takes time to work on it, that's why I didn't want to work > on > this), so I'd like to keep it like this, and update it as soon as upstream > release a manpage. I understand why you wouldn't want to work on a manpage in parallel with upstream's work, as you'll have to just throw yours away once they release theirs. It's good to hear that they've decided to work on that -- thanks for prompting them. General remarks in response to what you wrote: Debian has a lot of unmaintained and low-quality packages because people wanted to "have it in Debian", but weren't willing to put time into making the package high-quality. That's why, in the RFS review process, we try to give new contributors opportunities to demonstrate that they want to make their package high-quality. DDs are generally reluctant to sponsor packages where it is not clear that the packager is planning to continue to put time into the package after it has been uploaded. In this case you've amply demonstrated that you're willing to maintain the package, but I just wanted to explain to you why I've been insisting on these things that, as you say, aren't essential. > patat is buildable again on sid. I just built and installed the package and everything seems to work. You could look into adding the hardening flags, now that the Haskell transition is almost completely finished. -- Sean Whitton signature.asc Description: PGP signature
Bug#841222: Acknowledgement (RFS: patat)
Hi, On 2016-10-30 10:14-0700, Sean Whitton wrote: > I noticed that you've published your patch-queue/master branch. Since > that is a branch you will rebase, it's not a good idea to publish it > (the gbp documentation recommends against publishing it). Anyone who > needs the branch can reconstruct it with `gbp pq import`. OK, I unpublished patch-queue/master. > Unfortunately, patat doesn't build against sid at present. Hopefully > this will be resolved within the next week or so. In the meantime, > there is some stuff you can improve: > > On Tue, Oct 25, 2016 at 10:34:11PM +0200, Félix Sipma wrote: >> On 2016-10-23 11:51-0700, Sean Whitton wrote: >>> You should use "Forwarded: not-needed" (see DEP-3). >> >> This does not seem to work with gbp-pq (see #785274), I propose to add this >> as >> soon as gbp-pq supports DEP-3. > > Indeed. Dmitry Bogatov pointed out to me that you can put the > Forwarded: header at the end of the patch description (just before the > ---) and then gbp won't remove it. It seems like gbp _does_ remove the Forwarded: header put just before the ---... > I wanted to confirm that you'd forwarded your --version patch, but I > couldn't without this header :) This particular patch is not needed anymore (fixed upstream). I pushed a new version to my repo, and will put this new version on mentors as soon as pandoc gets installable again. > 2. You can fix all of these Lintian tags, except possibly > hardening-no-fortify-functions. You should definitely deal with > the warnings. > > W: patat-dbgsym: debug-file-with-no-debug-symbols I've updated debian/rules to something matching stylish-haskell. > > Your d/rules is fine, though I think that the override_dh_compress stanza > is not needed: policy says you should only compress files above a > certain size, and presumably dh_compress isn't compressing the README > because it is smaller than that size. > > On the next upload of stylish-haskell I will probably remove that > stanza -- sorry to mislead you! OK, I removed the override_dh_compress stanza. > I: patat: spelling-error-in-binary usr/bin/patat Nam Name > I: patat: spelling-error-in-binary usr/bin/patat isn't isn't > I: patat: spelling-error-in-binary usr/bin/patat forward forward > I: patat: spelling-error-in-binary usr/bin/patat upto up to > I: patat: spelling-error-in-binary usr/bin/patat discontigous > discontiguous > I: patat: spelling-error-in-binary usr/bin/patat uncomplete incomplete > I: patat: spelling-error-in-binary usr/bin/patat The The Not sure about this one... Is "patat" too generic for lintian? I've added this to debian/lintian-overrides. >>> >>> I don't understand. It is pointing out misspellings, such as >>> 'uncomplete', somewhere in the upstream source. You can add a quilt >>> patch to fix them, and forward it upstream. >> >> As I didn't found anything matching these errors in the source, I thought it >> was a generic error message concerning the binary name. >> >> Now, that I understood the purpose of this check, I can only found these >> mistakes in the binary itself, so I guess these are in the dependencies... > > Okay. In that case you should override them, with a comment in the > overrides file explaining why. I guess it is better to not override this warning, so that we don't forget that the dependencies needs to be fixed. > I: patat: hardening-no-bindnow usr/bin/patat I: patat: > hardening-no-pie usr/bin/patat > > I think that in order to pass hardening options to gcc, if you're > willing to work on that, you'll need to abandon the CDBS build system > you're using at present. See the Makefile for keysafe[1] (not yet in > Debian) to see how to pass the options, and the rules file for the > stylish-haskell package to see how to do without CDBS. After reading this Makefile, I'm not sure how keysafe avoids hardening-no-bindnow and hardening-no-pie... Do you have any clue? >>> >>> The Makefile propagates LDFLAGS, CFLAGS and CPPFLAGS through to ghc. >>> Then you enable all hardening in your d/rules,[1] and the right flags >>> get set by debhelper. >>> >>> [1] https://wiki.debian.org/Hardening >> >> I would like to wait a little before adding this: the default flags added to >> gcc seems quite new, so I propose to have a look again when things stabilize. > > Fair enough. > > FWIW keysafe's hardening is working fine, except for PIE, which has to > be disabled for Haskell atm. https://git.spwhitton.name/keysafe OK. > 3. Please run upstream's test suite during the package build. Should be done now, I'm not sure about how I run tests... See debian/rules override_dh_auto_test > > Okay. I can't test this atm because patat can't be built in sid, but > what you did looks sane. OK. >>> If help2man is insufficient, see again stylish-haskell where I use >>> asciidoctor. >> >> I'll try
Bug#841222: Acknowledgement (RFS: patat)
Hello Félix, I noticed that you've published your patch-queue/master branch. Since that is a branch you will rebase, it's not a good idea to publish it (the gbp documentation recommends against publishing it). Anyone who needs the branch can reconstruct it with `gbp pq import`. Unfortunately, patat doesn't build against sid at present. Hopefully this will be resolved within the next week or so. In the meantime, there is some stuff you can improve: On Tue, Oct 25, 2016 at 10:34:11PM +0200, Félix Sipma wrote: > On 2016-10-23 11:51-0700, Sean Whitton wrote: > > You should use "Forwarded: not-needed" (see DEP-3). > > This does not seem to work with gbp-pq (see #785274), I propose to add this as > soon as gbp-pq supports DEP-3. Indeed. Dmitry Bogatov pointed out to me that you can put the Forwarded: header at the end of the patch description (just before the ---) and then gbp won't remove it. I wanted to confirm that you'd forwarded your --version patch, but I couldn't without this header :) > >>> 2. You can fix all of these Lintian tags, except possibly > >>> hardening-no-fortify-functions. You should definitely deal with > >>> the warnings. > >>> > >>> W: patat-dbgsym: debug-file-with-no-debug-symbols > >> > >> I've updated debian/rules to something matching > >> stylish-haskell. Your d/rules is fine, though I think that the override_dh_compress stanza is not needed: policy says you should only compress files above a certain size, and presumably dh_compress isn't compressing the README because it is smaller than that size. On the next upload of stylish-haskell I will probably remove that stanza -- sorry to mislead you! > >>> I: patat: spelling-error-in-binary usr/bin/patat Nam Name > >>> I: patat: spelling-error-in-binary usr/bin/patat isn't isn't > >>> I: patat: spelling-error-in-binary usr/bin/patat forward forward > >>> I: patat: spelling-error-in-binary usr/bin/patat upto up to > >>> I: patat: spelling-error-in-binary usr/bin/patat discontigous > >>> discontiguous > >>> I: patat: spelling-error-in-binary usr/bin/patat uncomplete incomplete > >>> I: patat: spelling-error-in-binary usr/bin/patat The The > >> > >> Not sure about this one... Is "patat" too generic for lintian? I've > >> added this to debian/lintian-overrides. > > > > I don't understand. It is pointing out misspellings, such as > > 'uncomplete', somewhere in the upstream source. You can add a quilt > > patch to fix them, and forward it upstream. > > As I didn't found anything matching these errors in the source, I thought it > was a generic error message concerning the binary name. > > Now, that I understood the purpose of this check, I can only found these > mistakes in the binary itself, so I guess these are in the dependencies... Okay. In that case you should override them, with a comment in the overrides file explaining why. > >>> I: patat: hardening-no-bindnow usr/bin/patat I: patat: > >>> hardening-no-pie usr/bin/patat > >>> > >>> I think that in order to pass hardening options to gcc, if you're > >>> willing to work on that, you'll need to abandon the CDBS build system > >>> you're using at present. See the Makefile for keysafe[1] (not yet in > >>> Debian) to see how to pass the options, and the rules file for the > >>> stylish-haskell package to see how to do without CDBS. > >> > >> After reading this Makefile, I'm not sure how keysafe avoids > >> hardening-no-bindnow and hardening-no-pie... Do you have any clue? > > > > The Makefile propagates LDFLAGS, CFLAGS and CPPFLAGS through to ghc. > > Then you enable all hardening in your d/rules,[1] and the right flags > > get set by debhelper. > > > > [1] https://wiki.debian.org/Hardening > > I would like to wait a little before adding this: the default flags added to > gcc seems quite new, so I propose to have a look again when things stabilize. Fair enough. FWIW keysafe's hardening is working fine, except for PIE, which has to be disabled for Haskell atm. https://git.spwhitton.name/keysafe > >>> 3. Please run upstream's test suite during the package build. > >> > >> Should be done now, I'm not sure about how I run tests... See > >> debian/rules override_dh_auto_test Okay. I can't test this atm because patat can't be built in sid, but what you did looks sane. > > If help2man is insufficient, see again stylish-haskell where I use > > asciidoctor. > > I'll try to add a manpage using help2man. A few of comments on your manpage: 1. Have you forwarded it upstream? 2. Did you generate it with help2man, in the end? If so, there should be a rule in d/rules to allow someone to regenerate the manpage for a new upstream version (see the ocrmypdf package's rules file). If upstream introduces a new upstream version it should be easy to update the manpage. 3. It might be nice to add a reference to the file in /usr/share/doc/patat/examples to the manpage. If I wanted to learn how to use patat, the manpage alone wouldn't be much use. > Concerning DHG's
Bug#841222: Acknowledgement (RFS: patat)
OK, I've added: - a manpage - patat to DHG's package-plan I hope everything is good now... signature.asc Description: PGP signature
Bug#841222: Acknowledgement (RFS: patat)
On 2016-10-23 11:51-0700, Sean Whitton wrote: > You should use "Forwarded: not-needed" (see DEP-3). This does not seem to work with gbp-pq (see #785274), I propose to add this as soon as gbp-pq supports DEP-3. >>> 2. You can fix all of these Lintian tags, except possibly >>> hardening-no-fortify-functions. You should definitely deal with the >>> warnings. >>> >>> W: patat-dbgsym: debug-file-with-no-debug-symbols >> >> I've updated debian/rules to something matching >> stylish-haskell. > > Okay. I'll take a proper look soon. Thanks! >>> I: patat: spelling-error-in-binary usr/bin/patat Nam Name >>> I: patat: spelling-error-in-binary usr/bin/patat isn't isn't >>> I: patat: spelling-error-in-binary usr/bin/patat forward forward >>> I: patat: spelling-error-in-binary usr/bin/patat upto up to >>> I: patat: spelling-error-in-binary usr/bin/patat discontigous discontiguous >>> I: patat: spelling-error-in-binary usr/bin/patat uncomplete incomplete >>> I: patat: spelling-error-in-binary usr/bin/patat The The >> >> Not sure about this one... Is "patat" too generic for lintian? I've >> added this to debian/lintian-overrides. > > I don't understand. It is pointing out misspellings, such as > 'uncomplete', somewhere in the upstream source. You can add a quilt > patch to fix them, and forward it upstream. As I didn't found anything matching these errors in the source, I thought it was a generic error message concerning the binary name. Now, that I understood the purpose of this check, I can only found these mistakes in the binary itself, so I guess these are in the dependencies... >>> I: patat: hardening-no-bindnow usr/bin/patat I: patat: >>> hardening-no-pie usr/bin/patat >>> >>> I think that in order to pass hardening options to gcc, if you're >>> willing to work on that, you'll need to abandon the CDBS build system >>> you're using at present. See the Makefile for keysafe[1] (not yet in >>> Debian) to see how to pass the options, and the rules file for the >>> stylish-haskell package to see how to do without CDBS. >> >> After reading this Makefile, I'm not sure how keysafe avoids >> hardening-no-bindnow and hardening-no-pie... Do you have any clue? > > The Makefile propagates LDFLAGS, CFLAGS and CPPFLAGS through to ghc. > Then you enable all hardening in your d/rules,[1] and the right flags > get set by debhelper. > > [1] https://wiki.debian.org/Hardening I would like to wait a little before adding this: the default flags added to gcc seems quite new, so I propose to have a look again when things stabilize. >>> 3. Please run upstream's test suite during the package build. >> >> Should be done now, I'm not sure about how I run tests... See >> debian/rules override_dh_auto_test > > Okay, I'll look later. Thanks. >> Concerning the last lintian warning (binary-without-manpage), I'm not >> sure it will add anything to "--help", and it is going to add an >> overhead to maintain the package... If it's not required I would >> prefer not to do anything with this. > > Adding manpages is one of the things that Debian does to standardise and > bring together the different programs that are part of the Debian > system. I'd strongly encourage you to be part of this QA effort. > > With regard to maintenance, hopefully you can persuade upstream to adopt > your manpage, so there wouldn't be any overhead. > > In the meantime, you can use help2man to generate the manpage. Note > that you shouldn't run help2man during the package build, as it's a > notorious source of FTBFS bugs. Instead, add a target to d/rules to > generate the manpage. See the ocrmypdf source package's d/rules. > > If help2man is insufficient, see again stylish-haskell where I use > asciidoctor. I'll try to add a manpage using help2man. Concerning DHG's package-plan, I can't run the tests myself, ghc seems to be broken in my chroot due to hardening flag -pie (see #712228). So I propose to add patat later, when things calm down. signature.asc Description: PGP signature
Bug#841222: Acknowledgement (RFS: patat)
Dear Félix, On Sun, Oct 23, 2016 at 07:42:49PM +0200, Félix Sipma wrote: > > 2. As I mentioned previously, please add patat to the Haskell team's > > package-plan.git and run the scripts provided to confirm that the > > versions of all the libraries package by the Haskell team are compatible > > with patat. > > OK, I thought that I had to do that after having patat uploaded to sid. No, we put stuff in there before it's uploaded so we don't break it. > > 3. Could you confirm that the package builds with ghc 8, please? > > The Haskell team is working to have that version of ghc in stretch. > > It does, in fact ghc 8 is the default version (stackage lts-7.0) used to > build the package. Great. Thanks for confirming that. > Not sure about this "Forwarded:" header... The patch aim is to remove > installation instructions and CI links, so I obviously do not want to > forward this upstream. You should use "Forwarded: not-needed" (see DEP-3). > > 2. You can fix all of these Lintian tags, except possibly > > hardening-no-fortify-functions. You should definitely deal with the > > warnings. > > > > W: patat-dbgsym: debug-file-with-no-debug-symbols > > I've updated debian/rules to something matching > stylish-haskell. Okay. I'll take a proper look soon. > > I: patat: spelling-error-in-binary usr/bin/patat Nam Name > > I: patat: spelling-error-in-binary usr/bin/patat isn't isn't > > I: patat: spelling-error-in-binary usr/bin/patat forward forward > > I: patat: spelling-error-in-binary usr/bin/patat upto up to > > I: patat: spelling-error-in-binary usr/bin/patat discontigous discontiguous > > I: patat: spelling-error-in-binary usr/bin/patat uncomplete incomplete > > I: patat: spelling-error-in-binary usr/bin/patat The The > > Not sure about this one... Is "patat" too generic for lintian? I've > added this to debian/lintian-overrides. I don't understand. It is pointing out misspellings, such as 'uncomplete', somewhere in the upstream source. You can add a quilt patch to fix them, and forward it upstream. > > I: patat: hardening-no-bindnow usr/bin/patat I: patat: > > hardening-no-pie usr/bin/patat > > > > I think that in order to pass hardening options to gcc, if you're > > willing to work on that, you'll need to abandon the CDBS build system > > you're using at present. See the Makefile for keysafe[1] (not yet in > > Debian) to see how to pass the options, and the rules file for the > > stylish-haskell package to see how to do without CDBS. > > After reading this Makefile, I'm not sure how keysafe avoids > hardening-no-bindnow and hardening-no-pie... Do you have any clue? The Makefile propagates LDFLAGS, CFLAGS and CPPFLAGS through to ghc. Then you enable all hardening in your d/rules,[1] and the right flags get set by debhelper. > > 3. Please run upstream's test suite during the package build. > > Should be done now, I'm not sure about how I run tests... See > debian/rules override_dh_auto_test Okay, I'll look later. > Concerning the last lintian warning (binary-without-manpage), I'm not > sure it will add anything to "--help", and it is going to add an > overhead to maintain the package... If it's not required I would > prefer not to do anything with this. Adding manpages is one of the things that Debian does to standardise and bring together the different programs that are part of the Debian system. I'd strongly encourage you to be part of this QA effort. With regard to maintenance, hopefully you can persuade upstream to adopt your manpage, so there wouldn't be any overhead. In the meantime, you can use help2man to generate the manpage. Note that you shouldn't run help2man during the package build, as it's a notorious source of FTBFS bugs. Instead, add a target to d/rules to generate the manpage. See the ocrmypdf source package's d/rules. If help2man is insufficient, see again stylish-haskell where I use asciidoctor. [1] https://wiki.debian.org/Hardening -- Sean Whitton signature.asc Description: PGP signature
Bug#841222: Acknowledgement (RFS: patat)
On 2016-10-23 19:42+0200, Félix Sipma wrote: >> 2. As I mentioned previously, please add patat to the Haskell team's >> package-plan.git and run the scripts provided to confirm that the >> versions of all the libraries package by the Haskell team are compatible >> with patat. > > OK, I thought that I had to do that after having patat uploaded to sid. I've forgotten to do this. I'll try to have a look soon. signature.asc Description: PGP signature
Bug#841222: Acknowledgement (RFS: patat)
On 2016-10-23 19:42+0200, Félix Sipma wrote: >> 2. As I mentioned previously, please add patat to the Haskell team's >> package-plan.git and run the scripts provided to confirm that the >> versions of all the libraries package by the Haskell team are compatible >> with patat. > > OK, I thought that I had to do that after having patat uploaded to sid. I've forgotten to do this. I'll try to have a look soon. signature.asc Description: PGP signature
Bug#841222: Acknowledgement (RFS: patat)
On 2016-10-22 19:51-0700, Sean Whitton wrote: > control: owner -1 ! > control: tag -1 +moreinfo > > Dear Félix, > > Thank you for your work to bring this new package to Debian. I can't > sponsor the upload, but I hope this review is useful to you. Sure it was. Thanks! > I've split it into two sections: things that I would consider must-fixes > before an upload to Debian, and suggested improvements. The latter > aren't strictly necessary, but they would help demonstrate to a > potential sponsor that you are committed to maintaining this package in > Debian. > > Must-fixes > == > > 1. You need to run `dch -r` again so that your changelog is up-to-date > with your latest commit. Done. > 2. As I mentioned previously, please add patat to the Haskell team's > package-plan.git and run the scripts provided to confirm that the > versions of all the libraries package by the Haskell team are compatible > with patat. OK, I thought that I had to do that after having patat uploaded to sid. > 3. Could you confirm that the package builds with ghc 8, please? The > Haskell team is working to have that version of ghc in stretch. It does, in fact ghc 8 is the default version (stackage lts-7.0) used to build the package. > Suggestions > === > > 1. The header of your patch to the README needs some work. You didn't > "update" the README -- that implies the patch should be forwarded, but > it looks to be Debian-specific. Please add some explanatory text, or a > better subject, explaining why you made the changes (e.g. "patch README > for Debian"). Also, add a Forwarded: header. Done. Not sure about this "Forwarded:" header... The patch aim is to remove installation instructions and CI links, so I obviously do not want to forward this upstream. > 2. You can fix all of these Lintian tags, except possibly > hardening-no-fortify-functions. You should definitely deal with the > warnings. > > W: patat-dbgsym: debug-file-with-no-debug-symbols I've updated debian/rules to something matching stylish-haskell. > I: patat: hardening-no-fortify-functions usr/bin/patat I've not done anything for this one. > I: patat: spelling-error-in-binary usr/bin/patat Nam Name > I: patat: spelling-error-in-binary usr/bin/patat isn't isn't > I: patat: spelling-error-in-binary usr/bin/patat forward forward > I: patat: spelling-error-in-binary usr/bin/patat upto up to > I: patat: spelling-error-in-binary usr/bin/patat discontigous discontiguous > I: patat: spelling-error-in-binary usr/bin/patat uncomplete incomplete > I: patat: spelling-error-in-binary usr/bin/patat The The Not sure about this one... Is "patat" too generic for lintian? I've added this to debian/lintian-overrides. > I: patat: hardening-no-bindnow usr/bin/patat > I: patat: hardening-no-pie usr/bin/patat > > I think that in order to pass hardening options to gcc, if you're > willing to work on that, you'll need to abandon the CDBS build system > you're using at present. See the Makefile for keysafe[1] (not yet in > Debian) to see how to pass the options, and the rules file for the > stylish-haskell package to see how to do without CDBS. After reading this Makefile, I'm not sure how keysafe avoids hardening-no-bindnow and hardening-no-pie... Do you have any clue? > 3. Please run upstream's test suite during the package build. Should be done now, I'm not sure about how I run tests... See debian/rules override_dh_auto_test > 4. The screenshot should probably be installed into > /usr/share/doc/patat/examples. Done. > That should be enough for now! > > [1] https://joeyh.name/code/keysafe/ Concerning the last lintian warning (binary-without-manpage), I'm not sure it will add anything to "--help", and it is going to add an overhead to maintain the package... If it's not required I would prefer not to do anything with this. I've pushed the new version to mentors and to my git repo. signature.asc Description: PGP signature
Bug#841222: Acknowledgement (RFS: patat)
control: owner -1 ! control: tag -1 +moreinfo Dear Félix, Thank you for your work to bring this new package to Debian. I can't sponsor the upload, but I hope this review is useful to you. I've split it into two sections: things that I would consider must-fixes before an upload to Debian, and suggested improvements. The latter aren't strictly necessary, but they would help demonstrate to a potential sponsor that you are committed to maintaining this package in Debian. Must-fixes == 1. You need to run `dch -r` again so that your changelog is up-to-date with your latest commit. 2. As I mentioned previously, please add patat to the Haskell team's package-plan.git and run the scripts provided to confirm that the versions of all the libraries package by the Haskell team are compatible with patat. 3. Could you confirm that the package builds with ghc 8, please? The Haskell team is working to have that version of ghc in stretch. Suggestions === 1. The header of your patch to the README needs some work. You didn't "update" the README -- that implies the patch should be forwarded, but it looks to be Debian-specific. Please add some explanatory text, or a better subject, explaining why you made the changes (e.g. "patch README for Debian"). Also, add a Forwarded: header. 2. You can fix all of these Lintian tags, except possibly hardening-no-fortify-functions. You should definitely deal with the warnings. W: patat-dbgsym: debug-file-with-no-debug-symbols I: patat: hardening-no-fortify-functions usr/bin/patat I: patat: spelling-error-in-binary usr/bin/patat Nam Name I: patat: spelling-error-in-binary usr/bin/patat isn't isn't I: patat: spelling-error-in-binary usr/bin/patat forward forward I: patat: spelling-error-in-binary usr/bin/patat upto up to I: patat: spelling-error-in-binary usr/bin/patat discontigous discontiguous I: patat: spelling-error-in-binary usr/bin/patat uncomplete incomplete I: patat: spelling-error-in-binary usr/bin/patat The The I: patat: hardening-no-bindnow usr/bin/patat I: patat: hardening-no-pie usr/bin/patat I think that in order to pass hardening options to gcc, if you're willing to work on that, you'll need to abandon the CDBS build system you're using at present. See the Makefile for keysafe[1] (not yet in Debian) to see how to pass the options, and the rules file for the stylish-haskell package to see how to do without CDBS. 3. Please run upstream's test suite during the package build. 4. The screenshot should probably be installed into /usr/share/doc/patat/examples. That should be enough for now! [1] https://joeyh.name/code/keysafe/ -- Sean Whitton signature.asc Description: PGP signature
Bug#841222: Acknowledgement (RFS: patat)
I've updated patat to 0.3.2.0-1, see With dget: dget -x https://mentors.debian.net/debian/pool/main/p/patat/patat_0.3.2.0-1.dsc With gbp: gbp clone --pristine-tar https://git.gueux.org/patat.git cd patat gbp buildpackage signature.asc Description: PGP signature
Bug#841222: Acknowledgement (RFS: patat)
I've updated patat to 0.3.0.0-1, see With dget: dget -x https://mentors.debian.net/debian/pool/main/p/patat/patat_0.3.0.0-1.dsc With gbp: gbp clone --pristine-tar https://git.gueux.org/patat.git cd patat gbp buildpackage signature.asc Description: PGP signature
