Bug#841951: [PATCH]: bitcoin-qt segfaults on startup

[Lisandro Damián Nicanor Pérez Meyer]

On domingo, 30 de julio de 2017 08:55:59 -03 Erik de Castro Lopo wrote:
> Lisandro Damián Nicanor Pérez Meyer wrote:
> > As you can see in
> > 
> >   
> > 
> > the patch is not exactly right.
> 
> I've have be running with that patch in its current form since the start
> of the year. Afaiac its works as intended.
> 
> > That needs to be fixed before we add that patch, be it locally or in
> > upstream (although upstream is much better).
> 
> So who is it that does that?

Whoever that has time in her/his hands. I currently don't, so I can push it 
further I'm afraid.


-- 
Los chicos tienen un mayor dominio de la tecnología (y las habilidades y
lenguaje que eso implica) que los adultos con los que se relacionan. Por lo
general saben más que sus propios padres, sus docentes, sus pediatras,
psicólogos, que los políticos y funcionarios de sus comunidades. Eso afectó la
autoridad que tenía un adulto para habilitar al mundo.
  Luis Pescetti
  http://www.luispescetti.com/regale-su-obra/

Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/


signature.asc
Description: This is a digitally signed message part.

Bug#841951: [PATCH]: bitcoin-qt segfaults on startup

[Erik de Castro Lopo]

Lisandro Damián Nicanor Pérez Meyer wrote:

> As you can see in
> 
>   
> 
> the patch is not exactly right.

I've have be running with that patch in its current form since the start
of the year. Afaiac its works as intended.

> That needs to be fixed before we add that patch, be it locally or in upstream 
> (although upstream is much better).

So who is it that does that? 

Erik
-- 
--
Erik de Castro Lopo
http://www.mega-nerd.com/

Bug#841951: [PATCH]: bitcoin-qt segfaults on startup

[Lisandro Damián Nicanor Pérez Meyer]

On sábado, 29 de julio de 2017 18:06:45 -03 Erik de Castro Lopo wrote:
> Lisandro Damián Nicanor Pérez Meyer wrote:
> > forwarded 841951 https://bugreports.qt.io/browse/QTBUG-58910
> > thanks
> > 
> > Erik: if possible please subscribe to the upstream bug, maybe we can
> > iron out another bug in the process.
> 
> To fix this issue locally, I have force (ie, quick and dirty) installed a
> patched version of libqxcb-glx-integration.so, but every time I update that
> package it breaks bitcoin-qt.
> 
> Since upstream seem to be in no hurry to fix this, can debian not ship
> a patched version, at least until upstream fixes it?

As you can see in

  

the patch is not exactly right.

That needs to be fixed before we add that patch, be it locally or in upstream 
(although upstream is much better).



-- 
...man had always assumed that he was more intelligent than dolphins because
he had achieved so much -- the wheel, New York, wars and so on -- whilst all
the dolphins had ever done was muck about in the water having a good time.
But conversely, the dolphins had always believed that they were far more
intelligent than man -- for precisely the same reasons.
  Douglas Adams, "The hitchhikers' guide to the galaxy"

Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/


signature.asc
Description: This is a digitally signed message part.

Bug#841951: [PATCH]: bitcoin-qt segfaults on startup

[Erik de Castro Lopo]

Lisandro Damián Nicanor Pérez Meyer wrote:

> forwarded 841951 https://bugreports.qt.io/browse/QTBUG-58910
> thanks
> 
> Erik: if possible please subscribe to the upstream bug, maybe we can
> iron out another bug in the process.

To fix this issue locally, I have force (ie, quick and dirty) installed a
patched version of libqxcb-glx-integration.so, but every time I update that
package it breaks bitcoin-qt.

Since upstream seem to be in no hurry to fix this, can debian not ship 
a patched version, at least until upstream fixes it?

Erik
-- 
--
Erik de Castro Lopo
http://www.mega-nerd.com/

Bug#841951: [PATCH]: bitcoin-qt segfaults on startup

[Lisandro Damián Nicanor Pérez Meyer]

forwarded 841951 https://bugreports.qt.io/browse/QTBUG-58910
thanks

Erik: if possible please subscribe to the upstream bug, maybe we can
iron out another bug in the process.

Bug#841951: [PATCH]: bitcoin-qt segfaults on startup

[Lisandro Damián Nicanor Pérez Meyer]

On 12 February 2017 at 21:54, Erik de Castro Lopo  wrote:
>
> Hi,
>
> The attached patch applied to the qtbase-opensource-src-5.7.1+dfsg
> source packages fixes the segfault for me.
>
> The 5.8.0 package in experimental without this patch still segfaults.
> I haven't tried applying this patch to that version.

While I understand that this might be a valid bug and even a valid
patch I will first ask upstream to see what they think of this issue.
For what I understand it really seems a bug in your OpenGL
implementation.


-- 
Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/

Bug#841951: [PATCH]: bitcoin-qt segfaults on startup

[Erik de Castro Lopo]

Hi,

The attached patch applied to the qtbase-opensource-src-5.7.1+dfsg
source packages fixes the segfault for me.

The 5.8.0 package in experimental without this patch still segfaults.
I haven't tried applying this patch to that version.

Cheers,
Erik
-- 
--
Erik de Castro Lopo
http://www.mega-nerd.com/
Description: qglxconvenience: Avoid NULL dereference

Index: qtbase-opensource-src-5.7.1+dfsg/src/platformsupport/glxconvenience/qglxconvenience.cpp
===
--- qtbase-opensource-src-5.7.1+dfsg.orig/src/platformsupport/glxconvenience/qglxconvenience.cpp
+++ qtbase-opensource-src-5.7.1+dfsg/src/platformsupport/glxconvenience/qglxconvenience.cpp
@@ -207,6 +207,9 @@ GLXFBConfig qglx_findConfig(Display *dis
 
 QXlibPointer visual(glXGetVisualFromFBConfig(display, candidate);
 
+if (! visual)
+continue;
+
 const int actualRed = qPopulationCount(visual->red_mask);
 const int actualGreen = qPopulationCount(visual->green_mask);
 const int actualBlue = qPopulationCount(visual->blue_mask);