Bug#842126: taglib: Please fix symbols file for compatibility with -O3 optimization

2016-10-26 Thread Matteo Cypriani
Hi Steve,

Le mardi 25 octobre 2016, 22:36:44 EDT Steve Langasek a écrit :
> The attached patch fixes this by marking a number of template symbols, which
> are not part of taglib's ABI, as 'optional'.

Thanks a lot for your patch. I commited it in the Git repository for inclusion 
in the next upload:

https://anonscm.debian.org/cgit/collab-maint/taglib.git/commit/?
id=c9b8461814003139f1b79ca1e68d30e8bfaeccc5

Cheers,
  Matteo

signature.asc
Description: This is a digitally signed message part.


Bug#842126: taglib: Please fix symbols file for compatibility with -O3 optimization

2016-10-25 Thread Steve Langasek
Package: taglib
Version: 1.11.1-0.1
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu zesty ubuntu-patch

Hi Modestas,

The NMU of taglib 1.11.1 to unstable has included updates to the symbols
file.  The changes that were made are incompatible with building with -O3
optimization, as we do for the ppc64el port in Ubuntu.

The attached patch fixes this by marking a number of template symbols, which
are not part of taglib's ABI, as 'optional'.

This is not a complete list of all symbols which are possibly-optional
template instances, just those that need to be flagged as optional for
compatibility with -O3 on ppc64el.

Please consider applying this patch in Debian.

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developerhttp://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
diff -Nru taglib-1.11.1/debian/libtag1v5-vanilla.symbols taglib-1.11.1/debian/libtag1v5-vanilla.symbols
--- taglib-1.11.1/debian/libtag1v5-vanilla.symbols	2016-10-24 11:10:29.0 -0700
+++ taglib-1.11.1/debian/libtag1v5-vanilla.symbols	2016-10-25 22:19:37.0 -0700
@@ -2221,53 +2221,53 @@
  (arch-bits=64)_ZNSt6vectorIcSaIcEE14_M_fill_insertEN9__gnu_cxx17__normal_iteratorIPcS1_EEmRKc@Base 1.9.1-2.2~
  (arch-bits=32)_ZNSt6vectorIcSaIcEE14_M_fill_insertEN9__gnu_cxx17__normal_iteratorIPcS1_EEjRKc@Base 1.9.1-2.2~
  _ZNSt7__cxx1110_List_baseIN6TagLib10ByteVectorESaIS2_EE8_M_clearEv@Base 1.9.1-2.2~
- _ZNSt7__cxx1110_List_baseIN6TagLib3ASF9AttributeESaIS3_EE8_M_clearEv@Base 1.9.1-2.2~
- _ZNSt7__cxx1110_List_baseIN6TagLib3MP48CoverArtESaIS3_EE8_M_clearEv@Base 1.9.1-2.2~
- _ZNSt7__cxx1110_List_baseIN6TagLib5ID3v223SynchronizedLyricsFrame11SynchedTextESaIS4_EE8_M_clearEv@Base 1.11
+ (optional=templinst)_ZNSt7__cxx1110_List_baseIN6TagLib3ASF9AttributeESaIS3_EE8_M_clearEv@Base 1.9.1-2.2~
+ (optional=templinst)_ZNSt7__cxx1110_List_baseIN6TagLib3MP48CoverArtESaIS3_EE8_M_clearEv@Base 1.9.1-2.2~
+ (optional=templinst)_ZNSt7__cxx1110_List_baseIN6TagLib5ID3v223SynchronizedLyricsFrame11SynchedTextESaIS4_EE8_M_clearEv@Base 1.11
  _ZNSt7__cxx1110_List_baseIN6TagLib6StringESaIS2_EE8_M_clearEv@Base 1.9.1-2.2~
- _ZNSt7__cxx1112basic_stringIwSt11char_traitsIwESaIwEE12_M_constructIPwEEvT_S7_St20forward_iterator_tag@Base 1.9.1-2.2~
- (arch=amd64 arm64 mips64el ppc64el kfreebsd-amd64 sparc64 hppa m68k x32)_ZNSt8_Rb_treeIKN6TagLib6StringESt4pairIS2_NS0_3APE4ItemEESt10_Select1stIS6_ESt4lessIS2_ESaIS6_EE11equal_rangeERS2_@Base 1.11
+ (optional=templinst)_ZNSt7__cxx1112basic_stringIwSt11char_traitsIwESaIwEE12_M_constructIPwEEvT_S7_St20forward_iterator_tag@Base 1.9.1-2.2~
+ (optional=templinst)_ZNSt8_Rb_treeIKN6TagLib6StringESt4pairIS2_NS0_3APE4ItemEESt10_Select1stIS6_ESt4lessIS2_ESaIS6_EE11equal_rangeERS2_@Base 1.11
  _ZNSt8_Rb_treeIKN6TagLib6StringESt4pairIS2_NS0_3APE4ItemEESt10_Select1stIS6_ESt4lessIS2_ESaIS6_EE22_M_emplace_hint_uniqueIJRKSt21piecewise_construct_tSt5tupleIJRS2_EESH_IJESt17_Rb_tree_iteratorIS6_ESt23_Rb_tree_const_iteratorIS6_EDpOT_@Base 1.9.1-2.2~
- _ZNSt8_Rb_treeIKN6TagLib6StringESt4pairIS2_NS0_3APE4ItemEESt10_Select1stIS6_ESt4lessIS2_ESaIS6_EE24_M_get_insert_unique_posERS2_@Base 1.9.1-2.2~
- (arch=amd64 arm64 mips64el ppc64el kfreebsd-amd64 sparc64 hppa m68k x32)_ZNSt8_Rb_treeIKN6TagLib6StringESt4pairIS2_NS0_3APE4ItemEESt10_Select1stIS6_ESt4lessIS2_ESaIS6_EE29_M_get_insert_hint_unique_posESt23_Rb_tree_const_iteratorIS6_ERS2_@Base 1.9.1-2.2~
- _ZNSt8_Rb_treeIKN6TagLib6StringESt4pairIS2_NS0_3APE4ItemEESt10_Select1stIS6_ESt4lessIS2_ESaIS6_EE4findERS2_@Base 1.9.1-2.2~
+ (optional=templinst)_ZNSt8_Rb_treeIKN6TagLib6StringESt4pairIS2_NS0_3APE4ItemEESt10_Select1stIS6_ESt4lessIS2_ESaIS6_EE24_M_get_insert_unique_posERS2_@Base 1.9.1-2.2~
+ (optional=templinst)_ZNSt8_Rb_treeIKN6TagLib6StringESt4pairIS2_NS0_3APE4ItemEESt10_Select1stIS6_ESt4lessIS2_ESaIS6_EE29_M_get_insert_hint_unique_posESt23_Rb_tree_const_iteratorIS6_ERS2_@Base 1.9.1-2.2~
+ (optional=templinst)_ZNSt8_Rb_treeIKN6TagLib6StringESt4pairIS2_NS0_3APE4ItemEESt10_Select1stIS6_ESt4lessIS2_ESaIS6_EE4findERS2_@Base 1.9.1-2.2~
  _ZNSt8_Rb_treeIKN6TagLib6StringESt4pairIS2_NS0_3APE4ItemEESt10_Select1stIS6_ESt4lessIS2_ESaIS6_EE7_M_copyINSC_11_Alloc_nodeEEEPSt13_Rb_tree_nodeIS6_EPKSG_PSt18_Rb_tree_node_baseRT_@Base 1.9.1-2.2~
  _ZNSt8_Rb_treeIKN6TagLib6StringESt4pairIS2_NS0_3APE4ItemEESt10_Select1stIS6_ESt4lessIS2_ESaIS6_EE8_M_eraseEPSt13_Rb_tree_nodeIS6_E@Base 1.9.1-2.2~
- (arch=amd64 arm64 mips64el ppc64el kfreebsd-amd64 sparc64 hppa m68k x32)_ZNSt8_Rb_treeIN6TagLib10ByteVectorESt4pairIKS1_NS0_6StringEESt10_Select1stIS5_ESt4lessIS1_ESaIS5_EE11equal_rangeERS3_@Base 1.11
+ (optional=templinst)_ZNSt8_Rb_treeIN6TagLib10ByteVectorESt4pairIKS1_NS0_6StringEESt10_Select1stIS5_ESt4lessIS1_ESaIS5_EE11equal_rangeERS3_@Base 1.11