Bug#843245: distorm3: please make the build reproducible

[Eriberto]

Thanks a lot Reiner. And thanks for your effort about reproducible builds.

Cheers,

Eriberto


2016-11-05 11:12 GMT-02:00 Reiner Herrmann :
> Source: distorm3
> Version: 3.3.4-1
> Severity: wishlist
> Tags: patch upstream
> User: reproducible-bui...@lists.alioth.debian.org
> Usertags: fileordering
> X-Debbugs-Cc: reproducible-bui...@lists.alioth.debian.org
>
> Hi!
>
> While working on the "reproducible builds" effort [1], we have noticed
> that distorm3 could not be built reproducibly.
> During build objects are linked in non-deterministic order.
>
> The attached patch fixes this by sorting the list of source files.
>
> Regards,
>  Reiner
>
> [1]: https://wiki.debian.org/ReproducibleBuilds

Bug#843245: distorm3: please make the build reproducible

[Reiner Herrmann]

Source: distorm3
Version: 3.3.4-1
Severity: wishlist
Tags: patch upstream
User: reproducible-bui...@lists.alioth.debian.org
Usertags: fileordering
X-Debbugs-Cc: reproducible-bui...@lists.alioth.debian.org

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that distorm3 could not be built reproducibly.
During build objects are linked in non-deterministic order.

The attached patch fixes this by sorting the list of source files.

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds
diff --git a/debian/patches/20_reproducible_build.patch b/debian/patches/20_reproducible_build.patch
new file mode 100644
index 000..8bc70af
--- /dev/null
+++ b/debian/patches/20_reproducible_build.patch
@@ -0,0 +1,14 @@
+Author: Reiner Herrmann 
+Description: Sort source files for deterministic linking order
+
+--- a/setup.py
 b/setup.py
+@@ -33,7 +33,7 @@
+ create the libdistorm3 library.
+ """
+ 
+-return glob('src/*.c')
++return sorted(glob('src/*.c'))
+ 
+ 
+ class custom_build(build):
diff --git a/debian/patches/series b/debian/patches/series
index df72857..21eac1f 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
 10_fix_init_python.patch
+20_reproducible_build.patch


signature.asc
Description: PGP signature