Bug#843857: w1retap: FTBFS on mips and mipsel: braces around scalar initializer [-Werror]

2016-11-15 Thread Thomas Stewart
Hi Daniel,

Thanks for the report, patch and testing! I'm going to send this
upstream, update the w1retap package and ask my sponsor to upload the
new package.

Thanks :-)

Kind Regards
--
Tom



Bug#843857: w1retap: FTBFS on mips and mipsel: braces around scalar initializer [-Werror]

2016-11-10 Thread Daniel Knezevic
Package: w1retap
Version: 1.4.4-1
Severity: important
Tags: sid + patch
Justification: FTBFS
User: debian-m...@lists.debian.org
Usertags: mips-patch

Hi,

Package w1retap FTBFS on mips and mipsel with following error:
> w1retap.c:417:12: error: braces around scalar initializer [-Werror]
>  struct sigaction act ={{0}};
> ^

build logs:
https://buildd.debian.org/status/fetch.php?pkg=w1retap=mips=1.4.4-1=1478712530
https://buildd.debian.org/status/fetch.php?pkg=w1retap=mipsel=1.4.4-1=1478755892

The attached patch removes the extra braces.
This patch is successfully tested on mips, mipsel and i386.

Thanks,
Daniel
--- w1retap-1.4.4.orig/src/w1retap.c
+++ w1retap-1.4.4/src/w1retap.c
@@ -414,7 +414,7 @@ static void w1_show(w1_devlist_t *w1, in
 int main(int argc, char **argv)
 {
 struct timeval now = {0};
-struct sigaction act ={{0}};
+struct sigaction act ={0};
 gboolean immed = 0;
 gboolean showvers=0;
 gboolean once=0;