Bug#844882: ocserv: FTBFS: ./ocserv-args.h:1:1: error: unterminated comment

[Mike Miller]

On Sat, Nov 19, 2016 at 07:47:50 +0100, Lucas Nussbaum wrote:
> > In file included from sup-config/file.c:29:0:
> > ./ocserv-args.h:1:1: error: unterminated comment
> >  /*   -*- buffer-read-only: t -*- vi: set ro:
> >  ^

I can semi-reliably reproduce this and similar errors with sbuild -j32.

It seems to be a parallel build race condition in the build between
autogen and other source files that include the autogen-generated header
file.

The following procedure also reproduces (maybe 3 out of 4 times) from
upstream git (ocserv_0_11_4 tag):

  autoreconf -fi
  ./configure
  rm src/version.inc
  make -j32 all

Same on upstream git master, so the latest upstream 0.11.6 will hit the
same error.

The key ingredient is deleting src/version.inc *after* running
configure, which I think is causing autogen to run later than it should,
in turn causing a race with the compiler.

I'll take a look at the generated sources and see what we can change to
ensure everything is built in the right order. I'll also report upstream
and see if we can get a more robust build to prevent these kinds of
races in a future version.

-- 
mike

Bug#844882: ocserv: FTBFS: ./ocserv-args.h:1:1: error: unterminated comment

[Lucas Nussbaum]

Source: ocserv
Version: 0.11.4-1
Severity: serious
Tags: stretch sid
User: debian...@lists.debian.org
Usertags: qa-ftbfs-20161118 qa-ftbfs
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part (hopefully):
> gcc -DHAVE_CONFIG_H -I. -I.. -I./../gl/ -I./../gl/ -I./ -I./../ -I./../  
> -I/usr/include/p11-kit-1 -I./common -I./common   -I/usr/include/liboath 
> -isystem /usr/include/mit-krb5  -I/usr/include/p11-kit-1  -Wdate-time 
> -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<>=. 
> -fstack-protector-strong -Wformat -Werror=format-security -Wall 
> -Wno-strict-aliasing -c -o sup-config/radius.o sup-config/radius.c
> In file included from sup-config/file.c:29:0:
> ./ocserv-args.h:1:1: error: unterminated comment
>  /*   -*- buffer-read-only: t -*- vi: set ro:
>  ^
> worker-vpn.c: In function 'send_stats_to_secmod':
> worker-vpn.c:451:4: warning: ignoring return value of 'read', declared with 
> attribute warn_unused_result [-Wunused-result]
> read(sd, buf, sizeof(buf));
> ^~
> Makefile:1392: recipe for target 'sup-config/file.o' failed
> make[6]: *** [sup-config/file.o] Error 1

The full build log is available from:
   http://aws-logs.debian.net/2016/11/18/ocserv_0.11.4-1_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.