Bug#846353: FTBFS: ERROR: Test "ruby2.3" failed. Exiting.
On 12/05/2016 02:04 PM, Gilles Filippini wrote: > Sebastiaan Couwenberg a écrit le 03/12/2016 à 19:33 : >> On 12/03/2016 07:19 PM, Gilles Filippini wrote: >>> I've filed #846853 against src:hdf-eos5. There are issues in >>> ruby-hdfeos5 as well. See the attached patch. >>> >>> With these fixes the ruby-hdfeos5 testsuite passes on 64 bit and 32 bit >>> arches. >> >> Thanks for the patch! I've applied it in git, and will do a team upload >> after hdf-eos5 is fixed, unless Youhei beats me to it. > > Fixed hdf-eos5 is now in unstable. I've uploaded the fixed ruby-hdfeos5 to unstable. Kind Regards, Bas -- GPG Key ID: 4096R/6750F10AE88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1 signature.asc Description: OpenPGP digital signature
Bug#846353: FTBFS: ERROR: Test "ruby2.3" failed. Exiting.
Sebastiaan Couwenberg a écrit le 03/12/2016 à 19:33 : > Control: tags -1 pending > > On 12/03/2016 07:19 PM, Gilles Filippini wrote: >> I've filed #846853 against src:hdf-eos5. There are issues in >> ruby-hdfeos5 as well. See the attached patch. >> >> With these fixes the ruby-hdfeos5 testsuite passes on 64 bit and 32 bit >> arches. > > Thanks for the patch! I've applied it in git, and will do a team upload > after hdf-eos5 is fixed, unless Youhei beats me to it. Fixed hdf-eos5 is now in unstable. Thanks, _g. signature.asc Description: OpenPGP digital signature
Bug#846353: FTBFS: ERROR: Test "ruby2.3" failed. Exiting.
Control: tags -1 pending On 12/03/2016 07:19 PM, Gilles Filippini wrote: > I've filed #846853 against src:hdf-eos5. There are issues in > ruby-hdfeos5 as well. See the attached patch. > > With these fixes the ruby-hdfeos5 testsuite passes on 64 bit and 32 bit > arches. Thanks for the patch! I've applied it in git, and will do a team upload after hdf-eos5 is fixed, unless Youhei beats me to it. Kind Regards, Bas -- GPG Key ID: 4096R/6750F10AE88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1 signature.asc Description: OpenPGP digital signature
Bug#846353: FTBFS: ERROR: Test "ruby2.3" failed. Exiting.
Control: block -1 by 846853
Control: tags -1 + patch
Gilles Filippini a écrit le 03/12/2016 à 02:34 :
> Gilles Filippini a écrit le 03/12/2016 à 01:35 :
>> Gilles Filippini a écrit le 02/12/2016 à 23:26 :
>>> Sebastiaan Couwenberg a écrit le 02/12/2016 à 15:34 :
On 12/02/2016 09:55 AM, Sebastiaan Couwenberg wrote:
> On 12/01/2016 07:48 PM, Sebastiaan Couwenberg wrote:
>> On Wed, 30 Nov 2016 15:10:03 + Iain Lane wrote:
>>> This package FTBFS on 32 bit arches (works on amd64 and other 64 bit
>>> arches), maybe due to the new hdf5
>>
>> Quite likely, since hdf-eos5 hasn't been rebuilt for the hdf5 transition
>> yet. I suspect this issue to fix itself once that's done.
>
> It did not, but did only fail on 32-bit architectures.
Gilles, these failures seem to be caused by the hid_t type change from
32-bit to a 64-bit value. I'm not sure how to fix it for ruby-hdfeos5,
can you maybe provide a patch?
>>>
>>> Damn, I tested the build on amd64 only :/
>>> I've tried fixing the 'incompatible pointer type' warning, but it
>>> deosn't change anything wrt the test suite.
>>> Is there a way to ensure first that hdf-eos5 works fine on 32 bit archs?
>>
>> CC-ing Alastair, maintainer of hdf-eos5.
>>
>> AIUI the problem lies in hdf-eos5. I've ran a very simple C test made
>> after the first lines of test/test_gd.rb (source attached), both on
>> amd64 and i386. It succeeds on amd64 and fails on i386 at the
>> HE5_GDdetach step with:
>>
>> $ ./myhe5-32
>> bufsize = 19
>> ColumnAmountAerosol
>> HDF5-DIAG: Error detected in HDF5 (1.10.0-patch1) thread 4142823168:
>> #000: GDapi.c line 1140 in HE5_GDchkgdid(): Cannot get the Grid index
>>
>> major: Invalid arguments to routine
>> minor: Out of range
>> HDF5-DIAG: Error detected in HDF5 (1.10.0-patch1) thread 4142823168:
>> #000: EHapi.c line 2206 in HE5_EHchkfid(): Invalid file ID: 0. ID
>> should range from 67108864 to 67109064 .
>>
>> major: Invalid arguments to routine
>> minor: Bad value
>> HDF5-DIAG: Error detected in HDF5 (1.10.0-patch1) thread 4142823168:
>> #000: GDapi.c line 1151 in HE5_GDchkgdid(): Checking for file ID failed.
>>
>> major: Invalid arguments to routine
>> minor: Out of range
>> HDF5-DIAG: Error detected in HDF5 (1.10.0-patch1) thread 4142823168:
>> #000: GDapi.c line 12623 in HE5_GDdetach(): Checking for grid ID failed.
>>
>> major: Invalid arguments to routine
>> minor: Out of range
>
> The problem seems to be the type conversion functions in EHapi.c. For
> instance:
>
> long
> HE5_EHhid2long(hid_t invalue)
> {
> long outvalue = FAIL;
>
> if (sizeof(hid_t) == sizeof(int))
> outvalue = HE5_EHint2long(invalue);
> else if (sizeof(hid_t) == sizeof(long))
> outvalue = invalue;
>
> return(outvalue);
> }
>
> On 32 bit archs:
> sizeof(hid_t) != sizeof(int)
> sizeof(hid_t) != sizeof(long)
> sizeof(hid_t) == sizeof(long long)
>
> The conversion functions should be adapted accordingly.
I've filed #846853 against src:hdf-eos5. There are issues in
ruby-hdfeos5 as well. See the attached patch.
With these fixes the ruby-hdfeos5 testsuite passes on 64 bit and 32 bit
arches.
Thanks,
_g.
diff -Nru ruby-hdfeos5-1.2/debian/changelog ruby-hdfeos5-1.2/debian/changelog
--- ruby-hdfeos5-1.2/debian/changelog 2016-03-01 10:16:48.0 +0100
+++ ruby-hdfeos5-1.2/debian/changelog 2016-12-03 18:55:27.0 +0100
@@ -1,3 +1,10 @@
+ruby-hdfeos5 (1.2-6.1) unstable; urgency=medium
+
+ * Non-maintainer upload
+ * Fix FTBFS on 32 bi architectures against hdf5 1.10 (closes: #846353)
+
+ -- Gilles Filippini Sat, 03 Dec 2016 18:55:27 +0100
+
ruby-hdfeos5 (1.2-6) unstable; urgency=medium
* Remove dbg package
diff -Nru ruby-hdfeos5-1.2/debian/patches/hid_t.patch
ruby-hdfeos5-1.2/debian/patches/hid_t.patch
--- ruby-hdfeos5-1.2/debian/patches/hid_t.patch 1970-01-01 01:00:00.0
+0100
+++ ruby-hdfeos5-1.2/debian/patches/hid_t.patch 2016-12-03 15:23:32.0
+0100
@@ -0,0 +1,142 @@
+Index: ruby-hdfeos5-1.2/hdfeos5gd_wrap.c
+===
+--- ruby-hdfeos5-1.2.orig/hdfeos5gd_wrap.c
ruby-hdfeos5-1.2/hdfeos5gd_wrap.c
+@@ -20,7 +20,7 @@
+ #endif
+
+ extern int check_numbertype(char *);
+-extern int change_numbertype(char *);
++extern hid_t change_numbertype(char *);
+ extern int change_entrycode(char *);
+ extern int change_projcode(char *);
+ extern int change_compmethod(char *);
+@@ -1327,7 +1327,7 @@ hdfeos5_gdinqfields(VALUE mod, VALUE ent
+
+ i_count = (int)o_nflds;
+ rank = hdfeos5_cintary2obj(o_rank, i_count, 1, _count);
+-ntype = hdfeos5_cintary2obj(o_ntype, i_count, 1, _count);
++ntype = hdfeos5_cunsint64ary2obj(o_ntype, i_count, 1, _count);
+
+ return rb_ary_new3(4, nflds, fieldlist, rank, ntype);
+ }
+@@ -1905,12 +1905,12 @@ hdfeos5_gdsetextdata(VALUE mod, VALUE fi
+ size = rb_Array(size);
+
Bug#846353: FTBFS: ERROR: Test "ruby2.3" failed. Exiting.
Gilles Filippini a écrit le 03/12/2016 à 01:35 :
> Gilles Filippini a écrit le 02/12/2016 à 23:26 :
>> Sebastiaan Couwenberg a écrit le 02/12/2016 à 15:34 :
>>> On 12/02/2016 09:55 AM, Sebastiaan Couwenberg wrote:
On 12/01/2016 07:48 PM, Sebastiaan Couwenberg wrote:
> On Wed, 30 Nov 2016 15:10:03 + Iain Lane wrote:
>> This package FTBFS on 32 bit arches (works on amd64 and other 64 bit
>> arches), maybe due to the new hdf5
>
> Quite likely, since hdf-eos5 hasn't been rebuilt for the hdf5 transition
> yet. I suspect this issue to fix itself once that's done.
It did not, but did only fail on 32-bit architectures.
>>>
>>> Gilles, these failures seem to be caused by the hid_t type change from
>>> 32-bit to a 64-bit value. I'm not sure how to fix it for ruby-hdfeos5,
>>> can you maybe provide a patch?
>>
>> Damn, I tested the build on amd64 only :/
>> I've tried fixing the 'incompatible pointer type' warning, but it
>> deosn't change anything wrt the test suite.
>> Is there a way to ensure first that hdf-eos5 works fine on 32 bit archs?
>
> CC-ing Alastair, maintainer of hdf-eos5.
>
> AIUI the problem lies in hdf-eos5. I've ran a very simple C test made
> after the first lines of test/test_gd.rb (source attached), both on
> amd64 and i386. It succeeds on amd64 and fails on i386 at the
> HE5_GDdetach step with:
>
> $ ./myhe5-32
> bufsize = 19
> ColumnAmountAerosol
> HDF5-DIAG: Error detected in HDF5 (1.10.0-patch1) thread 4142823168:
> #000: GDapi.c line 1140 in HE5_GDchkgdid(): Cannot get the Grid index
>
> major: Invalid arguments to routine
> minor: Out of range
> HDF5-DIAG: Error detected in HDF5 (1.10.0-patch1) thread 4142823168:
> #000: EHapi.c line 2206 in HE5_EHchkfid(): Invalid file ID: 0. ID
> should range from 67108864 to 67109064 .
>
> major: Invalid arguments to routine
> minor: Bad value
> HDF5-DIAG: Error detected in HDF5 (1.10.0-patch1) thread 4142823168:
> #000: GDapi.c line 1151 in HE5_GDchkgdid(): Checking for file ID failed.
>
> major: Invalid arguments to routine
> minor: Out of range
> HDF5-DIAG: Error detected in HDF5 (1.10.0-patch1) thread 4142823168:
> #000: GDapi.c line 12623 in HE5_GDdetach(): Checking for grid ID failed.
>
> major: Invalid arguments to routine
> minor: Out of range
The problem seems to be the type conversion functions in EHapi.c. For
instance:
long
HE5_EHhid2long(hid_t invalue)
{
long outvalue = FAIL;
if (sizeof(hid_t) == sizeof(int))
outvalue = HE5_EHint2long(invalue);
else if (sizeof(hid_t) == sizeof(long))
outvalue = invalue;
return(outvalue);
}
On 32 bit archs:
sizeof(hid_t) != sizeof(int)
sizeof(hid_t) != sizeof(long)
sizeof(hid_t) == sizeof(long long)
The conversion functions should be adapted accordingly.
Thanks,
_g.
signature.asc
Description: OpenPGP digital signature
Bug#846353: FTBFS: ERROR: Test "ruby2.3" failed. Exiting.
Gilles Filippini a écrit le 02/12/2016 à 23:26 :
> Sebastiaan Couwenberg a écrit le 02/12/2016 à 15:34 :
>> On 12/02/2016 09:55 AM, Sebastiaan Couwenberg wrote:
>>> On 12/01/2016 07:48 PM, Sebastiaan Couwenberg wrote:
On Wed, 30 Nov 2016 15:10:03 + Iain Lane wrote:
> This package FTBFS on 32 bit arches (works on amd64 and other 64 bit
> arches), maybe due to the new hdf5
Quite likely, since hdf-eos5 hasn't been rebuilt for the hdf5 transition
yet. I suspect this issue to fix itself once that's done.
>>>
>>> It did not, but did only fail on 32-bit architectures.
>>
>> Gilles, these failures seem to be caused by the hid_t type change from
>> 32-bit to a 64-bit value. I'm not sure how to fix it for ruby-hdfeos5,
>> can you maybe provide a patch?
>
> Damn, I tested the build on amd64 only :/
> I've tried fixing the 'incompatible pointer type' warning, but it
> deosn't change anything wrt the test suite.
> Is there a way to ensure first that hdf-eos5 works fine on 32 bit archs?
CC-ing Alastair, maintainer of hdf-eos5.
AIUI the problem lies in hdf-eos5. I've ran a very simple C test made
after the first lines of test/test_gd.rb (source attached), both on
amd64 and i386. It succeeds on amd64 and fails on i386 at the
HE5_GDdetach step with:
$ ./myhe5-32
bufsize = 19
ColumnAmountAerosol
HDF5-DIAG: Error detected in HDF5 (1.10.0-patch1) thread 4142823168:
#000: GDapi.c line 1140 in HE5_GDchkgdid(): Cannot get the Grid index
major: Invalid arguments to routine
minor: Out of range
HDF5-DIAG: Error detected in HDF5 (1.10.0-patch1) thread 4142823168:
#000: EHapi.c line 2206 in HE5_EHchkfid(): Invalid file ID: 0. ID
should range from 67108864 to 67109064 .
major: Invalid arguments to routine
minor: Bad value
HDF5-DIAG: Error detected in HDF5 (1.10.0-patch1) thread 4142823168:
#000: GDapi.c line 1151 in HE5_GDchkgdid(): Checking for file ID failed.
major: Invalid arguments to routine
minor: Out of range
HDF5-DIAG: Error detected in HDF5 (1.10.0-patch1) thread 4142823168:
#000: GDapi.c line 12623 in HE5_GDdetach(): Checking for grid ID failed.
major: Invalid arguments to routine
minor: Out of range
Thanks,
_g.
#include
const char *filename = "OMI-Aura_L3-OMAEROe_2008m0101_v003-2009m0114t114202.he5";
int main(int argc, char *argv[]) {
hid_t fid, gdid;
long ngrid, bufsize = 0;
herr_t ret;
char *buffer;
fid = HE5_EHopen(filename, H5F_ACC_RDONLY, H5P_DEFAULT);
ngrid = HE5_GDinqgrid(filename, NULL, );
printf("bufsize = %ld\n", bufsize);
buffer = malloc((size_t)bufsize+1);
buffer[bufsize] = '\0';
ngrid = HE5_GDinqgrid(filename, buffer, );
printf("%s\n", buffer);
gdid = HE5_GDattach(fid, buffer);
HE5_GDdetach(gdid);
free(buffer);
ret = HE5_EHclose(fid);
return ret;
}
signature.asc
Description: OpenPGP digital signature
Bug#846353: FTBFS: ERROR: Test "ruby2.3" failed. Exiting.
Sebastiaan Couwenberg a écrit le 02/12/2016 à 15:34 : > On 12/02/2016 09:55 AM, Sebastiaan Couwenberg wrote: >> On 12/01/2016 07:48 PM, Sebastiaan Couwenberg wrote: >>> On Wed, 30 Nov 2016 15:10:03 + Iain Lane wrote: This package FTBFS on 32 bit arches (works on amd64 and other 64 bit arches), maybe due to the new hdf5 >>> >>> Quite likely, since hdf-eos5 hasn't been rebuilt for the hdf5 transition >>> yet. I suspect this issue to fix itself once that's done. >> >> It did not, but did only fail on 32-bit architectures. > > Gilles, these failures seem to be caused by the hid_t type change from > 32-bit to a 64-bit value. I'm not sure how to fix it for ruby-hdfeos5, > can you maybe provide a patch? Damn, I tested the build on amd64 only :/ I've tried fixing the 'incompatible pointer type' warning, but it deosn't change anything wrt the test suite. Is there a way to ensure first that hdf-eos5 works fine on 32 bit archs? Thanks, _g. signature.asc Description: OpenPGP digital signature
Bug#846353: FTBFS: ERROR: Test "ruby2.3" failed. Exiting.
On 12/02/2016 09:55 AM, Sebastiaan Couwenberg wrote: > On 12/01/2016 07:48 PM, Sebastiaan Couwenberg wrote: >> On Wed, 30 Nov 2016 15:10:03 + Iain Lane wrote: >>> This package FTBFS on 32 bit arches (works on amd64 and other 64 bit >>> arches), maybe due to the new hdf5 >> >> Quite likely, since hdf-eos5 hasn't been rebuilt for the hdf5 transition >> yet. I suspect this issue to fix itself once that's done. > > It did not, but did only fail on 32-bit architectures. Gilles, these failures seem to be caused by the hid_t type change from 32-bit to a 64-bit value. I'm not sure how to fix it for ruby-hdfeos5, can you maybe provide a patch? Kind Regards, Bas -- GPG Key ID: 4096R/6750F10AE88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
Bug#846353: FTBFS: ERROR: Test "ruby2.3" failed. Exiting.
On 12/01/2016 07:48 PM, Sebastiaan Couwenberg wrote: > On Wed, 30 Nov 2016 15:10:03 + Iain Lane wrote: >> This package FTBFS on 32 bit arches (works on amd64 and other 64 bit >> arches), maybe due to the new hdf5 > > Quite likely, since hdf-eos5 hasn't been rebuilt for the hdf5 transition > yet. I suspect this issue to fix itself once that's done. It did not, but did only fail on 32-bit architectures. Kind Regards, Bas -- GPG Key ID: 4096R/6750F10AE88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
Bug#846353: FTBFS: ERROR: Test "ruby2.3" failed. Exiting.
On Wed, 30 Nov 2016 15:10:03 + Iain Lane wrote: > This package FTBFS on 32 bit arches (works on amd64 and other 64 bit > arches), maybe due to the new hdf5 Quite likely, since hdf-eos5 hasn't been rebuilt for the hdf5 transition yet. I suspect this issue to fix itself once that's done. Kind Regards, Bas -- GPG Key ID: 4096R/6750F10AE88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
