Bug#848504: usrmerge breaks various systemd symlinks

[Marco d'Itri]

Control: retitle -1 other packages may break when installed on a half-converted 
system
Control: severity -1 minor

On Dec 17, Christian Hofstaedtler  wrote:

> So what I did not mention before (sorry), is that installing
> usrmerge actually aborted at first, because keepalived installed a
> file in both /usr/lib and /lib; but from the output it appeared to
> me the abort happened before doing any real work. Therefore I just
> removed keepalived and then dpkg ran the usrmerge postinst again, I
> think.
I think that dpkg also continued installing other packages while the 
transition was ongoing.
This is why the program warned you when failing:

  Do not install or update other Debian packages until the program
  has been run successfully.

I am not sure about what other practical solutions are available.
I am downgrading this bug because this is a documented behaviour.

Also, I cannot find any duplicated files in keepalived: but if it is 
incompatible for real then I want to send a patch to the maintainer and 
make usrmerge conflict with the older versions.

-- 
ciao,
Marco


signature.asc
Description: PGP signature

Bug#848504: usrmerge breaks various systemd symlinks

[Marco d'Itri]

Control: severity -1 normal
Control: tag -1 -moreinfo
Control: close -1

On Dec 17, Christian Hofstaedtler  wrote:

> usrmerge reports that various symlinks installed by systemd are "broken"
> and cannot be properly converted:
Because they are, so the program cannot magically guess how to resolve 
the / vs. /usr files conflicts.
Check the two relevant code paths in /usr/lib/convert-usrmerge for 
details.

Before the conversion you had:
/usr/lib/systemd/system/dbus-org.freedesktop.hostname1.service => 
systemd-hostnamed.service (correct)
/usr/lib/systemd/system/systemd-hostnamed.service was missing (how is this even 
possible?)
/lib/systemd/system/dbus-org.freedesktop.hostname1.service => 
/usr/lib/systemd/system/dbus-org.freedesktop.hostname1.service (WTF?)

> So what I did not mention before (sorry), is that installing
> usrmerge actually aborted at first, because keepalived installed a
This does not matter: convert-usrmerge is idempotent.

-- 
ciao,
Marco


signature.asc
Description: PGP signature

Bug#848504: usrmerge breaks various systemd symlinks

[Christian Hofstaedtler]

Control: found -1 13

* Michael Biebl  [161217 21:35]:
> Am 17.12.2016 um 21:08 schrieb Michael Biebl:
...
> > So it seems, usrmerge resolved those to the symlink target.
> > 
> > I don't see anything broken in systemd here though, so 
> > reassigning to usrmerge (and bumping the severity, as this breaks systemd 
> > badly)
> > 
> > Which version of usrmerge is this?

Version 13

> Fwiw, I just tried usrmerge in a freshly created test VM. It ran
> succesfully without any issues regarding systemd symlinks.
> 
> Christian, do you have any custom modifications or some special setup?
> Do you maybe have a backup of that system where you can check those
> symlinks and where they were pointing to?

No to both unfortunately. This is my scratch/build VM, so it may
very well have seen various interesting upgrades over time in sid,
or it may just have been plain and normal. The VM probably started
out as jessie.

So what I did not mention before (sorry), is that installing
usrmerge actually aborted at first, because keepalived installed a
file in both /usr/lib and /lib; but from the output it appeared to
me the abort happened before doing any real work. Therefore I just
removed keepalived and then dpkg ran the usrmerge postinst again, I
think.

/etc/fstab (minus comments):
UUID=dcdeb525-ea16-4b14-96bc-52669f8b28f6 /   ext4 
errors=remount-ro 0   1

/proc/cmdline:
BOOT_IMAGE=/boot/vmlinuz-4.8.0-2-amd64 
root=UUID=dcdeb525-ea16-4b14-96bc-52669f8b28f6 ro panic=30 console=ttyS0,115200 
console=tty0 vga=791

% grep -Ev '^(#|$)' /etc/dpkg/dpkg.cfg /etc/dpkg/dpkg.cfg.d/*
/etc/dpkg/dpkg.cfg:no-debsig
/etc/dpkg/dpkg.cfg:log /var/log/dpkg.log
/etc/dpkg/dpkg.cfg.d/needrestart:status-logger=(test -x 
/usr/lib/needrestart/dpkg-status && /usr/lib/needrestart/dpkg-status || cat > 
/dev/null)
/etc/dpkg/dpkg.cfg.d/pkg-config-hook-config:post-invoke=if { test 
"$DPKG_HOOK_ACTION" = add-architecture || test "$DPKG_HOOK_ACTION" = 
remove-architecture; } && test -x /usr/share/pkg-config-dpkghook; then 
/usr/share/pkg-config-dpkghook update; fi

apt is set to APT::Install-Recommends 0;

ii  usrmerge  13  
all Convert the system to the merged /usr directories 
scheme
ii  util-linux2.29-1  
amd64   miscellaneous system utilities
ii  systemd   232-7   
amd64   system and service manager
un  systemd-container   
  (no description available)
un  systemd-shim
  (no description available)
ii  systemd-sysv  232-7   
amd64   system and service manager - SysV links
un  systemd-ui  
  (no description available)

Cheers,
-- 
 ,''`.  Christian Hofstaedtler 
: :' :  Debian Developer
`. `'   7D1A CFFA D9E0 806C 9C4C  D392 5C13 D6DB 9305 2E03
  `-

Bug#848504: usrmerge breaks various systemd symlinks

[Michael Biebl]

Control: tags -1 + moreinfo unreproducible

Am 17.12.2016 um 21:08 schrieb Michael Biebl:
> Am 17.12.2016 um 19:55 schrieb Michael Biebl:
>> On Sat, 17 Dec 2016 19:46:03 +0100 Christian Hofstaedtler
>>  wrote:
>>> Package: systemd
>>> Version: 232-7
>>>
>>> usrmerge reports that various symlinks installed by systemd are "broken"
>>> and cannot be properly converted:
>>>
>>> WARNING: /usr/lib/systemd/system/dbus-org.freedesktop.login1.service is a 
>>> broken symlink and has been renamed!
>>> WARNING: /usr/lib/systemd/system/runlevel3.target is a broken symlink and 
>>> has been renamed!
>>> WARNING: /usr/lib/systemd/system/dbus-org.freedesktop.timedate1.service is 
>>> a broken symlink and has been renamed!
>>> WARNING: /usr/lib/systemd/system/dbus-org.freedesktop.hostname1.service is 
>>> a broken symlink and has been renamed!
>>> WARNING: /usr/lib/systemd/system/procps.service is a broken symlink and has 
>>> been renamed!
>>>
>>> ls -la (in /usr/lib/systemd/system/) after conversion:
>>>
>>> lrwxrwxrwx 1 root root 62 Dec 17 18:35 
>>> dbus-org.freedesktop.hostname1.service -> 
>>> /usr/lib/systemd/system/dbus-org.freedesktop.hostname1.service
>>> lrwxrwxrwx 1 root root 59 Dec 17 18:35 dbus-org.freedesktop.login1.service 
>>> -> /usr/lib/systemd/system/dbus-org.freedesktop.login1.service
>>> lrwxrwxrwx 1 root root 62 Dec 17 18:35 
>>> dbus-org.freedesktop.timedate1.service -> 
>>> /usr/lib/systemd/system/dbus-org.freedesktop.timedate1.service
>>> lrwxrwxrwx 1 root root 38 Dec 17 18:35 procps.service -> 
>>> /usr/lib/systemd/system/procps.service
>>> lrwxrwxrwx 1 root root 40 Dec 17 18:35 runlevel3.target -> 
>>> /usr/lib/systemd/system/runlevel3.target
> 
> Hm, this looks broken indeed. Those symlinks point to themselves.
> 
> Before the conversion they look like this
> lrwxrwxrwx 1 root root 22 Dez 17 01:54 /lib/systemd/system/procps.service -> 
> systemd-sysctl.service
> lrwxrwxrwx 1 root root 17 Dez 17 01:54 /lib/systemd/system/runlevel3.target 
> -> multi-user.target
> ...
> 
> So it seems, usrmerge resolved those to the symlink target.
> 
> I don't see anything broken in systemd here though, so 
> reassigning to usrmerge (and bumping the severity, as this breaks systemd 
> badly)
> 
> Which version of usrmerge is this?

Fwiw, I just tried usrmerge in a freshly created test VM. It ran
succesfully without any issues regarding systemd symlinks.

Christian, do you have any custom modifications or some special setup?
Do you maybe have a backup of that system where you can check those
symlinks and where they were pointing to?


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature

Bug#848504: usrmerge breaks various systemd symlinks

[Michael Biebl]

Control: reassign -1 usrmerge
Control: severity -1 serious
Control: affects -1 systemd

Am 17.12.2016 um 19:55 schrieb Michael Biebl:
> On Sat, 17 Dec 2016 19:46:03 +0100 Christian Hofstaedtler
>  wrote:
>> Package: systemd
>> Version: 232-7
>>
>> usrmerge reports that various symlinks installed by systemd are "broken"
>> and cannot be properly converted:
>>
>> WARNING: /usr/lib/systemd/system/dbus-org.freedesktop.login1.service is a 
>> broken symlink and has been renamed!
>> WARNING: /usr/lib/systemd/system/runlevel3.target is a broken symlink and 
>> has been renamed!
>> WARNING: /usr/lib/systemd/system/dbus-org.freedesktop.timedate1.service is a 
>> broken symlink and has been renamed!
>> WARNING: /usr/lib/systemd/system/dbus-org.freedesktop.hostname1.service is a 
>> broken symlink and has been renamed!
>> WARNING: /usr/lib/systemd/system/procps.service is a broken symlink and has 
>> been renamed!
>>
>> ls -la (in /usr/lib/systemd/system/) after conversion:
>>
>> lrwxrwxrwx 1 root root 62 Dec 17 18:35 
>> dbus-org.freedesktop.hostname1.service -> 
>> /usr/lib/systemd/system/dbus-org.freedesktop.hostname1.service
>> lrwxrwxrwx 1 root root 59 Dec 17 18:35 dbus-org.freedesktop.login1.service 
>> -> /usr/lib/systemd/system/dbus-org.freedesktop.login1.service
>> lrwxrwxrwx 1 root root 62 Dec 17 18:35 
>> dbus-org.freedesktop.timedate1.service -> 
>> /usr/lib/systemd/system/dbus-org.freedesktop.timedate1.service
>> lrwxrwxrwx 1 root root 38 Dec 17 18:35 procps.service -> 
>> /usr/lib/systemd/system/procps.service
>> lrwxrwxrwx 1 root root 40 Dec 17 18:35 runlevel3.target -> 
>> /usr/lib/systemd/system/runlevel3.target

Hm, this looks broken indeed. Those symlinks point to themselves.

Before the conversion they look like this
lrwxrwxrwx 1 root root 22 Dez 17 01:54 /lib/systemd/system/procps.service -> 
systemd-sysctl.service
lrwxrwxrwx 1 root root 17 Dez 17 01:54 /lib/systemd/system/runlevel3.target -> 
multi-user.target
...

So it seems, usrmerge resolved those to the symlink target.

I don't see anything broken in systemd here though, so 
reassigning to usrmerge (and bumping the severity, as this breaks systemd badly)

Which version of usrmerge is this?

Regards,
Michael


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature

Bug#848504: usrmerge breaks various systemd symlinks

[Christian Hofstaedtler]

After rebooting:

% systemctl status procps.service
Unit procps.service could not be found.
% systemctl status runlevel3.target
Unit runlevel3.target could not be found.
% systemctl status dbus-org.freedesktop.hostname1.service
Unit dbus-org.freedesktop.hostname1.service could not be found.
% systemctl status dbus-org.freedesktop.timedate1.service
Unit dbus-org.freedesktop.timedate1.service could not be found.
% systemctl status dbus-org.freedesktop.login1.service   
Unit dbus-org.freedesktop.login1.service could not be found.

I don't think that is the expected outcome...?

-- 
christian hofstaedtler 

Bug#848504: usrmerge breaks various systemd symlinks

[Michael Biebl]

On Sat, 17 Dec 2016 19:46:03 +0100 Christian Hofstaedtler
 wrote:
> Package: systemd
> Version: 232-7
> 
> usrmerge reports that various symlinks installed by systemd are "broken"
> and cannot be properly converted:
> 
> WARNING: /usr/lib/systemd/system/dbus-org.freedesktop.login1.service is a 
> broken symlink and has been renamed!
> WARNING: /usr/lib/systemd/system/runlevel3.target is a broken symlink and has 
> been renamed!
> WARNING: /usr/lib/systemd/system/dbus-org.freedesktop.timedate1.service is a 
> broken symlink and has been renamed!
> WARNING: /usr/lib/systemd/system/dbus-org.freedesktop.hostname1.service is a 
> broken symlink and has been renamed!
> WARNING: /usr/lib/systemd/system/procps.service is a broken symlink and has 
> been renamed!
> 
> ls -la (in /usr/lib/systemd/system/) after conversion:
> 
> lrwxrwxrwx 1 root root 62 Dec 17 18:35 dbus-org.freedesktop.hostname1.service 
> -> /usr/lib/systemd/system/dbus-org.freedesktop.hostname1.service
> lrwxrwxrwx 1 root root 59 Dec 17 18:35 dbus-org.freedesktop.login1.service -> 
> /usr/lib/systemd/system/dbus-org.freedesktop.login1.service
> lrwxrwxrwx 1 root root 62 Dec 17 18:35 dbus-org.freedesktop.timedate1.service 
> -> /usr/lib/systemd/system/dbus-org.freedesktop.timedate1.service
> lrwxrwxrwx 1 root root 38 Dec 17 18:35 procps.service -> 
> /usr/lib/systemd/system/procps.service
> lrwxrwxrwx 1 root root 40 Dec 17 18:35 runlevel3.target -> 
> /usr/lib/systemd/system/runlevel3.target
> 
> lrwxrwxrwx 1 root root 25 Nov 30 13:38 
> dbus-org.freedesktop.hostname1.service.usrmerge-broken -> 
> systemd-hostnamed.service
> lrwxrwxrwx 1 root root 22 Nov 30 13:38 
> dbus-org.freedesktop.login1.service.usrmerge-broken -> systemd-logind.service
> lrwxrwxrwx 1 root root 25 Nov 30 13:38 
> dbus-org.freedesktop.timedate1.service.usrmerge-broken -> 
> systemd-timedated.service
> lrwxrwxrwx 1 root root 22 Nov 30 13:38 procps.service.usrmerge-broken -> 
> systemd-sysctl.service
> lrwxrwxrwx 1 root root 17 Nov 30 13:38 runlevel3.target.usrmerge-broken -> 
> multi-user.target
> 
> Can't really tell what the state before was, though.

Marco, can you comment please? To me this looks like working as designed.


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature

Bug#848504: usrmerge breaks various systemd symlinks

[Christian Hofstaedtler]

Package: systemd
Version: 232-7

usrmerge reports that various symlinks installed by systemd are "broken"
and cannot be properly converted:

WARNING: /usr/lib/systemd/system/dbus-org.freedesktop.login1.service is a 
broken symlink and has been renamed!
WARNING: /usr/lib/systemd/system/runlevel3.target is a broken symlink and has 
been renamed!
WARNING: /usr/lib/systemd/system/dbus-org.freedesktop.timedate1.service is a 
broken symlink and has been renamed!
WARNING: /usr/lib/systemd/system/dbus-org.freedesktop.hostname1.service is a 
broken symlink and has been renamed!
WARNING: /usr/lib/systemd/system/procps.service is a broken symlink and has 
been renamed!

ls -la (in /usr/lib/systemd/system/) after conversion:

lrwxrwxrwx 1 root root 62 Dec 17 18:35 dbus-org.freedesktop.hostname1.service 
-> /usr/lib/systemd/system/dbus-org.freedesktop.hostname1.service
lrwxrwxrwx 1 root root 59 Dec 17 18:35 dbus-org.freedesktop.login1.service -> 
/usr/lib/systemd/system/dbus-org.freedesktop.login1.service
lrwxrwxrwx 1 root root 62 Dec 17 18:35 dbus-org.freedesktop.timedate1.service 
-> /usr/lib/systemd/system/dbus-org.freedesktop.timedate1.service
lrwxrwxrwx 1 root root 38 Dec 17 18:35 procps.service -> 
/usr/lib/systemd/system/procps.service
lrwxrwxrwx 1 root root 40 Dec 17 18:35 runlevel3.target -> 
/usr/lib/systemd/system/runlevel3.target

lrwxrwxrwx 1 root root 25 Nov 30 13:38 
dbus-org.freedesktop.hostname1.service.usrmerge-broken -> 
systemd-hostnamed.service
lrwxrwxrwx 1 root root 22 Nov 30 13:38 
dbus-org.freedesktop.login1.service.usrmerge-broken -> systemd-logind.service
lrwxrwxrwx 1 root root 25 Nov 30 13:38 
dbus-org.freedesktop.timedate1.service.usrmerge-broken -> 
systemd-timedated.service
lrwxrwxrwx 1 root root 22 Nov 30 13:38 procps.service.usrmerge-broken -> 
systemd-sysctl.service
lrwxrwxrwx 1 root root 17 Nov 30 13:38 runlevel3.target.usrmerge-broken -> 
multi-user.target

Can't really tell what the state before was, though.

-- 
christian hofstaedtler