Bug#850776: zfs-auto-snapshot: cronjob exits with error after package removal

2018-12-07 Thread Andreas Beckmann 
Followup-For: Bug #850776

Hi,

I've just opened a stretch-pu request to fix this bug in stable, too:
https://bugs.debian.org/915935


Andreas
diff -Nru zfs-auto-snapshot-1.2.1/debian/changelog 
zfs-auto-snapshot-1.2.1/debian/changelog
--- zfs-auto-snapshot-1.2.1/debian/changelog2016-11-06 11:38:36.0 
+0100
+++ zfs-auto-snapshot-1.2.1/debian/changelog2018-12-08 00:45:54.0 
+0100
@@ -1,3 +1,10 @@
+zfs-auto-snapshot (1.2.1-1+deb9u1) stretch; urgency=medium
+
+  * Backported from 1.2.4:
+- Make cronjobs exit silently after package removal.  (Closes: #850776)
+
+ -- Andreas Beckmann   Sat, 08 Dec 2018 00:45:54 +0100
+
 zfs-auto-snapshot (1.2.1-1) unstable; urgency=medium
 
   * Initial release (Closes: #720657)
diff -Nru zfs-auto-snapshot-1.2.1/debian/patches/crontabs.patch 
zfs-auto-snapshot-1.2.1/debian/patches/crontabs.patch
--- zfs-auto-snapshot-1.2.1/debian/patches/crontabs.patch   1970-01-01 
01:00:00.0 +0100
+++ zfs-auto-snapshot-1.2.1/debian/patches/crontabs.patch   2018-12-08 
00:33:01.0 +0100
@@ -0,0 +1,48 @@
+diff -Nru zfs-auto-snapshot-1.2.1/etc/zfs-auto-snapshot.cron.daily 
zfs-auto-snapshot-1.2.4/etc/zfs-auto-snapshot.cron.daily
+--- zfs-auto-snapshot-1.2.1/etc/zfs-auto-snapshot.cron.daily   2014-10-14 
06:19:48.0 +0200
 zfs-auto-snapshot-1.2.4/etc/zfs-auto-snapshot.cron.daily   2017-09-18 
09:25:02.0 +0200
+@@ -1,2 +1,6 @@
+ #!/bin/sh
++
++# Only call zfs-auto-snapshot if it's available
++which zfs-auto-snapshot > /dev/null || exit 0
++
+ exec zfs-auto-snapshot --quiet --syslog --label=daily --keep=31 //
+diff -Nru zfs-auto-snapshot-1.2.1/etc/zfs-auto-snapshot.cron.frequent 
zfs-auto-snapshot-1.2.4/etc/zfs-auto-snapshot.cron.frequent
+--- zfs-auto-snapshot-1.2.1/etc/zfs-auto-snapshot.cron.frequent
2014-10-14 06:19:48.0 +0200
 zfs-auto-snapshot-1.2.4/etc/zfs-auto-snapshot.cron.frequent
2017-09-18 09:25:02.0 +0200
+@@ -1,3 +1,3 @@
+ PATH="/usr/bin:/bin:/usr/sbin:/sbin"
+ 
+-*/15 * * * * root zfs-auto-snapshot -q -g --label=frequent --keep=4  //
++*/15 * * * * root which zfs-auto-snapshot > /dev/null || exit 0 ; 
zfs-auto-snapshot --quiet --syslog --label=frequent --keep=4 //
+diff -Nru zfs-auto-snapshot-1.2.1/etc/zfs-auto-snapshot.cron.hourly 
zfs-auto-snapshot-1.2.4/etc/zfs-auto-snapshot.cron.hourly
+--- zfs-auto-snapshot-1.2.1/etc/zfs-auto-snapshot.cron.hourly  2014-10-14 
06:19:48.0 +0200
 zfs-auto-snapshot-1.2.4/etc/zfs-auto-snapshot.cron.hourly  2017-09-18 
09:25:02.0 +0200
+@@ -1,2 +1,6 @@
+ #!/bin/sh
++
++# Only call zfs-auto-snapshot if it's available
++which zfs-auto-snapshot > /dev/null || exit 0
++
+ exec zfs-auto-snapshot --quiet --syslog --label=hourly --keep=24 //
+diff -Nru zfs-auto-snapshot-1.2.1/etc/zfs-auto-snapshot.cron.monthly 
zfs-auto-snapshot-1.2.4/etc/zfs-auto-snapshot.cron.monthly
+--- zfs-auto-snapshot-1.2.1/etc/zfs-auto-snapshot.cron.monthly 2014-10-14 
06:19:48.0 +0200
 zfs-auto-snapshot-1.2.4/etc/zfs-auto-snapshot.cron.monthly 2017-09-18 
09:25:02.0 +0200
+@@ -1,2 +1,6 @@
+ #!/bin/sh
++
++# Only call zfs-auto-snapshot if it's available
++which zfs-auto-snapshot > /dev/null || exit 0
++
+ exec zfs-auto-snapshot --quiet --syslog --label=monthly --keep=12 //
+diff -Nru zfs-auto-snapshot-1.2.1/etc/zfs-auto-snapshot.cron.weekly 
zfs-auto-snapshot-1.2.4/etc/zfs-auto-snapshot.cron.weekly
+--- zfs-auto-snapshot-1.2.1/etc/zfs-auto-snapshot.cron.weekly  2014-10-14 
06:19:48.0 +0200
 zfs-auto-snapshot-1.2.4/etc/zfs-auto-snapshot.cron.weekly  2017-09-18 
09:25:02.0 +0200
+@@ -1,2 +1,6 @@
+ #!/bin/sh
++
++# Only call zfs-auto-snapshot if it's available
++which zfs-auto-snapshot > /dev/null || exit 0
++
+ exec zfs-auto-snapshot --quiet --syslog --label=weekly --keep=8 //
diff -Nru zfs-auto-snapshot-1.2.1/debian/patches/series 
zfs-auto-snapshot-1.2.1/debian/patches/series
--- zfs-auto-snapshot-1.2.1/debian/patches/series   1970-01-01 
01:00:00.0 +0100
+++ zfs-auto-snapshot-1.2.1/debian/patches/series   2018-12-08 
00:45:50.0 +0100
@@ -0,0 +1 @@
+crontabs.patch

Bug#850776: zfs-auto-snapshot: cronjob exits with error after package removal

2017-07-01 Thread Andreas Beckmann 
Followup-For: Bug #850776
Control: found -1 1.2.2-1

Hi,

the cronjob still fails, but differently and without producing output:

0m41.9s DEBUG: Starting command: ['chroot', '/srv/piuparts/tmp/tmp6wWS_B', 
'/etc/cron.daily/zfs-auto-snapshot']
0m41.9s ERROR: Command failed (status=1): ['chroot', 
'/srv/piuparts/tmp/tmp6wWS_B', '/etc/cron.daily/zfs-auto-snapshot']


Andreas


zfs-auto-snapshot_1.2.2-1.log.gz
Description: application/gzip

Bug#850776: zfs-auto-snapshot: cronjob exits with error after package removal

2017-01-09 Thread Andreas Beckmann 
Package: zfs-auto-snapshot
Version: 1.2.1-1
Severity: important
User: debian...@lists.debian.org
Usertags: piuparts

Hi,

during a test with piuparts I noticed your packages cronjob exits with
error after the package has been removed.

>From the attached log (scroll to the bottom...):

1m6.2s DEBUG: Starting command: ['chroot', '/tmp/piupartss/tmpXPG5CS', 
'/etc/cron.daily/zfs-auto-snapshot']
1m6.2s DUMP: 
  /etc/cron.daily/zfs-auto-snapshot: 2: exec: zfs-auto-snapshot: not found
1m6.2s ERROR: Command failed (status=127): ['chroot', 
'/tmp/piupartss/tmpXPG5CS', '/etc/cron.daily/zfs-auto-snapshot']


cheers,

Andreas


zfs-auto-snapshot_1.2.1-1.log.gz
Description: application/gzip