Control: tag -1 + pending Hi Bas,
Joost van Baal-Ilić wrote on 4th of October 2017: > Have verified package builds succesfully with gcc-7 in current sid chroot. Thanks a lot, Joost! > Made another house-keeping change, updated debdiff attached. Unfortunately that debdiff seems incomplete: * No debian/patches/series file needed for source format '3.0 (quilt)'. * debian/rules still contains a patch target which calls dpatch. * Patches are still in dpatch format, including the new one. Since pinfo already has been autoremoved from Testing quite a while ago, I've uploaded an NMU to DELAYED/5. It's based on Joost's original and minimal NMU patch. See my full debdiff at the end of this mail. Bas: I'd really prefer if you could declare a new upstream release and upload that one instead of my NMU. Hence I uploaded to DELAYED/5 despite the age of the RC bug would easily validate a direct NMU without any delay. You seem to keep pinfo uptodate upstream, even made a new upstream release 7 years ago and fixed this bug in your GitHub repository several months ago. But you never uploaded that new upstream release to Debian, nor did you upload the committed RC fix to Debian. Why? You seem to be otherwise active in Debian, e.g. in the BTS… So please, do a new upstream release and upload that one to Debian Unstable. If you prefer, I can also delay this NMU longer. Just tell me to do so. diff -u pinfo-0.6.9/debian/changelog pinfo-0.6.9/debian/changelog --- pinfo-0.6.9/debian/changelog +++ pinfo-0.6.9/debian/changelog @@ -1,3 +1,19 @@ +pinfo (0.6.9-5.2) unstable; urgency=low + + [ Joost van Baal-Ilić ] + * Get rid of undefined references to inline functions when compiling + with gcc-7 using -Os by first declaring these 3 functions without + using the inline keyword. Thanks Matthias Klose for reporting, + Adrian Bunk for writing a test case and Jakub Jelinek for pointing + the way to a fix in + https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81734#c3. + (Closes: #853613) [06_gcc_7_Os_inline_functions.dpatch] + + [ Axel Beckert ] + * Non-maintainer upload. + + -- Axel Beckert <a...@debian.org> Wed, 15 Nov 2017 02:47:08 +0100 + pinfo (0.6.9-5.1) unstable; urgency=low * NMU diff -u pinfo-0.6.9/debian/patches/00list pinfo-0.6.9/debian/patches/00list --- pinfo-0.6.9/debian/patches/00list +++ pinfo-0.6.9/debian/patches/00list @@ -5,0 +6 @@ +06_gcc_7_Os_inline_functions.dpatch only in patch2: unchanged: --- pinfo-0.6.9.orig/debian/patches/06_gcc_7_Os_inline_functions.dpatch +++ pinfo-0.6.9/debian/patches/06_gcc_7_Os_inline_functions.dpatch @@ -0,0 +1,40 @@ +#! /bin/sh /usr/share/dpatch/dpatch-run +## 06_gcc_7_Os_inline_functions.dpatch by Joost van Baal-Ilić <joos...@debian.org> +## +## All lines beginning with `## DP:' are a description of the patch. +## DP: Get rid of undefined references to inline functions when compiling +## DP: with gcc-7 using -Os by first declaring these 3 functions without +## DP: using the inline keyword. +## DP: Thanks Matthias Klose for reporting, Adrian Bunk for writing a test +## DP: case and Jakub Jelinek for pointing the way to a fix. + +@DPATCH@ + +--- pinfo-0.6.9/src/initializelinks.c 2006-03-15 22:54:56.000000000 +0100 ++++ pinfo-0.6.9/src/initializelinks.c 2017-10-04 04:37:18.782964086 +0200 +@@ -75,6 +75,7 @@ + * checks if an item belongs to tag table. returns 1 on success and 0 on + * failure. It should be optimised... + */ ++extern int exists_in_tag_table(char *item); + inline int + exists_in_tag_table(char *item) + { +--- pinfo-0.6.9/src/filehandling_functions.c 2006-03-16 16:15:02.000000000 +0100 ++++ pinfo-0.6.9/src/filehandling_functions.c 2017-10-04 04:37:59.519976805 +0200 +@@ -551,6 +551,7 @@ + return 1; + } + ++extern void buildcommand(char *dest, char *command, char *filename, const char *tmpfilename); + inline void + buildcommand(char *dest, char *command, char *filename, const char *tmpfilename) + { +@@ -561,6 +562,7 @@ + strcat(dest, tmpfilename); + } + ++extern void builddircommand(char *dest, char *command, char *filename, const char *tmpfilename); + inline void + builddircommand(char *dest, char *command, char *filename, const char *tmpfilename) + { Regards, Axel -- ,''`. | Axel Beckert <a...@debian.org>, https://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
signature.asc
Description: Digital signature
