Bug#853886: cowbuilder: doesn't create _amd64.changes for binary-indep-only or source-only builds

[Mattia Rizzolo]

On Thu, Feb 23, 2017 at 10:54:04PM +, James Clarke wrote:
> On 23 Feb 2017, at 22:51, Thorsten Glaser  wrote:
> > This is actually required; uploading it as _amd64.changes will
> > prevent the buildds from uploading amd64 binaries, as the changes
> > file will already be present in the distribution. (BTDT, oops.)
> 
> Maybe that used to be true, but it definitely isn't any more.

It is still true, but *only* when uploading to a policy queue (most
relevantly, it happens frequently with people uploading to p-u).
For the other suites, dak just appends a .1, .2, etc.

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#853886: cowbuilder: doesn't create _amd64.changes for binary-indep-only or source-only builds

[James Clarke]

On 23 Feb 2017, at 22:51, Thorsten Glaser  wrote:
> 
> James Clarke dixit:
> 
>> Why not use --source-only-changes and upload the _source.changes from
>> your final test binary build?
> 
> This is actually required; uploading it as _amd64.changes will
> prevent the buildds from uploading amd64 binaries, as the changes
> file will already be present in the distribution. (BTDT, oops.)

Maybe that used to be true, but it definitely isn't any more.

Regards,
James

Bug#853886: cowbuilder: doesn't create _amd64.changes for binary-indep-only or source-only builds

[Thorsten Glaser]

James Clarke dixit:

>Why not use --source-only-changes and upload the _source.changes from
>your final test binary build?

This is actually required; uploading it as _amd64.changes will
prevent the buildds from uploading amd64 binaries, as the changes
file will already be present in the distribution. (BTDT, oops.)

bye,
//mirabilos
-- 
Stéphane, I actually don’t block Googlemail, they’re just too utterly
stupid to successfully deliver to me (or anyone else using Greylisting
and not whitelisting their ranges). Same for a few other providers such
as Hotmail. Some spammers (Yahoo) I do block.

Bug#853886: cowbuilder: doesn't create _amd64.changes for binary-indep-only or source-only builds

[James Clarke]

On 23 Feb 2017, at 16:04, Andreas Beckmann  wrote:
> On Wed, 1 Feb 2017 19:42:26 + James Clarke  wrote:
>> For source-only builds, I don't understand why you would want to perform the
>> build in a chroot. You already have to be able to build the source package
>> outside the chroot, which then gets copied into the chroot, unpacked and a 
>> new
>> source package is built; why not use the first source package? If your aim is
> 
> I want to build the source package in the distro where it's going to be
> uploaded, using tools from only that distro. This may make a difference
> if I get a .debian.tar.gz or .debian.tar.xz (or .diff.gz vs. .diff.xz ?).
> And I want to build the source package in a clean minimal chroot, not
> upload something built in my non-minimal mixed-distro host :-)
> 
> So far I always used --debbuildopts -S for a final source-only build
> that was going to be uploaded (after doing testing binary builds).

Why not use --source-only-changes and upload the _source.changes from
your final test binary build?

> --binary-indep is not working as a "workaround" if the package builds no
> arch:all packages.

Regards,
James

Bug#853886: cowbuilder: doesn't create _amd64.changes for binary-indep-only or source-only builds

[Andreas Beckmann]

On Wed, 1 Feb 2017 19:42:26 + James Clarke  wrote:
> For source-only builds, I don't understand why you would want to perform the
> build in a chroot. You already have to be able to build the source package
> outside the chroot, which then gets copied into the chroot, unpacked and a new
> source package is built; why not use the first source package? If your aim is

I want to build the source package in the distro where it's going to be
uploaded, using tools from only that distro. This may make a difference
if I get a .debian.tar.gz or .debian.tar.xz (or .diff.gz vs. .diff.xz ?).
And I want to build the source package in a clean minimal chroot, not
upload something built in my non-minimal mixed-distro host :-)

So far I always used --debbuildopts -S for a final source-only build
that was going to be uploaded (after doing testing binary builds).

--binary-indep is not working as a "workaround" if the package builds no
arch:all packages.


Andreas

Bug#853886: cowbuilder: doesn't create _amd64.changes for binary-indep-only or source-only builds

[James Clarke]

Control: reassign -1 pbuilder
Control: tags -1 wontfix
Control: retitle -1 pbuilder: Does not parse DEBBUILDOPTS to determine build 
type

Hi,

> On 1 Feb 2017, at 19:26, Jens Reyer  wrote:
> 
> after the recent cowbuilder update my gbp build script started to fail
> for binary-indep-only (-A) and source-only builds (-S), complaining
> about a missing *_amd64.changes file (see log below).

This hasn't changed in cowbuilder, but pbuilder has changed.

> I assume the recent changes in cowbuilder cause this, but I'm not
> totally sure about that.  I also failed to find information what the
> arch in the .changes file must be.  I assume it's the host arch.
> Otherwise I'd say git-pbuilder is looking for the wrong file.

For source-only builds, I don't understand why you would want to perform the
build in a chroot. You already have to be able to build the source package
outside the chroot, which then gets copied into the chroot, unpacked and a new
source package is built; why not use the first source package? If your aim is
to check the package builds, you're not actually building any binary packages;
you should instead use the new --source-only-changes option, which will build
binary packages but also generate a source-only changes.

For binary-indep-only, I assume you are using -A, which git-pbuilder sees as a
dpkg-buildpackage option and passes on to cowbuilder via --debbuildopts.
However, cowbuilder/pbuilder do not look at debbuildopts to determine what kind
of build is being done; they have their own flags. Please use
--binary-arch/--binary-indep as per the pbuilder man page (you may need to use
--git-pbuilder-options=--binary-indep to get it passed through properly).

> Personally I see this as rc bug, but that's your call.

The source-only case came up recently and it was deemed that we will not fix
it, and I think the same will be true of binary-indep builds via
--debbuildopts, but Mattia has final say regarding that.

> Thanks for taking care of cowbuilder!

Thanks for using cowbuilder!

James

Bug#853886: cowbuilder: doesn't create _amd64.changes for binary-indep-only or source-only builds

[Jens Reyer]

Package: cowbuilder
Version: 0.84
Severity: important


Hi,

after the recent cowbuilder update my gbp build script started to fail
for binary-indep-only (-A) and source-only builds (-S), complaining
about a missing *_amd64.changes file (see log below).

I assume the recent changes in cowbuilder cause this, but I'm not
totally sure about that.  I also failed to find information what the
arch in the .changes file must be.  I assume it's the host arch.
Otherwise I'd say git-pbuilder is looking for the wrong file.

Personally I see this as rc bug, but that's your call.

Thanks for taking care of cowbuilder!
Greets
jre


$ gbp buildpackage --git-pbuilder --git-arch=amd64 --git-dist=sid
--git-upstream-tag="wine-%(version)s" -S
gbp:info: Building with (cowbuilder) for sid:amd64
Building with cowbuilder for distribution sid, architecture amd64
+ pdebuild --buildresult ../ --pbuilder cowbuilder --debbuildopts '
'\''-S'\''' -- --architecture amd64 --basepath /home//base-sid-amd64.cow
I: using cowbuilder as pbuilder
[...]
make[1]: Leaving directory '/build/wine-development-2.0'
 dpkg-source -b wine-development-2.0
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building wine-development using existing
./wine-development_2.0.orig.tar.xz
dpkg-source: info: building wine-development in
wine-development_2.0-3.debian.tar.xz
dpkg-source: info: building wine-development in wine-development_2.0-3.dsc
 dpkg-genbuildinfo --build=source
 dpkg-genchanges --build=source >../wine-development_2.0-3_source.changes
dpkg-genchanges: info: not including original source code in upload
 dpkg-source --after-build wine-development-2.0
dpkg-buildpackage: info: binary and diff upload (original source NOT
included)
I: copying local configuration
E: Missing changes file:
/home/build/cow.29103/build/wine-development_2.0-3_amd64.changes
I: unmounting /home/ccache filesystem
I: unmounting dev/pts filesystem
I: unmounting dev/shm filesystem
I: unmounting proc filesystem
I: unmounting sys filesystem
I: Cleaning COW directory
I: forking: rm -rf /home/build/cow.29103
gbp:error: 'git-pbuilder -S' failed: it exited with 1




-- Manually added:
ii  git-buildpackage  0.8.12.1

-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500,
'testing-debug'), (500, 'unstable'), (100, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages cowbuilder depends on:
ii  cowdancer0.84
ii  libc62.24-9
ii  libncurses5  6.0+20161126-1
ii  libtinfo56.0+20161126-1
ii  pbuilder 0.228.3

cowbuilder recommends no packages.

cowbuilder suggests no packages.

-- no debconf information