Bug#855824: unblock: multipath-tools/0.6.4-4

[Ritesh Raj Sarraf]

On Sat, 2017-04-01 at 01:23 +0200, Cyril Brulebois wrote:
> Ritesh Raj Sarraf  (2017-03-25):
> > While you are at it, please consider unblocking version 0.6.4-5
> > The debdiff is attached. The changes include shipping udev rules files,
> which
> > mistakenly was dropped out, some time last year.
> > 
> > unblock multipath-tools/0.6.4-5
> 
> Looking at the two separate diffs, no obvious objections.
> 

Thank you very much. 

> I'm a bit astonished by the hardcoded library in Depends field (libaio1),
> spotted in the diff for the udev version bump. Possibly needed because of
> the static stuff fixed in 2007? In which case letting shlibs:Depends compute
> a proper version should be sufficient nowadays (can wait until the buster
> release cycle is open though).

Thanks for noticing that. I'll investigate and target that fix for Buster.

-- 
Ritesh Raj Sarraf | http://people.debian.org/~rrs
Debian - The Universal Operating System

signature.asc
Description: This is a digitally signed message part

Bug#855824: unblock: multipath-tools/0.6.4-4

[Cyril Brulebois]

Ritesh Raj Sarraf  (2017-03-25):
> While you are at it, please consider unblocking version 0.6.4-5
> The debdiff is attached. The changes include shipping udev rules files, which
> mistakenly was dropped out, some time last year.
> 
> unblock multipath-tools/0.6.4-5

Looking at the two separate diffs, no obvious objections.

I'm a bit astonished by the hardcoded library in Depends field (libaio1),
spotted in the diff for the udev version bump. Possibly needed because of
the static stuff fixed in 2007? In which case letting shlibs:Depends compute
a proper version should be sufficient nowadays (can wait until the buster
release cycle is open though).


KiBi.


signature.asc
Description: Digital signature

Bug#855824: unblock: multipath-tools/0.6.4-4

[Cyril Brulebois]

Cyril Brulebois  (2017-04-01):
> OK, thanks for your feedback. Niels, let's merge this and see what other
> bits might be missing/need fixing after that? multipath support has been
> sketchy at best AFAICT, so we're not really regressing here (I think)…

I've just merged the long standing grub-installer patch as well. Feel
free to unblock/unblock-udeb it as well. I've only quickly glanced at
Ubuntu's grub-installer package, which has more PReP changes, but I'm
probably not going to try and merge that right now, since I've no such
HW and no relevant knowledge…


KiBi.


signature.asc
Description: Digital signature

Bug#855824: unblock: multipath-tools/0.6.4-4

[Cyril Brulebois]

Allan Jacobsen  (2017-03-20):
> Sorry for my slow responce on this.
> 
> I worked on this the last week of february, but was not able to get it
> to work reliably.
> 
> I think i made 20-30 installs on jessie, that I upgraded to stretch,
> and only one time i got multipath to work, and after a reboot it was
> gone again.
> 
> The patch it OK, but it is in other packages that some things are
> missing, but unfortunatly my work at the company stopped on 28/2, so I
> no longer have access to hardware to test on.

OK, thanks for your feedback. Niels, let's merge this and see what other
bits might be missing/need fixing after that? multipath support has been
sketchy at best AFAICT, so we're not really regressing here (I think)…


KiBi.


signature.asc
Description: Digital signature

Bug#855824: unblock: multipath-tools/0.6.4-4

[Ritesh Raj Sarraf]

While you are at it, please consider unblocking version 0.6.4-5
The debdiff is attached. The changes include shipping udev rules files, which
mistakenly was dropped out, some time last year.

unblock multipath-tools/0.6.4-5

Thanks,
Ritesh


On Fri, 2017-02-24 at 07:13 +, Niels Thykier wrote:
> Control: tags -1 confirmed
> 
> Ritesh Raj Sarraf:
> > Package: release.debian.org
> > Severity: normal
> > User: release.debian@packages.debian.org
> > Usertags: unblock
> > 
> > Please unblock package multipath-tools
> > 
> > These are minor changes, which should qualify for an upload exception. The
> > new
> > file additions are mostly autopkg tests related, which have no impact on the
> > software. The other changes are good to have for Stretch.
> > 
> > 
> > 
> > [...]
> 
> Ok with me. KiBi, is this upload ok for d-i?
> 
> Thanks,
> ~Niels
> 
> 
-- 
Ritesh Raj Sarraf | http://people.debian.org/~rrs
Debian - The Universal Operating Systemdiff -Nru multipath-tools-0.6.4/debian/changelog multipath-tools-0.6.4/debian/changelog
--- multipath-tools-0.6.4/debian/changelog	2017-02-20 19:36:31.0 +0530
+++ multipath-tools-0.6.4/debian/changelog	2017-03-25 15:03:08.0 +0530
@@ -1,3 +1,10 @@
+multipath-tools (0.6.4-5) unstable; urgency=medium
+
+  * Ship multipath udev rules (Closes: #858456)
+  * Define some priority for rules processing
+
+ -- Ritesh Raj Sarraf   Sat, 25 Mar 2017 15:03:08 +0530
+
 multipath-tools (0.6.4-4) unstable; urgency=medium
 
   [ Ritesh Raj Sarraf ]
diff -Nru multipath-tools-0.6.4/debian/rules multipath-tools-0.6.4/debian/rules
--- multipath-tools-0.6.4/debian/rules	2016-12-09 15:20:32.0 +0530
+++ multipath-tools-0.6.4/debian/rules	2017-03-24 18:30:22.0 +0530
@@ -35,6 +35,8 @@
 	dh_testdir
 	
 	[ ! -f kpartx/kpartx.rules ] || cp kpartx/kpartx.rules debian/kpartx.udev
+	[ ! -f multipath/multipath.rules ] || cp multipath/multipath.rules debian/multipath.udev
+	[ ! -f multipath/11-dm-mpath.rules ] || cp multipath/11-dm-mpath.rules debian/dm-mpath.udev
 
 	dh_auto_build -- $(OPTFLAGS) LIB=/lib SYSTEMDPATH=/lib USE_SYSTEMD=1 USE_RADOS=1
 
@@ -127,6 +129,7 @@
 	dh_installinit -pmultipath-tools
 	dh_installudev -pkpartx
 	dh_installudev -pmultipath-tools --name=multipath
+	dh_installudev -pmultipath-tools --name=dm-mpath --priority=11
 	dh_link -a lib/systemd/system/multipathd.service \
 		lib/systemd/system/multipath-tools.service
 	dh_systemd_start -pmultipath-tools multipathd.service


signature.asc
Description: This is a digitally signed message part

Bug#855824: unblock: multipath-tools/0.6.4-4

[Allan Jacobsen]

Den 04/03/2017 kl. 10.05 skrev Niels Thykier:
> Cyril Brulebois:
>> Hi,
>>
>> Niels Thykier  (2017-02-24):
>>> Ritesh Raj Sarraf:
 Package: release.debian.org
 Severity: normal
 User: release.debian@packages.debian.org
 Usertags: unblock

 Please unblock package multipath-tools

 These are minor changes, which should qualify for an upload exception. The 
 new
 file additions are mostly autopkg tests related, which have no impact on 
 the
 software. The other changes are good to have for Stretch.

 unblock multipath-tools/0.6.4-4

 [...]
>>>
>>> Ok with me. KiBi, is this upload ok for d-i?
>>
>> I think so. I've spent a little time on multipath fixes a few days ago, and
>> Mathieu mentioned a few more fixes being needed in d-i anyway. Adding him,
>> along with Allan who submitted patches and reports to let them know about
>> these possible extra changes in multipath-tools. Might be worth waiting a
>> bit for their feedback.
>>
>>
>> KiBi.
>>
> 
> Hi Allan and Mathieu,
> 
> Did you have any feedback ?
> 
> Thanks,
> ~Niels
> 
Sorry for my slow responce on this.

I worked on this the last week of february, but was not able to get it to work 
reliably.

I think i made 20-30 installs on jessie, that I upgraded to stretch, and only 
one time i got multipath to work, and after a reboot it was gone again.

The patch it OK, but it is in other packages that some things are missing, but 
unfortunatly my work at the company stopped on 28/2, so I no longer have access 
to hardware to test on.

Best regards
Allan

Bug#855824: unblock: multipath-tools/0.6.4-4

[Niels Thykier]

Cyril Brulebois:
> Hi,
> 
> Niels Thykier  (2017-02-24):
>> Ritesh Raj Sarraf:
>>> Package: release.debian.org
>>> Severity: normal
>>> User: release.debian@packages.debian.org
>>> Usertags: unblock
>>>
>>> Please unblock package multipath-tools
>>>
>>> These are minor changes, which should qualify for an upload exception. The 
>>> new
>>> file additions are mostly autopkg tests related, which have no impact on the
>>> software. The other changes are good to have for Stretch.
>>>
>>> unblock multipath-tools/0.6.4-4
>>>
>>> [...]
>>
>> Ok with me. KiBi, is this upload ok for d-i?
> 
> I think so. I've spent a little time on multipath fixes a few days ago, and
> Mathieu mentioned a few more fixes being needed in d-i anyway. Adding him,
> along with Allan who submitted patches and reports to let them know about
> these possible extra changes in multipath-tools. Might be worth waiting a
> bit for their feedback.
> 
> 
> KiBi.
> 

Hi Allan and Mathieu,

Did you have any feedback ?

Thanks,
~Niels

Bug#855824: unblock: multipath-tools/0.6.4-4

[Cyril Brulebois]

Hi,

Niels Thykier  (2017-02-24):
> Ritesh Raj Sarraf:
> > Package: release.debian.org
> > Severity: normal
> > User: release.debian@packages.debian.org
> > Usertags: unblock
> > 
> > Please unblock package multipath-tools
> > 
> > These are minor changes, which should qualify for an upload exception. The 
> > new
> > file additions are mostly autopkg tests related, which have no impact on the
> > software. The other changes are good to have for Stretch.
> > 
> > unblock multipath-tools/0.6.4-4
> > 
> > [...]
> 
> Ok with me. KiBi, is this upload ok for d-i?

I think so. I've spent a little time on multipath fixes a few days ago, and
Mathieu mentioned a few more fixes being needed in d-i anyway. Adding him,
along with Allan who submitted patches and reports to let them know about
these possible extra changes in multipath-tools. Might be worth waiting a
bit for their feedback.


KiBi.


signature.asc
Description: Digital signature

Bug#855824: unblock: multipath-tools/0.6.4-4

[Niels Thykier]

Control: tags -1 confirmed

Ritesh Raj Sarraf:
> Package: release.debian.org
> Severity: normal
> User: release.debian@packages.debian.org
> Usertags: unblock
> 
> Please unblock package multipath-tools
> 
> These are minor changes, which should qualify for an upload exception. The new
> file additions are mostly autopkg tests related, which have no impact on the
> software. The other changes are good to have for Stretch.
> 
> unblock multipath-tools/0.6.4-4
> 
> [...]

Ok with me. KiBi, is this upload ok for d-i?

Thanks,
~Niels

Bug#855824: unblock: multipath-tools/0.6.4-4

[Ritesh Raj Sarraf]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Please unblock package multipath-tools

These are minor changes, which should qualify for an upload exception. The new
file additions are mostly autopkg tests related, which have no impact on the
software. The other changes are good to have for Stretch.

unblock multipath-tools/0.6.4-4

-- System Information:
Debian Release: 9.0
  APT prefers unstable-debug
  APT policy: (990, 'unstable-debug'), (990, 'testing-debug'), (990, 
'unstable'), (990, 'testing'), (101, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.10.0+ (SMP w/4 CPU cores)
Locale: LANG=en_IN.utf8, LC_CTYPE=en_IN.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
 changelog  |   16 +++
 control|4 
 initramfs/hooks|2 
 initramfs/local-top|6 -
 tests/control  |8 +
 tests/kpartx-file-loopback |   51 +++
 tests/tgtbasedmpaths   |  204 +
 7 files changed, 285 insertions(+), 6 deletions(-)

diff -Nru multipath-tools-0.6.4/debian/changelog 
multipath-tools-0.6.4/debian/changelog
--- multipath-tools-0.6.4/debian/changelog  2017-01-25 14:58:53.0 
+0530
+++ multipath-tools-0.6.4/debian/changelog  2017-02-20 19:36:31.0 
+0530
@@ -1,3 +1,19 @@
+multipath-tools (0.6.4-4) unstable; urgency=medium
+
+  [ Ritesh Raj Sarraf ]
+  * [65ba796] Fix path for udevadm, which now resides in /bin.
+Thanks to Michael Biebl (Closes: #852586)
+  * [5291947] Drop non-existent dm-emc module and include
+dm-round-robin, in initramfs.
+Thanks to Allan Jacobsen (Closes: #855585)
+
+  [ Christian Ehrhardt ]
+  * [6159c78] debian/control: Bump to an updated udev dependency
+  * [8649315] debian/tests/kpartx-file-loopback: test kpartx
+  * [137dcc1] add Test using tgt and open-iscsi
+
+ -- Ritesh Raj Sarraf   Mon, 20 Feb 2017 19:36:31 +0530
+
 multipath-tools (0.6.4-3) unstable; urgency=medium
 
   * [3eecdba] Include libmpathcmd.so in the udeb package.
diff -Nru multipath-tools-0.6.4/debian/control 
multipath-tools-0.6.4/debian/control
--- multipath-tools-0.6.4/debian/control2017-01-23 16:51:48.0 
+0530
+++ multipath-tools-0.6.4/debian/control2017-02-20 19:36:31.0 
+0530
@@ -11,7 +11,7 @@
 
 Package: multipath-tools
 Architecture: linux-any
-Depends: ${shlibs:Depends}, ${misc:Depends}, udev (>= 0.124), kpartx (>= 
${binary:Version}), lsb-base (>= 3.0-6), libaio1 (>= 0.3.106-8), sg3-utils-udev
+Depends: ${shlibs:Depends}, ${misc:Depends}, udev (>> 136-1), kpartx (>= 
${binary:Version}), lsb-base (>= 3.0-6), libaio1 (>= 0.3.106-8), sg3-utils-udev
 Breaks: multipath-tools-initramfs (<= 1.0.1),
  multipath-tools-boot (<= 0.4.8+git0.761c66f-2~)
 Suggests: multipath-tools-boot
@@ -24,7 +24,7 @@
 
 Package: kpartx
 Architecture: linux-any
-Depends: ${shlibs:Depends}, ${misc:Depends}, udev (>> 0.086), dmsetup (>= 
2:1.02.24)
+Depends: ${shlibs:Depends}, ${misc:Depends}, udev (>> 136-1), dmsetup (>= 
2:1.02.24)
 Replaces: multipath-tools (<< 0.4.7-3)
 Description: create device mappings for partitions
  Kpartx can be used to set up device mappings for the partitions of any
diff -Nru multipath-tools-0.6.4/debian/initramfs/hooks 
multipath-tools-0.6.4/debian/initramfs/hooks
--- multipath-tools-0.6.4/debian/initramfs/hooks2016-12-08 
23:56:02.0 +0530
+++ multipath-tools-0.6.4/debian/initramfs/hooks2017-02-20 
19:36:31.0 +0530
@@ -48,7 +48,7 @@
 [ -r /etc/multipath.conf ] && cp /etc/multipath.conf $DESTDIR/etc/
 add_bindings
 
-for x in dm-multipath dm-service-time dm-round-robin dm-emc; do
+for x in dm-multipath dm-service-time dm-round-robin; do
manual_add_modules ${x}
 done
 
diff -Nru multipath-tools-0.6.4/debian/initramfs/local-top 
multipath-tools-0.6.4/debian/initramfs/local-top
--- multipath-tools-0.6.4/debian/initramfs/local-top2016-12-08 
23:56:02.0 +0530
+++ multipath-tools-0.6.4/debian/initramfs/local-top2017-02-20 
19:36:31.0 +0530
@@ -26,7 +26,7 @@
 
 maybe_break pre-multipath
 VERBOSITY=0
-MP_MODULES="dm-multipath dm-emc"
+MP_MODULES="dm-multipath dm-round-robin"
 
 if [ ! -e /sbin/multipath ]; then
exit 0
@@ -50,8 +50,8 @@
 /sbin/dmsetup ls --target multipath --exec "/sbin/kpartx -a -p -part" 
>/dev/null
 fi
 
-if [ -x /sbin/udevadm ]; then
-/sbin/udevadm settle --timeout=10
+if [ -x /bin/udevadm ]; then
+/bin/udevadm settle --timeout=10
 fi
 
 maybe_break post-multipath
diff -Nru multipath-tools-0.6.4/debian/tests/control 
multipath-tools-0.6.4/debian/tests/control
--- multipath-tools-0.6.4/debian/tests/control  1970-01-01 05:30:00.0 
+0530
+++ multipath-tools-0.6.4/debian/tests/control  2017-02-20 19:36:31.0 
+0530
@@ -0,0 +1,8 @@
+
+Tests: kpartx-file-loopback