Bug#856455: munin: Zooming doesn't work

2017-03-01 Thread Steve Schnepp 
On Mar 1, 2017 10:56 AM, "Steve Schnepp"  wrote:

Hmmm... Seems the sec fix is faulty here.
The "if defined" should be replaced with a simple "if".


Actually that is not enough as introduces another, more subtle, bug :

you cannot force any value to 0 anymore.

I admit is it better than the 2 previous states but i cannot advocate to
deploy it.

Will emit a fix today :-(


Actually that still holds, as some more testing is being done.

Bug#856455: munin: Zooming doesn't work

2017-03-01 Thread Steve Schnepp 
Hmmm... Seems the sec fix is faulty here.
The "if defined" should be replaced with a simple "if".

Will emit a fix today :-(


On Wed, Mar 1, 2017 at 9:30 AM Christian Marillat 
wrote:

Package: munin
Version: 2.0.31-1
Severity: important

Dear Maintainer,

I don't know since when but zooming in graph doesn't work.

Apparently the guilty in an empty value for --upper-limit

I see in /var/log/munin/munin-cgi-graph.log

2017/03/01 09:16:21 [WARNING] Could not draw graph
"/var/lib/munin/cgi-tmp/munin-cgi-graph/
marillat.net/karl.marillat.net/diskstats_iops/mmcblk0-pinpoint=1485504486,1488355686.png?_limit=_limit=_x=800_y=400":
/var/lib/munin/cgi-tmp/munin-cgi-graph/
marillat.net/karl.marillat.net/diskstats_iops/mmcblk0-pinpoint=1485504486,1488355686.png?_limit=_limit=_x=800_y=400
2017/03/01

09:20:23 [RRD ERROR] Unable to graph /var/lib/munin/cgi-tmp/munin-cgi-graph/
marillat.net/karl.marillat.net/diskstats_iops/mmcblk0-pinpoint=1488247686,1488355686.png?_limit=_limit=_x=800_y=400
: option -u - Cannot convert '' to float
2017/03/01 09:20:23 [RRD ERROR] rrdtool 'graph'
'/var/lib/munin/cgi-tmp/munin-cgi-graph/
marillat.net/karl.marillat.net/diskstats_iops/mmcblk0-pinpoint=1488247686,1488355686.png?_limit=_limit=_x=800_y=400'
\
'--title' \
'IOs for /dev/mmcblk0 - from Tue Feb 28 03:08:06 2017 to Wed Mar  1
09:08:06 2017' \
'--start' \
'1488247686' \
'--end' \
'1488355686' \
'--base' \
'1000' \
'--vertical-label' \
'Units read (-) / write (+)' \
'--slope-mode' \
'--height' \
'400' \
'--width' \
'800' \
'--rigid' \
'--imgformat' \
'PNG' \
'--font' \
'DEFAULT:0:DejaVuSans,DejaVu Sans,DejaVu LGC Sans,Bitstream Vera
Sans' \
'--font' \
'LEGEND:7:DejaVuSansMono,DejaVu Sans Mono,DejaVu LGC Sans
Mono,Bitstream Vera Sans Mono,monospace' \
'--color' \
'BACK#F0F0F0' \
'--color' \
'FRAME#F0F0F0' \
'--color' \
'CANVAS#FF' \
'--color' \
'FONT#66' \
'--color' \
'AXIS#CFD6F8' \
'--color' \
'ARROW#CFD6F8' \
'--border' \
'0' \
'-W' \
'Munin 2.0.31-1' \
'DEF:aavgwrrqsz=/var/lib/munin/
marillat.net/karl.marillat.net-diskstats_iops-mmcblk0-avgwrrqsz-g.rrd:42:MAX'
\
'DEF:iavgwrrqsz=/var/lib/munin/
marillat.net/karl.marillat.net-diskstats_iops-mmcblk0-avgwrrqsz-g.rrd:42:MIN'
\
'DEF:gavgwrrqsz=/var/lib/munin/
marillat.net/karl.marillat.net-diskstats_iops-mmcblk0-avgwrrqsz-g.rrd:42:AVERAGE'
\
'DEF:aavgrdrqsz=/var/lib/munin/
marillat.net/karl.marillat.net-diskstats_iops-mmcblk0-avgrdrqsz-g.rrd:42:MAX'
\
'DEF:iavgrdrqsz=/var/lib/munin/
marillat.net/karl.marillat.net-diskstats_iops-mmcblk0-avgrdrqsz-g.rrd:42:MIN'
\
'DEF:gavgrdrqsz=/var/lib/munin/
marillat.net/karl.marillat.net-diskstats_iops-mmcblk0-avgrdrqsz-g.rrd:42:AVERAGE'
\
'DEF:awrio=/var/lib/munin/
marillat.net/karl.marillat.net-diskstats_iops-mmcblk0-wrio-g.rrd:42:MAX' \
'DEF:iwrio=/var/lib/munin/
marillat.net/karl.marillat.net-diskstats_iops-mmcblk0-wrio-g.rrd:42:MIN' \
'DEF:gwrio=/var/lib/munin/
marillat.net/karl.marillat.net-diskstats_iops-mmcblk0-wrio-g.rrd:42:AVERAGE'
\
'DEF:ardio=/var/lib/munin/
marillat.net/karl.marillat.net-diskstats_iops-mmcblk0-rdio-g.rrd:42:MAX' \
'DEF:irdio=/var/lib/munin/
marillat.net/karl.marillat.net-diskstats_iops-mmcblk0-rdio-g.rrd:42:MIN' \
'DEF:grdio=/var/lib/munin/
marillat.net/karl.marillat.net-diskstats_iops-mmcblk0-rdio-g.rrd:42:AVERAGE'
\
'CDEF:crdio=grdio' \
'CDEF:cwrio=gwrio' \
'COMMENT: ' \
'COMMENT:Cur (-/+)' \
'COMMENT:Min (-/+)' \
'COMMENT:Avg (-/+)' \
'COMMENT:Max (-/+) \j' \
'LINE1:gwrio#00CC00:IO/sec' \
'GPRINT:crdio:LAST:%6.2lf%s/\g' \
'GPRINT:cwrio:LAST:%6.2lf%s' \
'GPRINT:irdio:MIN:%6.2lf%s/\g' \
'GPRINT:iwrio:MIN:%6.2lf%s' \
'GPRINT:grdio:AVERAGE:%6.2lf%s/\g' \
'GPRINT:gwrio:AVERAGE:%6.2lf%s' \
'GPRINT:ardio:MAX:%6.2lf%s/\g' \
'GPRINT:awrio:MAX:%6.2lf%s\j' \
'CDEF:cavgrdrqsz=gavgrdrqsz' \
'CDEF:cavgwrrqsz=gavgwrrqsz' \
'LINE1:gavgwrrqsz#0066B3:Req Size (KB) ' \
'GPRINT:cavgrdrqsz:LAST:%6.2lf%s/\g' \
'GPRINT:cavgwrrqsz:LAST:%6.2lf%s' \
'GPRINT:iavgrdrqsz:MIN:%6.2lf%s/\g' \
'GPRINT:iavgwrrqsz:MIN:%6.2lf%s' \
'GPRINT:gavgrdrqsz:AVERAGE:%6.2lf%s/\g' \
'GPRINT:gavgwrrqsz:AVERAGE:%6.2lf%s' \
'GPRINT:aavgrdrqsz:MAX:%6.2lf%s/\g' \
'GPRINT:aavgwrrqsz:MAX:%6.2lf%s\j' \
'CDEF:re_zero=grdio,UN,0,0,IF' \
'CDEF:ngrdio=grdio,-1,*' \

Bug#856455: munin: Zooming doesn't work

2017-03-01 Thread Christian Marillat 
Package: munin
Version: 2.0.31-1
Severity: important

Dear Maintainer,

I don't know since when but zooming in graph doesn't work.

Apparently the guilty in an empty value for --upper-limit

I see in /var/log/munin/munin-cgi-graph.log

2017/03/01 09:16:21 [WARNING] Could not draw graph 
"/var/lib/munin/cgi-tmp/munin-cgi-graph/marillat.net/karl.marillat.net/diskstats_iops/mmcblk0-pinpoint=1485504486,1488355686.png?_limit=_limit=_x=800_y=400":
 
/var/lib/munin/cgi-tmp/munin-cgi-graph/marillat.net/karl.marillat.net/diskstats_iops/mmcblk0-pinpoint=1485504486,1488355686.png?_limit=_limit=_x=800_y=400
2017/03/01 09:20:23 [RRD ERROR] Unable to graph 
/var/lib/munin/cgi-tmp/munin-cgi-graph/marillat.net/karl.marillat.net/diskstats_iops/mmcblk0-pinpoint=1488247686,1488355686.png?_limit=_limit=_x=800_y=400
 : option -u - Cannot convert '' to float
2017/03/01 09:20:23 [RRD ERROR] rrdtool 'graph' 
'/var/lib/munin/cgi-tmp/munin-cgi-graph/marillat.net/karl.marillat.net/diskstats_iops/mmcblk0-pinpoint=1488247686,1488355686.png?_limit=_limit=_x=800_y=400'
 \
'--title' \
'IOs for /dev/mmcblk0 - from Tue Feb 28 03:08:06 2017 to Wed Mar  1 
09:08:06 2017' \
'--start' \
'1488247686' \
'--end' \
'1488355686' \
'--base' \
'1000' \
'--vertical-label' \
'Units read (-) / write (+)' \
'--slope-mode' \
'--height' \
'400' \
'--width' \
'800' \
'--rigid' \
'--imgformat' \
'PNG' \
'--font' \
'DEFAULT:0:DejaVuSans,DejaVu Sans,DejaVu LGC Sans,Bitstream Vera Sans' \
'--font' \
'LEGEND:7:DejaVuSansMono,DejaVu Sans Mono,DejaVu LGC Sans 
Mono,Bitstream Vera Sans Mono,monospace' \
'--color' \
'BACK#F0F0F0' \
'--color' \
'FRAME#F0F0F0' \
'--color' \
'CANVAS#FF' \
'--color' \
'FONT#66' \
'--color' \
'AXIS#CFD6F8' \
'--color' \
'ARROW#CFD6F8' \
'--border' \
'0' \
'-W' \
'Munin 2.0.31-1' \

'DEF:aavgwrrqsz=/var/lib/munin/marillat.net/karl.marillat.net-diskstats_iops-mmcblk0-avgwrrqsz-g.rrd:42:MAX'
 \

'DEF:iavgwrrqsz=/var/lib/munin/marillat.net/karl.marillat.net-diskstats_iops-mmcblk0-avgwrrqsz-g.rrd:42:MIN'
 \

'DEF:gavgwrrqsz=/var/lib/munin/marillat.net/karl.marillat.net-diskstats_iops-mmcblk0-avgwrrqsz-g.rrd:42:AVERAGE'
 \

'DEF:aavgrdrqsz=/var/lib/munin/marillat.net/karl.marillat.net-diskstats_iops-mmcblk0-avgrdrqsz-g.rrd:42:MAX'
 \

'DEF:iavgrdrqsz=/var/lib/munin/marillat.net/karl.marillat.net-diskstats_iops-mmcblk0-avgrdrqsz-g.rrd:42:MIN'
 \

'DEF:gavgrdrqsz=/var/lib/munin/marillat.net/karl.marillat.net-diskstats_iops-mmcblk0-avgrdrqsz-g.rrd:42:AVERAGE'
 \

'DEF:awrio=/var/lib/munin/marillat.net/karl.marillat.net-diskstats_iops-mmcblk0-wrio-g.rrd:42:MAX'
 \

'DEF:iwrio=/var/lib/munin/marillat.net/karl.marillat.net-diskstats_iops-mmcblk0-wrio-g.rrd:42:MIN'
 \

'DEF:gwrio=/var/lib/munin/marillat.net/karl.marillat.net-diskstats_iops-mmcblk0-wrio-g.rrd:42:AVERAGE'
 \

'DEF:ardio=/var/lib/munin/marillat.net/karl.marillat.net-diskstats_iops-mmcblk0-rdio-g.rrd:42:MAX'
 \

'DEF:irdio=/var/lib/munin/marillat.net/karl.marillat.net-diskstats_iops-mmcblk0-rdio-g.rrd:42:MIN'
 \

'DEF:grdio=/var/lib/munin/marillat.net/karl.marillat.net-diskstats_iops-mmcblk0-rdio-g.rrd:42:AVERAGE'
 \
'CDEF:crdio=grdio' \
'CDEF:cwrio=gwrio' \
'COMMENT: ' \
'COMMENT:Cur (-/+)' \
'COMMENT:Min (-/+)' \
'COMMENT:Avg (-/+)' \
'COMMENT:Max (-/+) \j' \
'LINE1:gwrio#00CC00:IO/sec' \
'GPRINT:crdio:LAST:%6.2lf%s/\g' \
'GPRINT:cwrio:LAST:%6.2lf%s' \
'GPRINT:irdio:MIN:%6.2lf%s/\g' \
'GPRINT:iwrio:MIN:%6.2lf%s' \
'GPRINT:grdio:AVERAGE:%6.2lf%s/\g' \
'GPRINT:gwrio:AVERAGE:%6.2lf%s' \
'GPRINT:ardio:MAX:%6.2lf%s/\g' \
'GPRINT:awrio:MAX:%6.2lf%s\j' \
'CDEF:cavgrdrqsz=gavgrdrqsz' \
'CDEF:cavgwrrqsz=gavgwrrqsz' \
'LINE1:gavgwrrqsz#0066B3:Req Size (KB) ' \
'GPRINT:cavgrdrqsz:LAST:%6.2lf%s/\g' \
'GPRINT:cavgwrrqsz:LAST:%6.2lf%s' \
'GPRINT:iavgrdrqsz:MIN:%6.2lf%s/\g' \
'GPRINT:iavgwrrqsz:MIN:%6.2lf%s' \
'GPRINT:gavgrdrqsz:AVERAGE:%6.2lf%s/\g' \
'GPRINT:gavgwrrqsz:AVERAGE:%6.2lf%s' \
'GPRINT:aavgrdrqsz:MAX:%6.2lf%s/\g' \
'GPRINT:aavgwrrqsz:MAX:%6.2lf%s\j' \
'CDEF:re_zero=grdio,UN,0,0,IF' \
'CDEF:ngrdio=grdio,-1,*' \
'LINE1:ngrdio#00CC00' \
'CDEF:ngavgrdrqsz=gavgrdrqsz,-1,*' \
'LINE1:ngavgrdrqsz#0066B3' \
'LINE1:re_zero#00' \
'VRULE:1488356407#99' \
'COMMENT:Last update\: Wed Mar  1 09\:20\:07 2017\r' \
'--upper-limit' \
'' \
'--lower-limit' \
''
-- System