Bug#856815: kodi FTBFS on Alpha due to Intel assembler that is easily worked around

[Michael Cree]

On Mon, Mar 13, 2017 at 09:04:15PM +0100, Bálint Réczey wrote:
> > kodi FTBFS on alpha due to Intel specific code [1].
> >
> > I attach a patch that enables generic code to be built rather
> > than Intel specific code and with that kodi builds to completion
> > on Alpha.
> 
> Can kodi run on any alpha machine?

Yes, it runs on my XP1000.  Admittedly it was skipping frames on a
standard definition MPEG file, which is interesting because this
machine can play such files without a problem, but on closer
inspection I see that pulseaudio is taking up over 30% CPU time.
If I could point kodi at alsa directly I expect it would work very
nicely.

> The kodi package is quite big. Would building the package worth it
> considering the space needed on snapshot.d.o, on mirrors, etc?

I presume that the managers of debian-ports have already considered
the space resources of the ports building the archive when they
accepted them into debian-ports.  There are some extremely big
packages already built on Alpha (webkit, libreoffice, etc.) and one
more should not be a problem.

Cheers
Michael.

Bug#856815: kodi FTBFS on Alpha due to Intel assembler that is easily worked around

[Bálint Réczey]

Control: tags -1 confirmed moreinfo

Hi Michael,

2017-03-05 2:29 GMT+01:00 Michael Cree :
> Source: kodi
> Version: 2:17.0+dfsg1-3
> Severity: wishlist
> Tags: patch
> User: debian-al...@lists.debian.org
> Usertags: alpha
>
> kodi FTBFS on alpha due to Intel specific code [1].
>
> I attach a patch that enables generic code to be built rather
> than Intel specific code and with that kodi builds to completion
> on Alpha.

Thanks!

I am generally happy to receive patches from porters and would be open
to accepting it, but before I do so I have two questions:

Can kodi run on any alpha machine?

The kodi package is quite big. Would building the package worth it
considering the space needed on snapshot.d.o, on mirrors, etc?

Cheers,
Balint

>
> Cheers
> Michael.
>
> [1] 
> https://buildd.debian.org/status/fetch.php?pkg=kodi=alpha=2%3A17.0%2Bdfsg1-3=1487892844=0

Bug#856815: kodi FTBFS on Alpha due to Intel assembler that is easily worked around

[Michael Cree]

Source: kodi
Version: 2:17.0+dfsg1-3
Severity: wishlist
Tags: patch
User: debian-al...@lists.debian.org
Usertags: alpha

kodi FTBFS on alpha due to Intel specific code [1].

I attach a patch that enables generic code to be built rather
than Intel specific code and with that kodi builds to completion
on Alpha.

Cheers
Michael.

[1] 
https://buildd.debian.org/status/fetch.php?pkg=kodi=alpha=2%3A17.0%2Bdfsg1-3=1487892844=0
Index: kodi-17.0+dfsg1/xbmc/cores/DllLoader/DllLoader.h
===
--- kodi-17.0+dfsg1.orig/xbmc/cores/DllLoader/DllLoader.h
+++ kodi-17.0+dfsg1/xbmc/cores/DllLoader/DllLoader.h
@@ -23,7 +23,7 @@
 #include "coffldr.h"
 #include "LibraryLoader.h"
 
-#if defined(__linux__) && !defined(__powerpc__) && !defined(__arm__) && !defined(__aarch64__) && !defined(__mips__) && !defined(__s390x__)
+#if defined(__linux__) && !defined(__powerpc__) && !defined(__arm__) && !defined(__aarch64__) && !defined(__mips__) && !defined(__s390x__) && !defined(__alpha__)
 #define USE_LDT_KEEPER
 #include "ldt_keeper.h"
 #endif
Index: kodi-17.0+dfsg1/xbmc/cores/DllLoader/ldt_keeper.c
===
--- kodi-17.0+dfsg1.orig/xbmc/cores/DllLoader/ldt_keeper.c
+++ kodi-17.0+dfsg1/xbmc/cores/DllLoader/ldt_keeper.c
@@ -19,7 +19,7 @@
  */
 
 //#ifndef __powerpc__
-#if !defined(__powerpc__) && !defined(__ppc__) && !defined(__arm__) && !defined(__aarch64__) && !defined(__mips__) && !defined(__s390x__)
+#if !defined(__powerpc__) && !defined(__ppc__) && !defined(__arm__) && !defined(__aarch64__) && !defined(__mips__) && !defined(__s390x__) && !defined(__alpha__)
 
 #include "ldt_keeper.h"
 
Index: kodi-17.0+dfsg1/xbmc/cores/VideoPlayer/VideoRenderers/LinuxRendererGL.h
===
--- kodi-17.0+dfsg1.orig/xbmc/cores/VideoPlayer/VideoRenderers/LinuxRendererGL.h
+++ kodi-17.0+dfsg1/xbmc/cores/VideoPlayer/VideoRenderers/LinuxRendererGL.h
@@ -293,7 +293,7 @@ protected:
 
 
 inline int NP2( unsigned x ) {
-#if defined(TARGET_POSIX) && !defined(__POWERPC__) && !defined(__PPC__) && !defined(__arm__) && !defined(__aarch64__) && !defined(__mips__) && !defined(__s390x__)
+#if defined(TARGET_POSIX) && !defined(__POWERPC__) && !defined(__PPC__) && !defined(__arm__) && !defined(__aarch64__) && !defined(__mips__) && !defined(__s390x__) && !defined(__alpha__)
   // If there are any issues compiling this, just append a ' && 0'
   // to the above to make it '#if defined(TARGET_POSIX) && 0'
 
Index: kodi-17.0+dfsg1/xbmc/threads/Atomics.cpp
===
--- kodi-17.0+dfsg1.orig/xbmc/threads/Atomics.cpp
+++ kodi-17.0+dfsg1/xbmc/threads/Atomics.cpp
@@ -106,7 +106,7 @@ long cas(volatile long *pAddr, long expe
 ///
 long long cas2(volatile long long* pAddr, long long expectedVal, long long swapVal)
 {
-#if defined(__ppc__) || defined(__powerpc__) || defined(__arm__) || defined(__aarch64__) || defined(__s390x__) // PowerPC and ARM
+#if defined(__ppc__) || defined(__powerpc__) || defined(__arm__) || defined(__aarch64__) || defined(__s390x__) || defined(__alpha__)// PowerPC and ARM
 // Not available/required
 // Hack to allow compilation
   throw "cas2 is not implemented";
Index: kodi-17.0+dfsg1/xbmc/threads/Atomics.h
===
--- kodi-17.0+dfsg1.orig/xbmc/threads/Atomics.h
+++ kodi-17.0+dfsg1/xbmc/threads/Atomics.h
@@ -22,7 +22,7 @@
 
 //! @todo Inline these methods
 long cas(volatile long *pAddr, long expectedVal, long swapVal);
-#if !defined(__ppc__) && !defined(__powerpc__) && !defined(__arm__) && !defined(__s390x__)
+#if !defined(__ppc__) && !defined(__powerpc__) && !defined(__arm__) && !defined(__s390x__) && !defined(__alpha__)
 long long cas2(volatile long long* pAddr, long long expectedVal, long long swapVal);
 #endif
 long AtomicIncrement(volatile long* pAddr);
Index: kodi-17.0+dfsg1/xbmc/utils/MathUtils.h
===
--- kodi-17.0+dfsg1.orig/xbmc/utils/MathUtils.h
+++ kodi-17.0+dfsg1/xbmc/utils/MathUtils.h
@@ -37,7 +37,8 @@
 defined(__mips__) || \
 defined(__arm__) || \
 defined(__s390x__) || \
-defined(__aarch64__)
+defined(__aarch64__) || \
+defined(__alpha__)
   #define DISABLE_MATHUTILS_ASM_ROUND_INT
 #endif