Bug#857953: bash: debian/rules execute $(STRIP) even when empty

[Tim Rühsen]

On Donnerstag, 16. März 2017 17:26:23 CET Matthias Klose wrote:

> please read about bug severities.

This bugs renders the source package unusable for me.
That's what reportbug suggests 'important' for ("...major effect on the 
usability...")
And I need the source package to create a .deb with debugging symbols, for 
debugging #849517, to get gnulib's --enable-valgrind-tests working with 
several other packages.
So this bug is certainly a blocker...

> This works by default as seen by the latest binNMU.

???
This is not obvious for everybody. Just checked the bash package versions for 
unstable and experimental... no update yet.
So, what do you try to communicate here ? Is my Debian apt source  (http://
ftp.de.debian.org) somewhat behind ?

With Best Regards, Tim


signature.asc
Description: This is a digitally signed message part.

Bug#857953: bash: debian/rules execute $(STRIP) even when empty

[Matthias Klose]

Control: severity -1 normal

On 16.03.2017 17:13, Tim Ruehsen wrote:
> Package: bash
> Version: 4.4-4+b1
> Severity: serious
> Justification: fails to build from source (but built successfully in the past)
> 
> Dear Maintainer,
> 
> in debian/rules the $(STRIP) command is tried to be executed even when empty.
> 
> The code is
> ifneq (,$(findstring nostrip,$(DEB_BUILD_OPTIONS)))
>   ifneq ($(DEB_HOST_GNU_TYPE),$(DEB_BUILD_GNU_TYPE))
> STRIP = $(DEB_HOST_GNU_TYPE)-strip
>   else
> STRIP = strip
>   endif
> endif
> ...
> $(STRIP) -R .comment -R .note debian/bash.preinst
> 
> This sets me into a R shell :-)
> 
> Reproducer:
> $ apt-get source bash
> $ cd bash-4.4
> $ DEB_BUILD_OPTIONS="" debuild -b -uc -us
> 
> $(DEB_BUILD_OPTIONS) is empty by default here.

please read about bug severities. This works by default as seen by the latest
binNMU.

Bug#857953: bash: debian/rules execute $(STRIP) even when empty

[Tim Ruehsen]

Package: bash
Version: 4.4-4+b1
Severity: serious
Justification: fails to build from source (but built successfully in the past)

Dear Maintainer,

in debian/rules the $(STRIP) command is tried to be executed even when empty.

The code is
ifneq (,$(findstring nostrip,$(DEB_BUILD_OPTIONS)))
  ifneq ($(DEB_HOST_GNU_TYPE),$(DEB_BUILD_GNU_TYPE))
STRIP = $(DEB_HOST_GNU_TYPE)-strip
  else
STRIP = strip
  endif
endif
...
$(STRIP) -R .comment -R .note debian/bash.preinst

This sets me into a R shell :-)

Reproducer:
$ apt-get source bash
$ cd bash-4.4
$ DEB_BUILD_OPTIONS="" debuild -b -uc -us

$(DEB_BUILD_OPTIONS) is empty by default here.

Regards, Tim

-- System Information:
Debian Release: 9.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL 
set to en_US.UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages bash depends on:
ii  base-files   9.8
ii  dash 0.5.8-2.4
ii  debianutils  4.8.1
ii  libc62.24-9
ii  libtinfo56.0+20161126-1

Versions of packages bash recommends:
ii  bash-completion  1:2.1-4.3

Versions of packages bash suggests:
pn  bash-doc  

-- Configuration Files:
/etc/bash.bashrc changed:
[ -z "$PS1" ] && return
shopt -s checkwinsize
if [ -z "${debian_chroot:-}" ] && [ -r /etc/debian_chroot ]; then
debian_chroot=$(cat /etc/debian_chroot)
fi
PS1='${debian_chroot:+($debian_chroot)}\u@\h:\w\$ '
if ! shopt -oq posix; then
  if [ -f /usr/share/bash-completion/bash_completion ]; then
. /usr/share/bash-completion/bash_completion
  elif [ -f /etc/bash_completion ]; then
. /etc/bash_completion
  fi
fi
if [ -x /usr/lib/command-not-found -o -x 
/usr/share/command-not-found/command-not-found ]; then
function command_not_found_handle {
# check because c-n-f could've been removed in the meantime
if [ -x /usr/lib/command-not-found ]; then
   /usr/lib/command-not-found -- "$1"
   return $?
elif [ -x /usr/share/command-not-found/command-not-found ]; then
   /usr/share/command-not-found/command-not-found -- "$1"
   return $?
else
   printf "%s: command not found\n" "$1" >&2
   return 127
fi
}
fi


-- no debconf information