Bug#859048: Attachment check hook prevents IMP smartmobile view to send message with 'attachment' word when there's no attachment

[Leonardo Bruno]

Hi folks!

This has been confirmed by Michael Rubinsky as a IMP bug -- reported here
https://bugs.horde.org/ticket/14610. It was already resolved by the Michael
Rubinsky himself.

Thank you all,
Leonardo Bruno

Bug#859048: [pkg-horde] Bug#859048: Attachment check hook prevents IMP smartmobile view to send message with 'attachment' word when there's no attachment

[Leonardo Bruno]

Em 30/03/2017 04:31, "Mathieu Parent"  escreveu:

2017-03-29 21:28 GMT+02:00 Leonardo Bruno :
> Package: php-horde-imp
> Version: 6.2.2-3
> Severity: important
>
> Scenario: Compose a message using the IMP smartmobile view in a Horde
setup
> with the 'attach_body_check' enabled.

>
> Symptoms: When using the IMP smartmobile view, it will not be possible to
> send a message without attachments if in the message body text there is
any
> of the keywords defined in the 'attach_body_check' IMP hook function.
>
> The first attempt to send will show a warning message informing that no
> attachments are indeed present, as it is expected. However, the following
> attempts present the same behavior: a message warns about the absence of
> attachments and the message is not sent. It will only be sent if: 1) you
> remove the keyword(s) from the message, or 2) add some attachment, or 3)
> disable the hook.
>
> Remarks:
> 1. Only the smartmobile view is affected.
> 2. The tests where performed with the default Horde and IMP prefs. The
only
> hooke enabled is 'attach_body_check'.
> 3. This issue affects the upcoming php-horde-imp stable package (version
> 6.2.17-1) in Debian stretch.
> 4. I chose to mark this report as 'important' as the smartmobile view
> actually is a must-have feature, and there is no way to deactivate the
> 'attach_body_check' only for this view.

This is probably related to #749799.

Help on this is appreciated.

Regards


--
Mathieu


Dear Mathieu,

This surely should be related to the jQuery issue.

However, it may be helpful to inform that I updated the jQuery on the Horde
setup I detected the problem with the 'attach_body_check'.

I simply downloaded the jQuery version that is included with Horde code
from the development team, and symlinked it in place of the version shipped
with Debian.

So I can confirm that the smartmobile view seems to work correctly, from
the jQuery point of view. For my users and for me, the main features of
Horde, IMP, Turba, Kronolith and Ingo work well on smart phones.

Additionally, I did a little debugging and detected that, in some way,
the 'IMP_Factory_Compose' class constructor is called as many times as the
users clicks 'Send' button while composing messages on the smartmobile view.

This behavior seems to be incorrect as that constructor is called just once
in the Dynamic view which works correctly.

I could also see that each time the 'IMP_Factory_Compose' constructor is
called, a new 'object' is generated with the _metadata['attach_body_check']
attribute not set. A different value for the _cacheid attribute is
generated every time.

This - I suppose - is causing the attach body verification code to always
detect the currently being composed message as a 'new-still-no-verified'
message, which is consistent white the endless loop behavior while trying
to send the message.

As the smartmobile view is primarily driven by jQuery, this can be related
the the Horde JS code or to the library itself.

Regards,
Leonardo Bruno

Bug#859048: [pkg-horde] Bug#859048: Attachment check hook prevents IMP smartmobile view to send message with 'attachment' word when there's no attachment

[Mathieu Parent]

2017-03-29 21:28 GMT+02:00 Leonardo Bruno :
> Package: php-horde-imp
> Version: 6.2.2-3
> Severity: important
>
> Scenario: Compose a message using the IMP smartmobile view in a Horde setup
> with the 'attach_body_check' enabled.
>
> Symptoms: When using the IMP smartmobile view, it will not be possible to
> send a message without attachments if in the message body text there is any
> of the keywords defined in the 'attach_body_check' IMP hook function.
>
> The first attempt to send will show a warning message informing that no
> attachments are indeed present, as it is expected. However, the following
> attempts present the same behavior: a message warns about the absence of
> attachments and the message is not sent. It will only be sent if: 1) you
> remove the keyword(s) from the message, or 2) add some attachment, or 3)
> disable the hook.
>
> Remarks:
> 1. Only the smartmobile view is affected.
> 2. The tests where performed with the default Horde and IMP prefs. The only
> hooke enabled is 'attach_body_check'.
> 3. This issue affects the upcoming php-horde-imp stable package (version
> 6.2.17-1) in Debian stretch.
> 4. I chose to mark this report as 'important' as the smartmobile view
> actually is a must-have feature, and there is no way to deactivate the
> 'attach_body_check' only for this view.

This is probably related to #749799.

Help on this is appreciated.

Regards


-- 
Mathieu

Bug#859048: Attachment check hook prevents IMP smartmobile view to send message with 'attachment' word when there's no attachment

[Leonardo Bruno]

Package: php-horde-imp
Version: 6.2.2-3
Severity: important

Scenario: Compose a message using the IMP smartmobile view in a Horde setup
with the 'attach_body_check' enabled.

Symptoms: When using the IMP smartmobile view, it will not be possible to
send a message without attachments if in the message body text there is any
of the keywords defined in the 'attach_body_check' IMP hook function.

The first attempt to send will show a warning message informing that no
attachments are indeed present, as it is expected. However, the following
attempts present the same behavior: a message warns about the absence of
attachments and the message is not sent. It will only be sent if: 1) you
remove the keyword(s) from the message, or 2) add some attachment, or 3)
disable the hook.

Remarks:
1. Only the smartmobile view is affected.
2. The tests where performed with the default Horde and IMP prefs. The only
hooke enabled is 'attach_body_check'.
3. This issue affects the upcoming php-horde-imp stable package (version
6.2.17-1) in Debian stretch.
4. I chose to mark this report as 'important' as the smartmobile view
actually is a must-have feature, and there is no way to deactivate the
'attach_body_check' only for this view.

Regards,
Leonardo Bruno

-- System Information:
Debian Release: 8.7
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable'), (500, 'oldstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=pt_BR.UTF-8, LC_CTYPE=pt_BR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages php-horde-imp depends on:
ii  php-horde  5.2.1+debian0-2+deb8u3
ii  php-horde-auth 2.1.5-5
ii  php-horde-browser  2.0.7-2
ii  php-horde-cache2.5.0-2
ii  php-horde-compress 2.0.8-5
ii  php-horde-core 2.15.0+debian0-1+deb8u1
ii  php-horde-crypt2.5.0-5
ii  php-horde-css-parser   1.0.4-5
ii  php-horde-date 2.0.12-5
ii  php-horde-editor   2.0.4+debian0-3
ii  php-horde-exception2.0.4-4
ii  php-horde-icalendar2.0.9-4
ii  php-horde-image2.1.0-4
ii  php-horde-imap-client  2.25.2-1
ii  php-horde-itip 2.0.6-4
ii  php-horde-listheaders  1.1.5-4
ii  php-horde-logintasks   2.0.3-4
ii  php-horde-mail 2.4.0-4
ii  php-horde-mail-autoconfig  1.0.1-3
ii  php-horde-mime 2.4.5-3
ii  php-horde-mime-viewer  2.0.7-2
ii  php-horde-nls  2.0.4-2
ii  php-horde-notification 2.0.1-6
ii  php-horde-pack 1.0.4-2
ii  php-horde-perms2.1.2-4
ii  php-horde-spellchecker 2.1.1-4
ii  php-horde-stream   1.6.1-4
ii  php-horde-stream-filter2.0.2-4
ii  php-horde-stream-wrapper   2.1.0-4
ii  php-horde-support  2.1.1-4
ii  php-horde-text-filter  2.2.1-5
ii  php-horde-text-flowed  2.0.1-6
ii  php-horde-tree 2.0.2-3
ii  php-horde-url  2.2.3-4
ii  php-horde-util 2.5.1-5
ii  php-horde-vfs  2.2.0-4
ii  php-horde-view 2.0.4-4
ii  php5-cli   5.6.30+dfsg-0+deb8u1
ii  php5-common5.6.30+dfsg-0+deb8u1
ii  php5-json  1.3.6-1

Versions of packages php-horde-imp recommends:
ii  php-horde-history   2.3.1-4
ii  php-horde-http  2.1.1-4
ii  php-horde-service-gravatar  1.0.0-4

php-horde-imp suggests no packages.

-- no debconf information