Bug#859667: [Pkg-d-devel] Bug#859667: libundead: FTBFS on armhf and ppc64el: tests fail
On 9 April 2017 at 14:40, Andreas Tille wrote: > reopen 859667 > thanks > > On Fri, Apr 07, 2017 at 06:03:46PM +0200, Iain Buclaw wrote: >> > >> > >> > I have the feelingt that this meand "no" to your second question. >> > >> >> isNaN is from the std.math module. >> >> http://dlang.org/phobos/std_math.html#.isNaN >> >> You would need to import it. ;-) > > I think this helped so far but now I get: > > ... > ake[1]: Entering directory '/«PKGBUILDDIR»' > ninja -Cbuild -v test > ninja: Entering directory `build' > [0/1] '/usr/bin/python3' '/usr/share/meson/mesontest' '--no-rebuild' > '--print-errorlogs' > 1/1 undead_testsFAIL 0.03 s > > OK: 0 > FAIL: 1 > SKIP: 0 > TIMEOUT:0 > > > The output from the failed tests: > > 1/1 undead_testsFAIL 0.03 s > ... > > (see [1]) which looks even more strange to me. Any further hints? > > Kind regards > >Andreas. > > [1] > https://buildd.debian.org/status/fetch.php?pkg=libundead&arch=armhf&ver=1.0.6-2&stamp=1491647055&raw=0 > > -- > http://fam-tille.de There's nothing of any concrete value in the logs as far as I can see. --- [25/25] ldc2 -of undead_test ... --- I guess you'll get more information by running the undead_test yourself, rather than through mesontest. Also check the return code if that doesn't help either.
Bug#859667: [Pkg-d-devel] Bug#859667: libundead: FTBFS on armhf and ppc64el: tests fail
reopen 859667 thanks On Fri, Apr 07, 2017 at 06:03:46PM +0200, Iain Buclaw wrote: > > > > > > I have the feelingt that this meand "no" to your second question. > > > > isNaN is from the std.math module. > > http://dlang.org/phobos/std_math.html#.isNaN > > You would need to import it. ;-) I think this helped so far but now I get: ... ake[1]: Entering directory '/«PKGBUILDDIR»' ninja -Cbuild -v test ninja: Entering directory `build' [0/1] '/usr/bin/python3' '/usr/share/meson/mesontest' '--no-rebuild' '--print-errorlogs' 1/1 undead_testsFAIL 0.03 s OK: 0 FAIL: 1 SKIP: 0 TIMEOUT:0 The output from the failed tests: 1/1 undead_testsFAIL 0.03 s ... (see [1]) which looks even more strange to me. Any further hints? Kind regards Andreas. [1] https://buildd.debian.org/status/fetch.php?pkg=libundead&arch=armhf&ver=1.0.6-2&stamp=1491647055&raw=0 -- http://fam-tille.de
Bug#859667: [Pkg-d-devel] Bug#859667: libundead: FTBFS on armhf and ppc64el: tests fail
Στις 07-04-2017, ημέρα Παρ, και ώρα 18:03 +0200, ο/η Iain Buclaw έγραψε: > On 7 April 2017 at 16:02, Andreas Tille wrote: > > On Wed, Apr 05, 2017 at 10:22:28PM +0200, Iain Buclaw wrote: > > > Which compiler? > > > > $ LANG=C apt-cache policy ldc > > ldc: > > Installed: 1:1.1.1-1 > > > > > Are NaNs being honoured? > > > > Hmmm, no idea how to check this. > > > > Someone who maintains ldc might know. :-) Hi Andreas, long time :) There are some issues with ldc on arm/ppc64le ports currently and I would like to build a new ldc package based on a 1.2 beta which is out now as it seems to fix most of those -no idea if that's also the case with libundead, but it's possible, some of them are math related. I hope to do that in the next days, but time is really short these days, I apologize for the delay :) Regards Konstantinos signature.asc Description: This is a digitally signed message part
Bug#859667: [Pkg-d-devel] Bug#859667: libundead: FTBFS on armhf and ppc64el: tests fail
On 7 April 2017 at 16:02, Andreas Tille wrote: > On Wed, Apr 05, 2017 at 10:22:28PM +0200, Iain Buclaw wrote: >> Which compiler? > > $ LANG=C apt-cache policy ldc > ldc: > Installed: 1:1.1.1-1 > >> Are NaNs being honoured? > > Hmmm, no idea how to check this. > Someone who maintains ldc might know. :-) >> What if you were to replace >> the `(x != x && f != f)` comparison with `(isNaN(x) && isNaN(f))` ? > > If I apply the following patch > > --- a/src/undead/stream.d > +++ b/src/undead/stream.d > @@ -1455,7 +1455,7 @@ class Stream : InputStream, OutputStream > >float f; >assert(s.readf(&f)); > - assert(x == f || (x != x && f != f)); //either equal or both NaN > + assert(x == f || (isNaN(x) && isNaN(f))); //either equal or both NaN > } > > tryFloatRoundtrip(1.0); > > > I get > > ... > [12/25] ldc2 '-Iundead_test@exe' '-I.' '-I..' '-I../src/' '-enable-color' > '-O' '-release' '-g' '-unittest' -of 'undead_test@exe/src_undead_stream.d.o' > -c ../src/undead/stream.d > FAILED: undead_test@exe/src_undead_stream.d.o > ldc2 '-Iundead_test@exe' '-I.' '-I..' '-I../src/' '-enable-color' '-O' > '-release' '-g' '-unittest' -of 'undead_test@exe/src_undead_stream.d.o' -c > ../src/undead/stream.d > ../src/undead/stream.d(1458): Error: undefined identifier 'isNaN' > ../src/undead/stream.d(1458): Error: undefined identifier 'isNaN' > > > I have the feelingt that this meand "no" to your second question. > isNaN is from the std.math module. http://dlang.org/phobos/std_math.html#.isNaN You would need to import it. ;-)
Bug#859667: [Pkg-d-devel] Bug#859667: libundead: FTBFS on armhf and ppc64el: tests fail
On Wed, Apr 05, 2017 at 10:22:28PM +0200, Iain Buclaw wrote: > Which compiler? $ LANG=C apt-cache policy ldc ldc: Installed: 1:1.1.1-1 > Are NaNs being honoured? Hmmm, no idea how to check this. > What if you were to replace > the `(x != x && f != f)` comparison with `(isNaN(x) && isNaN(f))` ? If I apply the following patch --- a/src/undead/stream.d +++ b/src/undead/stream.d @@ -1455,7 +1455,7 @@ class Stream : InputStream, OutputStream float f; assert(s.readf(&f)); - assert(x == f || (x != x && f != f)); //either equal or both NaN + assert(x == f || (isNaN(x) && isNaN(f))); //either equal or both NaN } tryFloatRoundtrip(1.0); I get ... [12/25] ldc2 '-Iundead_test@exe' '-I.' '-I..' '-I../src/' '-enable-color' '-O' '-release' '-g' '-unittest' -of 'undead_test@exe/src_undead_stream.d.o' -c ../src/undead/stream.d FAILED: undead_test@exe/src_undead_stream.d.o ldc2 '-Iundead_test@exe' '-I.' '-I..' '-I../src/' '-enable-color' '-O' '-release' '-g' '-unittest' -of 'undead_test@exe/src_undead_stream.d.o' -c ../src/undead/stream.d ../src/undead/stream.d(1458): Error: undefined identifier 'isNaN' ../src/undead/stream.d(1458): Error: undefined identifier 'isNaN' I have the feelingt that this meand "no" to your second question. Any other hints? Kind regards Andreas. -- http://fam-tille.de
Bug#859667: [Pkg-d-devel] Bug#859667: libundead: FTBFS on armhf and ppc64el: tests fail
Which compiler? Are NaNs being honoured? What if you were to replace the `(x != x && f != f)` comparison with `(isNaN(x) && isNaN(f))` ? On 5 April 2017 at 22:00, Andreas Tille wrote: > Hi, > > I admit I'm totally clueless and thus I'm asking D language team as well as > porters for help. > > Thanks for any helpful hint > > Andreas. > > On Wed, Apr 05, 2017 at 02:43:04PM -0400, Aaron M. Ucko wrote: >> Source: libundead >> Version: 1.0.6-1 >> Severity: important >> Justification: fails to build from source >> >> The libundead builds for armhf and ppc64 both failed with test suite >> errors. On armf, I see no specific indication of what went wrong, but >> presume it should be possible to reproduce the problem on a porterbox. >> On ppc64el, the log reports an assertion failure at >> https://anonscm.debian.org/cgit/debian-med/libundead.git/tree/src/undead/stream.d#n1458: >> >> core.exception.AssertError@../src/undead/stream.d(1458): Assertion failure >> >> Could you please take a look? >> >> Thanks! >> >> -- >> Aaron M. Ucko, KB1CJC (amu at alum.mit.edu, ucko at debian.org) >> http://www.mit.edu/~amu/ | http://stuff.mit.edu/cgi/finger/?a...@monk.mit.edu >> >> ___ >> Debian-med-packaging mailing list >> debian-med-packag...@lists.alioth.debian.org >> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-med-packaging >> > > -- > http://fam-tille.de > > ___ > Pkg-d-devel mailing list > pkg-d-de...@lists.alioth.debian.org > http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-d-devel
