Bug#859875: samba: Please enable avahi support

[Laurent Bigonville]

Package: src:samba
Followup-For: Bug #859875

Hi,

Please find the attached patch.

Cheers,

Laurent Bigonville

-- System Information:
Debian Release: 9.0
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 
'experimental-debug'), (1, 'experimental')
Architecture: amd64
 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
>From 618940bfb4188107e2aa54ee06ca3896dc0eb6e1 Mon Sep 17 00:00:00 2001
From: Laurent Bigonville 
Date: Wed, 19 Apr 2017 17:49:05 +0200
Subject: [PATCH] Enable avahi support

This is used to advertise the _smb._tcp service with the name of the
domain.

samba will continue to work as before if avahi is not enabled on the
machine.

Closes: #859875
---
 debian/control | 2 ++
 debian/rules   | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/debian/control b/debian/control
index f0fe3f5848..b5f85fb15a 100644
--- a/debian/control
+++ b/debian/control
@@ -21,6 +21,8 @@ Build-Depends: bison,
libaio-dev [linux-any],
libarchive-dev,
libattr1-dev,
+   libavahi-client-dev,
+   libavahi-common-dev,
libblkid-dev,
libbsd-dev,
libcap-dev [linux-any],
diff --git a/debian/rules b/debian/rules
index 0f659a1909..5a9aeb3bab 100755
--- a/debian/rules
+++ b/debian/rules
@@ -63,7 +63,7 @@ conf_args = \
--with-lockdir=/var/run/samba \
--with-statedir=/var/lib/samba \
--with-cachedir=/var/cache/samba \
-   --disable-avahi \
+   --enable-avahi \
--disable-rpath \
--disable-rpath-install \

--bundled-libraries=NONE,pytevent,iniparser,roken,wind,hx509,asn1,heimbase,hcrypto,krb5,gssapi,heimntlm,hdb,kdc,com_err,compile_et,asn1_compile
 \
-- 
2.11.0

Bug#859875: samba: Please enable avahi support

[Laurent Bigonville]

Source: samba
Version: 2:4.5.8+dfsg-1
Severity: wishlist

Hi,

Any reasons why the avahi support is disabled in debian?

I see the following entry in the debian/changelog file:

samba (2:3.4.1-2) unstable; urgency=low

  * ./configure --disable-avahi, to avoid accidentally picking up an avahi
dependency when libavahi-common-dev is installed.

 -- Steve Langasek   Sat, 26 Sep 2009 00:01:12 -0700

But I'm not sure about the rational behind this.

Quickly looking at the code, it seems that if avahi is not available,
the only thing that will happen is two new debug messages.

Cheers,

Laurent Bigonville

-- System Information:
Debian Release: 9.0
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 
'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-2-amd64 (SMP w/8 CPU cores)
Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

-- no debconf information