Bug#860275: msp430mcu: invalid paths returned from /usr/bin/msp430mcu-config

[Vagrant Cascadian]

On 2022-10-20, Vagrant Cascadian wrote:
Control: tags 860274 -pending
Control: tags 860275 pending

Er... That's what I meant.

> I've submitted an NMU to DELAYED/10 fixing this issue:
>
> diff -Nru msp430mcu-20120406/debian/changelog 
> msp430mcu-20120406/debian/changelog
> --- msp430mcu-20120406/debian/changelog   2022-04-22 10:18:57.0 
> -0700
> +++ msp430mcu-20120406/debian/changelog   2022-10-20 10:57:45.0 
> -0700
> @@ -1,3 +1,12 @@
> +msp430mcu (20120406-2.3) unstable; urgency=medium
> +
> +  * Non-maintainer upload.
> +
> +  [ Chris Lamb ]
> +  * Fix invalid paths in /usr/bin/msp430mcu-config. (Closes: #860275)
> +
> + -- Vagrant Cascadian   Thu, 20 Oct 2022 
> 10:57:45 -0700
> +
>  msp430mcu (20120406-2.2) unstable; urgency=medium
>  
>* Non-maintainer upload.
> diff -Nru msp430mcu-20120406/debian/rules msp430mcu-20120406/debian/rules
> --- msp430mcu-20120406/debian/rules   2012-05-10 08:16:44.0 -0700
> +++ msp430mcu-20120406/debian/rules   2022-10-20 10:57:45.0 -0700
> @@ -2,7 +2,8 @@
>  
>  # Package name, source dir and target installation dir.
>  PACKAGE=msp430mcu
> -DESTDIR=$(CURDIR)/debian/$(PACKAGE)/usr
> +TARGET=$(CURDIR)/debian/$(PACKAGE)
> +DESTDIR=$(TARGET)/usr
>  
>  # Uncomment this to turn on verbose mode.
>  #export DH_VERBOSE=1
> @@ -28,6 +29,7 @@
>   dh_installdirs
>  
>   MSP430MCU_ROOT=$(CURDIR) scripts/install.sh $(DESTDIR)
> + sed -i -e 's!$(TARGET)!!g' $(DESTDIR)/bin/msp430mcu-config # Strip 
> build path
>  
>  binary-arch: binary-indep
>  
>
> live well,
>   vagrant


signature.asc
Description: PGP signature

Bug#860275: msp430mcu: invalid paths returned from /usr/bin/msp430mcu-config

[Vagrant Cascadian]

Control: tags 860274 pending

I've submitted an NMU to DELAYED/10 fixing this issue:

diff -Nru msp430mcu-20120406/debian/changelog 
msp430mcu-20120406/debian/changelog
--- msp430mcu-20120406/debian/changelog 2022-04-22 10:18:57.0 -0700
+++ msp430mcu-20120406/debian/changelog 2022-10-20 10:57:45.0 -0700
@@ -1,3 +1,12 @@
+msp430mcu (20120406-2.3) unstable; urgency=medium
+
+  * Non-maintainer upload.
+
+  [ Chris Lamb ]
+  * Fix invalid paths in /usr/bin/msp430mcu-config. (Closes: #860275)
+
+ -- Vagrant Cascadian   Thu, 20 Oct 2022 
10:57:45 -0700
+
 msp430mcu (20120406-2.2) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru msp430mcu-20120406/debian/rules msp430mcu-20120406/debian/rules
--- msp430mcu-20120406/debian/rules 2012-05-10 08:16:44.0 -0700
+++ msp430mcu-20120406/debian/rules 2022-10-20 10:57:45.0 -0700
@@ -2,7 +2,8 @@
 
 # Package name, source dir and target installation dir.
 PACKAGE=msp430mcu
-DESTDIR=$(CURDIR)/debian/$(PACKAGE)/usr
+TARGET=$(CURDIR)/debian/$(PACKAGE)
+DESTDIR=$(TARGET)/usr
 
 # Uncomment this to turn on verbose mode.
 #export DH_VERBOSE=1
@@ -28,6 +29,7 @@
dh_installdirs
 
MSP430MCU_ROOT=$(CURDIR) scripts/install.sh $(DESTDIR)
+   sed -i -e 's!$(TARGET)!!g' $(DESTDIR)/bin/msp430mcu-config # Strip 
build path
 
 binary-arch: binary-indep
 

live well,
  vagrant


signature.asc
Description: PGP signature

Bug#860275: msp430mcu: invalid paths returned from /usr/bin/msp430mcu-config

[Chris Lamb]

Source: msp430mcu
Version: 20120406-2
Severity: important
Tags: patch
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that msp430mcu-config has invalid configuration paths based on the
build path, eg:

│ │ │ │  --prefix)
│ │ │ │ -  echo /build/1st/msp430mcu-20120406/debian/msp430mcu/usr
│ │ │ │ +  echo /build/msp430mcu-20120406/2nd/debian/msp430mcu/usr
│ │ │ │;;
│ │ │ │  --scriptpath)
│ │ │ │ -  echo 
/build/1st/msp430mcu-20120406/debian/msp430mcu/usr/msp430/lib/ldscripts
│ │ │ │ +  echo 
/build/msp430mcu-20120406/2nd/debian/msp430mcu/usr/msp430/lib/ldscripts
│ │ │ │;;
│ │ │ │  --incpath)
│ │ │ │ -  echo 
/build/1st/msp430mcu-20120406/debian/msp430mcu/usr/msp430/include
│ │ │ │ +  echo /build/msp430mcu-20120406/2nd/debian/msp430m


Patch attached. There's probably a cleaner overall solution but I'll
leave that with you. :)

 [0] https://reproducible-builds.org/


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-
--- a/debian/rules  2017-04-13 21:55:46.082806261 +0100
--- b/debian/rules  2017-04-13 22:08:43.858311603 +0100
@@ -2,7 +2,8 @@
 
 # Package name, source dir and target installation dir.
 PACKAGE=msp430mcu
-DESTDIR=$(CURDIR)/debian/$(PACKAGE)/usr
+TARGET=$(CURDIR)/debian/$(PACKAGE)
+DESTDIR=$(TARGET)/usr
 
 # Uncomment this to turn on verbose mode.
 #export DH_VERBOSE=1
@@ -28,6 +29,7 @@
dh_installdirs
 
MSP430MCU_ROOT=$(CURDIR) scripts/install.sh $(DESTDIR)
+   sed -i -e 's!$(TARGET)!!g' $(DESTDIR)/bin/msp430mcu-config # Strip 
build path
 
 binary-arch: binary-indep