Bug#860752: libnftnl: Please honour DEB_BUILD_OPTIONS=nocheck

[Manuel A. Fernandez Montecelo]

Control: fixed -1 1.0.7-2


Hi,

2017-04-20 11:11 Manuel A. Fernandez Montecelo:

Hi,

2017-04-20 10:58 GMT+02:00 Arturo Borrero Gonzalez :

On 19 April 2017 at 20:24, Manuel A. Fernandez Montecelo
 wrote:

Source: libnftnl
Version: Please honour DEB_BUILD_OPTIONS=nocheck
Severity: wishlist
Tags: patch
User: debian-ri...@lists.debian.org
Usertags: riscv64

Hello,

The workaround for the tests overriding dh_auto_test in debian/rules means that
DEB_BUILD_OPTIONS=nocheck is not honoured.

It would be great if you could fix this, either not overriding dh_auto_test (if
the issue is fixed now) or by surrounding the check with something like the
attached patch.


Thanks for the patch.

If you don't mind, I would wait for the stretch stable release to
happen before applying it.


Yes, it's fine, I expected that :-)


Fixed by applying another patch doing basically the same, so marking
this one as closed:

 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=872326


Thanks.

--
Manuel A. Fernandez Montecelo 

Bug#860752: libnftnl: Please honour DEB_BUILD_OPTIONS=nocheck

[Manuel A. Fernandez Montecelo]

Hi,

2017-04-20 10:58 GMT+02:00 Arturo Borrero Gonzalez :
> On 19 April 2017 at 20:24, Manuel A. Fernandez Montecelo
>  wrote:
>> Source: libnftnl
>> Version: Please honour DEB_BUILD_OPTIONS=nocheck
>> Severity: wishlist
>> Tags: patch
>> User: debian-ri...@lists.debian.org
>> Usertags: riscv64
>>
>> Hello,
>>
>> The workaround for the tests overriding dh_auto_test in debian/rules means 
>> that
>> DEB_BUILD_OPTIONS=nocheck is not honoured.
>>
>> It would be great if you could fix this, either not overriding dh_auto_test 
>> (if
>> the issue is fixed now) or by surrounding the check with something like the
>> attached patch.
>
> Thanks for the patch.
>
> If you don't mind, I would wait for the stretch stable release to
> happen before applying it.

Yes, it's fine, I expected that :-)

Thanks!

-- 
Manuel A. Fernandez Montecelo 

Bug#860752: libnftnl: Please honour DEB_BUILD_OPTIONS=nocheck

[Arturo Borrero Gonzalez]

On 19 April 2017 at 20:24, Manuel A. Fernandez Montecelo
 wrote:
> Source: libnftnl
> Version: Please honour DEB_BUILD_OPTIONS=nocheck
> Severity: wishlist
> Tags: patch
> User: debian-ri...@lists.debian.org
> Usertags: riscv64
>
> Hello,
>
> The workaround for the tests overriding dh_auto_test in debian/rules means 
> that
> DEB_BUILD_OPTIONS=nocheck is not honoured.
>
> It would be great if you could fix this, either not overriding dh_auto_test 
> (if
> the issue is fixed now) or by surrounding the check with something like the
> attached patch.

Thanks for the patch.

If you don't mind, I would wait for the stretch stable release to
happen before applying it.

Bug#860752: libnftnl: Please honour DEB_BUILD_OPTIONS=nocheck

[Manuel A. Fernandez Montecelo]

Source: libnftnl
Version: Please honour DEB_BUILD_OPTIONS=nocheck
Severity: wishlist
Tags: patch
User: debian-ri...@lists.debian.org
Usertags: riscv64

Hello,

The workaround for the tests overriding dh_auto_test in debian/rules means that
DEB_BUILD_OPTIONS=nocheck is not honoured.

It would be great if you could fix this, either not overriding dh_auto_test (if
the issue is fixed now) or by surrounding the check with something like the
attached patch.

Cheers.
--- debian/rules2016-12-21 12:06:28.0 +0100
+++ debian/rules-honour-nocheck 2017-04-19 20:20:19.247933442 +0200
@@ -23,6 +23,8 @@
dh_auto_test
 
# there are json testsuites issues in big endian arches
+ifneq (,$(filter nocheck, $(DEB_BUILD_OPTIONS)))
 ifeq (little,$(DEB_BUILD_ARCH_ENDIAN))
sh -c "cd tests; set -e; ./test-script.sh"
 endif
+endif